From f8e1fa930c990d3b7a1b5186b0e539932f5a767b Mon Sep 17 00:00:00 2001 From: stefan-niedermann Date: Fri, 24 Jan 2020 21:03:44 +0100 Subject: [PATCH] #378 Enhance category handling - Enhanced paddings - Only display keyboard when no category is given yet --- .../notes/android/fragment/CategoryAdapter.java | 2 +- .../android/fragment/CategoryDialogFragment.java | 12 +++++++----- app/src/main/res/layout/dialog_change_category.xml | 5 ++++- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryAdapter.java b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryAdapter.java index 8a129c6c..22537ed0 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryAdapter.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryAdapter.java @@ -99,7 +99,7 @@ public class CategoryAdapter extends RecyclerView.Adapter 0) { boolean currentSearchStringIsInCategories = false; - for (NavigationItem category : categories) { + for (NavigationItem category : categories.subList(1, categories.size())) { if (currentSearchString.equals(category.label)) { currentSearchStringIsInCategories = true; break; diff --git a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryDialogFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryDialogFragment.java index ebecfa7d..258699da 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryDialogFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/CategoryDialogFragment.java @@ -155,11 +155,13 @@ public class CategoryDialogFragment extends AppCompatDialogFragment { @Override public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); - editCategory.requestFocus(); - if (getDialog().getWindow() != null) { - getDialog().getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); - } else { - Log.w(TAG, "can not set SOFT_INPUT_STATE_ALWAYAS_VISIBLE because getWindow() == null"); + if (editCategory.getText() == null || editCategory.getText().length() == 0) { + editCategory.requestFocus(); + if (getDialog().getWindow() != null) { + getDialog().getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); + } else { + Log.w(TAG, "can not set SOFT_INPUT_STATE_ALWAYAS_VISIBLE because getWindow() == null"); + } } } diff --git a/app/src/main/res/layout/dialog_change_category.xml b/app/src/main/res/layout/dialog_change_category.xml index 61720591..b72104c1 100644 --- a/app/src/main/res/layout/dialog_change_category.xml +++ b/app/src/main/res/layout/dialog_change_category.xml @@ -6,7 +6,10 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:orientation="vertical" - android:padding="?dialogPreferredPadding"> + android:paddingStart="?dialogPreferredPadding" + android:paddingLeft="?dialogPreferredPadding" + android:paddingEnd="?dialogPreferredPadding" + android:paddingRight="?dialogPreferredPadding">