mirrors/nextcloud-notes-android
1
0
Fork 0
mirror of https://github.com/nextcloud/notes-android.git synced 2024-11-21 12:25:57 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix #1308 Crash when long pressing a note and swiping to the edge of the screen

Browse source 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
This commit is contained in:
Stefan Niedermann 2021-09-11 12:02:25 +02:00
parent 119fced969
commit a9fb6f12ba
3 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/it/niedermann/owncloud/notes/main/items/ItemAdapter.java
View file

@ -170,6 +170,10 @@ public class ItemAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> i
return itemList.get(notePosition);
}
public boolean hasItemPosition(int notePosition) {
return notePosition >= 0 && notePosition < itemList.size();
}
public void remove(@NonNull Item item) {
itemList.remove(item);
notifyDataSetChanged();

5
app/src/main/java/it/niedermann/owncloud/notes/main/items/selection/ItemSelectionTracker.java
View file

@ -31,7 +31,10 @@ public class ItemSelectionTracker {
@Override
public boolean canSetStateAtPosition(int position, boolean nextState) {
@Nullable Integer swipedPosition = adapter.getSwipedPosition();
return !adapter.getItem(position).isSection() && (swipedPosition == null || swipedPosition != position);
if (!adapter.hasItemPosition(position)) {
return false;
}
return (swipedPosition == null || swipedPosition != position) && !adapter.getItem(position).isSection();
}
@Override

2
fastlane/metadata/android/en-US/changelogs/3004013.txt Normal file
View file

@ -0,0 +1,2 @@
- 🐞 Fix potential crash when rendering a note with a checkbox (#1326) - by @pbek
- 🐞 Fix crash when long pressing a note and swiping to the edge of the screen (#1308)