From cb9164e249ab31aef9a2322be942e3609a198d40 Mon Sep 17 00:00:00 2001 From: Stefan Niedermann Date: Mon, 15 Mar 2021 10:00:30 +0100 Subject: [PATCH 1/3] Fix #890 Grid view: no padding top on Recycler View --- .../owncloud/notes/main/items/grid/GridItemDecoration.java | 3 ++- fastlane/metadata/android/en-US/changelogs/3002004.txt | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 fastlane/metadata/android/en-US/changelogs/3002004.txt diff --git a/app/src/main/java/it/niedermann/owncloud/notes/main/items/grid/GridItemDecoration.java b/app/src/main/java/it/niedermann/owncloud/notes/main/items/grid/GridItemDecoration.java index 40d8c56e..2cfcee88 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/main/items/grid/GridItemDecoration.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/main/items/grid/GridItemDecoration.java @@ -38,7 +38,8 @@ public class GridItemDecoration extends SectionItemDecoration { final int spanIndex = lp.getSpanIndex(); // First row gets some spacing at the top - if (position < spanCount && position < adapter.getFirstPositionOfViewType(ItemAdapter.TYPE_SECTION)) { + final int firstSectionPosition = adapter.getFirstPositionOfViewType(ItemAdapter.TYPE_SECTION); + if (position < spanCount && (firstSectionPosition < 0 || position < firstSectionPosition)) { outRect.top = gutter; } diff --git a/fastlane/metadata/android/en-US/changelogs/3002004.txt b/fastlane/metadata/android/en-US/changelogs/3002004.txt new file mode 100644 index 00000000..06e14755 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/3002004.txt @@ -0,0 +1 @@ +- 🐞 Grid view: no padding top on first line in some cases (#890) \ No newline at end of file From 60610b7a87164c60b5f2b03fb4199f6b4e77aa6d Mon Sep 17 00:00:00 2001 From: Stefan Niedermann Date: Tue, 16 Mar 2021 13:49:22 +0100 Subject: [PATCH 2/3] #945 Category label in grid view doesn't take highlight background colour upon selection --- .../owncloud/notes/main/items/NoteViewHolder.java | 15 +++++++++------ .../res/color/grid_item_background_selector.xml | 5 +++++ 2 files changed, 14 insertions(+), 6 deletions(-) create mode 100644 app/src/main/res/color/grid_item_background_selector.xml diff --git a/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java b/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java index a5a25331..d9d484aa 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java @@ -3,8 +3,6 @@ package it.niedermann.owncloud.notes.main.items; import android.content.Context; import android.content.res.ColorStateList; import android.graphics.Color; -import android.graphics.drawable.GradientDrawable; -import android.os.Build; import android.text.SpannableString; import android.text.TextUtils; import android.text.style.BackgroundColorSpan; @@ -65,8 +63,8 @@ public abstract class NoteViewHolder extends RecyclerView.ViewHolder { noteCategory.setVisibility(showCategory && !category.isEmpty() ? View.VISIBLE : View.GONE); noteCategory.setText(category); - @ColorInt int categoryForeground; - @ColorInt int categoryBackground; + @ColorInt final int categoryForeground; + @ColorInt final int categoryBackground; if (isDarkThemeActive) { if (ColorUtil.INSTANCE.isColorDark(mainColor)) { @@ -92,8 +90,13 @@ public abstract class NoteViewHolder extends RecyclerView.ViewHolder { noteCategory.setTextColor(categoryForeground); if (noteCategory instanceof Chip) { - ((Chip) noteCategory).setChipStrokeColor(ColorStateList.valueOf(categoryBackground)); - ((Chip) noteCategory).setChipBackgroundColor(ColorStateList.valueOf(isDarkThemeActive ? categoryBackground : Color.TRANSPARENT)); + final Chip chip = (Chip) noteCategory; + chip.setChipStrokeColor(ColorStateList.valueOf(categoryBackground)); + if(isDarkThemeActive) { + chip.setChipBackgroundColor(ColorStateList.valueOf(categoryBackground)); + } else { + chip.setChipBackgroundColorResource(R.color.grid_item_background_selector); + } } else { DrawableCompat.setTint(noteCategory.getBackground(), categoryBackground); } diff --git a/app/src/main/res/color/grid_item_background_selector.xml b/app/src/main/res/color/grid_item_background_selector.xml new file mode 100644 index 00000000..cc841345 --- /dev/null +++ b/app/src/main/res/color/grid_item_background_selector.xml @@ -0,0 +1,5 @@ + + + + + From e9e4ea833d14193afbaeddf33748eb1b402e2974 Mon Sep 17 00:00:00 2001 From: Stefan Niedermann Date: Tue, 16 Mar 2021 13:53:38 +0100 Subject: [PATCH 3/3] Update changelog --- fastlane/metadata/android/en-US/changelogs/3002005.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 fastlane/metadata/android/en-US/changelogs/3002005.txt diff --git a/fastlane/metadata/android/en-US/changelogs/3002005.txt b/fastlane/metadata/android/en-US/changelogs/3002005.txt new file mode 100644 index 00000000..400c20c8 --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/3002005.txt @@ -0,0 +1 @@ +- 🏷 Category label in grid view doesn't take highlight background colour upon selection (#945) \ No newline at end of file