mirror of
https://github.com/nextcloud/desktop.git
synced 2024-10-25 05:45:42 +03:00
dc85ee3f0a
It seems like verclsid.exe hangs on our class IDs when invoked through explorer.exe for 5-10 seconds. It doesn't hang if I invoke the same command line from cmd.exe, so there could be some process parameters that don't play well with our extra thread or to the pipe connection that we do in it. Delay creating the RemotePathChecker thread until the first IsMemberOf call. verclsid.exe only seems to instantiate a object of each registered class, without actually using them, so we can use this as a workaround. This should be fixing issue #2680.
186 lines
4 KiB
C++
186 lines
4 KiB
C++
/**
|
|
* Copyright (c) 2000-2013 Liferay, Inc. All rights reserved.
|
|
*
|
|
* This library is free software; you can redistribute it and/or modify it under
|
|
* the terms of the GNU Lesser General Public License as published by the Free
|
|
* Software Foundation; either version 2.1 of the License, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
|
* FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
|
|
* details.
|
|
*/
|
|
|
|
#include "stdafx.h"
|
|
|
|
#include "OCOverlay.h"
|
|
|
|
#include "OCOverlayFactory.h"
|
|
#include "RegistryUtil.h"
|
|
#include "StringUtil.h"
|
|
|
|
#include "UtilConstants.h"
|
|
#include "RemotePathChecker.h"
|
|
|
|
#include "resource.h"
|
|
|
|
#include <algorithm>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
|
|
using namespace std;
|
|
|
|
#pragma comment(lib, "shlwapi.lib")
|
|
|
|
extern HINSTANCE instanceHandle;
|
|
|
|
#define IDM_DISPLAY 0
|
|
#define IDB_OK 101
|
|
|
|
OCOverlay::OCOverlay(int state)
|
|
: _referenceCount(1)
|
|
, _checker(nullptr)
|
|
, _state(state)
|
|
{
|
|
}
|
|
|
|
OCOverlay::~OCOverlay(void)
|
|
{
|
|
}
|
|
|
|
void OCOverlay::lazyInit()
|
|
{
|
|
// On Vista we'll run into issue #2680 if we try to create the thread+pipe connection
|
|
// on any DllGetClassObject of our registered classes.
|
|
// Work around the issue by creating the static RemotePathChecker only once actually needed.
|
|
if (_checker)
|
|
return;
|
|
static RemotePathChecker s_remotePathChecker;
|
|
_checker = &s_remotePathChecker;
|
|
}
|
|
|
|
IFACEMETHODIMP_(ULONG) OCOverlay::AddRef()
|
|
{
|
|
return InterlockedIncrement(&_referenceCount);
|
|
}
|
|
|
|
IFACEMETHODIMP OCOverlay::QueryInterface(REFIID riid, void **ppv)
|
|
{
|
|
HRESULT hr = S_OK;
|
|
|
|
if (IsEqualIID(IID_IUnknown, riid) || IsEqualIID(IID_IShellIconOverlayIdentifier, riid))
|
|
{
|
|
*ppv = static_cast<IShellIconOverlayIdentifier *>(this);
|
|
}
|
|
else
|
|
{
|
|
hr = E_NOINTERFACE;
|
|
*ppv = NULL;
|
|
}
|
|
|
|
if (*ppv)
|
|
{
|
|
AddRef();
|
|
}
|
|
|
|
return hr;
|
|
}
|
|
|
|
IFACEMETHODIMP_(ULONG) OCOverlay::Release()
|
|
{
|
|
ULONG cRef = InterlockedDecrement(&_referenceCount);
|
|
if (0 == cRef)
|
|
{
|
|
delete this;
|
|
}
|
|
|
|
return cRef;
|
|
}
|
|
|
|
IFACEMETHODIMP OCOverlay::GetPriority(int *pPriority)
|
|
{
|
|
// this defines which handler has prededence, so
|
|
// we order this in terms of likelyhood
|
|
switch (_state) {
|
|
case State_OK:
|
|
*pPriority = 0;
|
|
case State_OKShared:
|
|
*pPriority = 1;
|
|
case State_Warning:
|
|
*pPriority = 2;
|
|
case State_WarningShared:
|
|
*pPriority = 3;
|
|
case State_Sync:
|
|
*pPriority = 4;
|
|
case State_SyncShared:
|
|
*pPriority = 5;
|
|
case State_Error:
|
|
*pPriority = 6;
|
|
case State_ErrorShared:
|
|
*pPriority = 7;
|
|
default:
|
|
*pPriority = 8;
|
|
}
|
|
|
|
return S_OK;
|
|
}
|
|
|
|
IFACEMETHODIMP OCOverlay::IsMemberOf(PCWSTR pwszPath, DWORD dwAttrib)
|
|
{
|
|
lazyInit();
|
|
assert(_checker);
|
|
auto watchedDirectories = _checker->WatchedDirectories();
|
|
|
|
wstring wpath(pwszPath);
|
|
wpath.append(L"\\");
|
|
vector<wstring>::iterator it;
|
|
bool watched = false;
|
|
for (it = watchedDirectories.begin(); it != watchedDirectories.end(); ++it) {
|
|
if (StringUtil::begins_with(wpath, *it)) {
|
|
watched = true;
|
|
}
|
|
}
|
|
|
|
if (!watched) {
|
|
return MAKE_HRESULT(S_FALSE, 0, 0);
|
|
}
|
|
|
|
int state = 0;
|
|
if (!_checker->IsMonitoredPath(pwszPath, &state)) {
|
|
return MAKE_HRESULT(S_FALSE, 0, 0);
|
|
}
|
|
return MAKE_HRESULT(state == _state ? S_OK : S_FALSE, 0, 0);
|
|
}
|
|
|
|
IFACEMETHODIMP OCOverlay::GetOverlayInfo(PWSTR pwszIconFile, int cchMax, int *pIndex, DWORD *pdwFlags)
|
|
{
|
|
*pIndex = 0;
|
|
*pdwFlags = ISIOI_ICONFILE | ISIOI_ICONINDEX;
|
|
*pIndex = _state;
|
|
|
|
if (GetModuleFileName(instanceHandle, pwszIconFile, cchMax) == 0) {
|
|
HRESULT hResult = HRESULT_FROM_WIN32(GetLastError());
|
|
wcerr << L"IsOK? " << (hResult == S_OK) << L" with path " << pwszIconFile << L", index " << *pIndex << endl;
|
|
return hResult;
|
|
}
|
|
|
|
return S_OK;
|
|
}
|
|
|
|
|
|
bool OCOverlay::_IsOverlaysEnabled()
|
|
{
|
|
//int enable;
|
|
bool success = false;
|
|
|
|
//if(RegistryUtil::ReadRegistry(REGISTRY_ROOT_KEY, REGISTRY_ENABLE_OVERLAY, &enable))
|
|
//{
|
|
// if(enable) {
|
|
// success = true;
|
|
// }
|
|
//}
|
|
|
|
return success;
|
|
}
|
|
|