mirror of
https://github.com/nextcloud/desktop.git
synced 2024-12-19 12:22:16 +03:00
8fad88055e
When we skip a watcher event on mac, we log the file path but not the event flags which came with it. Let's add it, it should help figure out what's going on with #2578. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
132 lines
4.3 KiB
C++
132 lines
4.3 KiB
C++
/*
|
|
* Copyright (C) by Markus Goetz <markus@woboq.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*/
|
|
#include "config.h"
|
|
|
|
#include "folder.h"
|
|
#include "folderwatcher.h"
|
|
#include "folderwatcher_mac.h"
|
|
|
|
|
|
#include <cerrno>
|
|
#include <QDirIterator>
|
|
#include <QStringList>
|
|
|
|
|
|
namespace OCC {
|
|
|
|
FolderWatcherPrivate::FolderWatcherPrivate(FolderWatcher *p, const QString &path)
|
|
: _parent(p)
|
|
, _folder(path)
|
|
{
|
|
this->startWatching();
|
|
}
|
|
|
|
FolderWatcherPrivate::~FolderWatcherPrivate()
|
|
{
|
|
FSEventStreamStop(_stream);
|
|
FSEventStreamInvalidate(_stream);
|
|
FSEventStreamRelease(_stream);
|
|
}
|
|
|
|
static void callback(
|
|
ConstFSEventStreamRef streamRef,
|
|
void *clientCallBackInfo,
|
|
size_t numEvents,
|
|
void *eventPathsVoid,
|
|
const FSEventStreamEventFlags eventFlags[],
|
|
const FSEventStreamEventId eventIds[])
|
|
{
|
|
Q_UNUSED(streamRef)
|
|
Q_UNUSED(eventFlags)
|
|
Q_UNUSED(eventIds)
|
|
|
|
const FSEventStreamEventFlags c_interestingFlags = kFSEventStreamEventFlagItemCreated // for new folder/file
|
|
| kFSEventStreamEventFlagItemRemoved // for rm
|
|
| kFSEventStreamEventFlagItemInodeMetaMod // for mtime change
|
|
| kFSEventStreamEventFlagItemRenamed // also coming for moves to trash in finder
|
|
| kFSEventStreamEventFlagItemModified; // for content change
|
|
//We ignore other flags, e.g. for owner change, xattr change, Finder label change etc
|
|
|
|
qCDebug(lcFolderWatcher) << "FolderWatcherPrivate::callback by OS X";
|
|
|
|
QStringList paths;
|
|
CFArrayRef eventPaths = (CFArrayRef)eventPathsVoid;
|
|
for (int i = 0; i < static_cast<int>(numEvents); ++i) {
|
|
CFStringRef path = reinterpret_cast<CFStringRef>(CFArrayGetValueAtIndex(eventPaths, i));
|
|
|
|
QString qstring;
|
|
CFIndex pathLength = CFStringGetLength(path);
|
|
qstring.resize(pathLength);
|
|
CFStringGetCharacters(path, CFRangeMake(0, pathLength), reinterpret_cast<UniChar *>(qstring.data()));
|
|
QString fn = qstring.normalized(QString::NormalizationForm_C);
|
|
|
|
if (!(eventFlags[i] & c_interestingFlags)) {
|
|
qCDebug(lcFolderWatcher) << "Ignoring non-content changes for" << fn << eventFlags[i];
|
|
continue;
|
|
}
|
|
|
|
paths.append(fn);
|
|
}
|
|
|
|
reinterpret_cast<FolderWatcherPrivate *>(clientCallBackInfo)->doNotifyParent(paths);
|
|
}
|
|
|
|
void FolderWatcherPrivate::startWatching()
|
|
{
|
|
qCDebug(lcFolderWatcher) << "FolderWatcherPrivate::startWatching()" << _folder;
|
|
CFStringRef folderCF = CFStringCreateWithCharacters(0, reinterpret_cast<const UniChar *>(_folder.unicode()),
|
|
_folder.length());
|
|
CFArrayRef pathsToWatch = CFStringCreateArrayBySeparatingStrings(nullptr, folderCF, CFSTR(":"));
|
|
|
|
FSEventStreamContext ctx = { 0, this, nullptr, nullptr, nullptr };
|
|
|
|
_stream = FSEventStreamCreate(nullptr,
|
|
&callback,
|
|
&ctx,
|
|
pathsToWatch,
|
|
kFSEventStreamEventIdSinceNow,
|
|
0, // latency
|
|
kFSEventStreamCreateFlagUseCFTypes | kFSEventStreamCreateFlagFileEvents | kFSEventStreamCreateFlagIgnoreSelf);
|
|
|
|
CFRelease(pathsToWatch);
|
|
CFRelease(folderCF);
|
|
FSEventStreamScheduleWithRunLoop(_stream, CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
|
|
FSEventStreamStart(_stream);
|
|
}
|
|
|
|
QStringList FolderWatcherPrivate::addCoalescedPaths(const QStringList &paths) const
|
|
{
|
|
QStringList coalescedPaths;
|
|
for (const auto &eventPath : paths) {
|
|
if (QDir(eventPath).exists()) {
|
|
QDirIterator it(eventPath, QDir::AllDirs | QDir::NoDotAndDotDot, QDirIterator::Subdirectories);
|
|
while (it.hasNext()) {
|
|
auto subfolder = it.next();
|
|
if (!paths.contains(subfolder)) {
|
|
coalescedPaths.append(subfolder);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return (paths + coalescedPaths);
|
|
}
|
|
|
|
void FolderWatcherPrivate::doNotifyParent(const QStringList &paths)
|
|
{
|
|
const QStringList totalPaths = addCoalescedPaths(paths);
|
|
_parent->changeDetected(totalPaths);
|
|
}
|
|
|
|
|
|
} // ns mirall
|