mirror of
https://github.com/nextcloud/desktop.git
synced 2024-10-28 16:13:53 +03:00
05d1cc9a94
The problem was that Share could be deleted *before* the OcsShareJob itself finished. Since Share was the parent of the network job, its object would be deleted too early. In general, it's unnecessary to assign parents to the OcsJobs because they delete themselves when finished.
124 lines
3.4 KiB
C++
124 lines
3.4 KiB
C++
/*
|
|
* Copyright (C) by Roeland Jago Douma <roeland@famdouma.nl>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*/
|
|
|
|
#include "ocsjob.h"
|
|
#include "networkjobs.h"
|
|
#include "account.h"
|
|
#include "json.h"
|
|
|
|
#include <QBuffer>
|
|
|
|
namespace OCC {
|
|
|
|
OcsJob::OcsJob(AccountPtr account)
|
|
: AbstractNetworkJob(account, "")
|
|
{
|
|
_passStatusCodes.append(100);
|
|
setIgnoreCredentialFailure(true);
|
|
}
|
|
|
|
void OcsJob::setVerb(const QByteArray &verb)
|
|
{
|
|
_verb = verb;
|
|
}
|
|
|
|
void OcsJob::addParam(const QString &name, const QString &value)
|
|
{
|
|
_params.append(qMakePair(name, value));
|
|
}
|
|
|
|
void OcsJob::addPassStatusCode(int code)
|
|
{
|
|
_passStatusCodes.append(code);
|
|
}
|
|
|
|
void OcsJob::appendPath(const QString &id)
|
|
{
|
|
setPath(path() + QLatin1Char('/') + id);
|
|
}
|
|
|
|
void OcsJob::start()
|
|
{
|
|
QNetworkRequest req;
|
|
req.setRawHeader("Ocs-APIREQUEST", "true");
|
|
req.setRawHeader("Content-Type", "application/x-www-form-urlencoded");
|
|
|
|
QUrl url = Account::concatUrlPath(account()->url(), path());
|
|
QBuffer *buffer = new QBuffer;
|
|
|
|
if (_verb == "GET") {
|
|
url.setQueryItems(_params);
|
|
} else if (_verb == "POST" || _verb == "PUT") {
|
|
// Url encode the _postParams and put them in a buffer.
|
|
QByteArray postData;
|
|
Q_FOREACH(auto tmp, _params) {
|
|
if (!postData.isEmpty()) {
|
|
postData.append("&");
|
|
}
|
|
postData.append(QUrl::toPercentEncoding(tmp.first));
|
|
postData.append("=");
|
|
postData.append(QUrl::toPercentEncoding(tmp.second));
|
|
}
|
|
buffer->setData(postData);
|
|
}
|
|
|
|
//We want json data
|
|
auto queryItems = url.queryItems();
|
|
queryItems.append(qMakePair(QString::fromLatin1("format"), QString::fromLatin1("json")));
|
|
url.setQueryItems(queryItems);
|
|
|
|
setReply(davRequest(_verb, url, req, buffer));
|
|
setupConnections(reply());
|
|
buffer->setParent(reply());
|
|
AbstractNetworkJob::start();
|
|
}
|
|
|
|
bool OcsJob::finished()
|
|
{
|
|
const QString replyData = reply()->readAll();
|
|
|
|
bool success;
|
|
QVariantMap json = QtJson::parse(replyData, success).toMap();
|
|
if (!success) {
|
|
qDebug() << "Could not parse reply to"
|
|
<< _verb
|
|
<< Account::concatUrlPath(account()->url(), path())
|
|
<< _params
|
|
<< ":" << replyData;
|
|
}
|
|
|
|
QString message;
|
|
const int statusCode = getJsonReturnCode(json, message);
|
|
if (!_passStatusCodes.contains(statusCode)) {
|
|
qDebug() << "Reply to"
|
|
<< _verb
|
|
<< Account::concatUrlPath(account()->url(), path())
|
|
<< _params
|
|
<< "has unexpected status code:" << statusCode << replyData;
|
|
emit ocsError(statusCode, message);
|
|
} else {
|
|
emit jobFinished(json);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
int OcsJob::getJsonReturnCode(const QVariantMap &json, QString &message)
|
|
{
|
|
//TODO proper checking
|
|
int code = json.value("ocs").toMap().value("meta").toMap().value("statuscode").toInt();
|
|
message = json.value("ocs").toMap().value("meta").toMap().value("message").toString();
|
|
|
|
return code;
|
|
}
|
|
|
|
}
|