/* * Copyright (C) by Claudio Cambra * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * for more details. */ #include "activitylistmodeltestutils.h" #include "syncenginetestutils.h" #include "syncresult.h" #include #include #include #include static QByteArray fake404Response = R"( {"ocs":{"meta":{"status":"failure","statuscode":404,"message":"Invalid query, please check the syntax. API specifications are here: http:\/\/www.freedesktop.org\/wiki\/Specifications\/open-collaboration-services.\n"},"data":[]}} )"; static QByteArray fake400Response = R"( {"ocs":{"meta":{"status":"failure","statuscode":400,"message":"Parameter is incorrect.\n"},"data":[]}} )"; static QByteArray fake500Response = R"( {"ocs":{"meta":{"status":"failure","statuscode":500,"message":"Internal Server Error.\n"},"data":[]}} )"; class TestActivityListModel : public QObject { Q_OBJECT public: TestActivityListModel() = default; ~TestActivityListModel() override { OCC::AccountManager::instance()->deleteAccount(accountState.data()); } QScopedPointer fakeQnam; OCC::AccountPtr account; QScopedPointer accountState; OCC::Activity testNotificationActivity; OCC::Activity testSyncResultErrorActivity; OCC::Activity testSyncFileItemActivity; OCC::Activity testFileIgnoredActivity; static constexpr int searchResultsReplyDelay = 100; QSharedPointer testingALM() { QSharedPointer model(new TestingALM); model->setAccountState(accountState.data()); QAbstractItemModelTester modelTester(model.data()); return model; } void testActivityAdd(void(OCC::ActivityListModel::*addingMethod)(const OCC::Activity&, OCC::ActivityListModel::ErrorType), OCC::Activity &activity) { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); (model.data()->*addingMethod)(activity, OCC::ActivityListModel::ErrorType::SyncError); QCOMPARE(model->rowCount(), 1); const auto index = model->index(0, 0); QVERIFY(index.isValid()); } void testActivityAdd(void(OCC::ActivityListModel::*addingMethod)(const OCC::Activity&), OCC::Activity &activity) { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); (model.data()->*addingMethod)(activity); QCOMPARE(model->rowCount(), 1); const auto index = model->index(0, 0); QVERIFY(index.isValid()); } void testActivityAdd(void(OCC::ActivityListModel::*addingMethod)(const OCC::Activity&, OCC::ActivityListModel::ErrorType), OCC::Activity &activity, OCC::ActivityListModel::ErrorType type) { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); (model.data()->*addingMethod)(activity, type); QCOMPARE(model->rowCount(), 1); const auto index = model->index(0, 0); QVERIFY(index.isValid()); } private slots: void initTestCase() { fakeQnam.reset(new FakeQNAM({})); account = OCC::Account::create(); account->setCredentials(new FakeCredentials{fakeQnam.data()}); account->setUrl(QUrl(("http://example.de"))); accountState.reset(new OCC::AccountState(account)); fakeQnam->setOverride([this](QNetworkAccessManager::Operation op, const QNetworkRequest &req, QIODevice *device) { Q_UNUSED(device); QNetworkReply *reply = nullptr; const auto urlQuery = QUrlQuery(req.url()); const auto format = urlQuery.queryItemValue(QStringLiteral("format")); const auto since = urlQuery.queryItemValue(QStringLiteral("since")).toInt(); const auto limit = urlQuery.queryItemValue(QStringLiteral("limit")).toInt(); const auto path = req.url().path(); if (!req.url().toString().startsWith(accountState->account()->url().toString())) { reply = new FakeErrorReply(op, req, this, 404, fake404Response); } if (format != QStringLiteral("json")) { reply = new FakeErrorReply(op, req, this, 400, fake400Response); } if (path.startsWith(QStringLiteral("/ocs/v2.php/apps/activity/api/v2/activity"))) { reply = new FakePayloadReply(op, req, FakeRemoteActivityStorage::instance()->activityJsonData(since, limit), searchResultsReplyDelay, fakeQnam.data()); } if (!reply) { return qobject_cast(new FakeErrorReply(op, req, this, 404, QByteArrayLiteral("{error: \"Not found!\"}"))); } return reply; }); OCC::AccountManager::instance()->addAccount(account); // Activity comparison is done by checking type, id, and accName // We need an activity with these details, at least testNotificationActivity._accName = accountState->account()->displayName(); testNotificationActivity._id = 1; testNotificationActivity._type = OCC::Activity::NotificationType; testNotificationActivity._dateTime = QDateTime::currentDateTime(); testNotificationActivity._subject = QStringLiteral("Sample notification text"); testSyncResultErrorActivity._id = 2; testSyncResultErrorActivity._type = OCC::Activity::SyncResultType; testSyncResultErrorActivity._syncResultStatus = OCC::SyncResult::Error; testSyncResultErrorActivity._dateTime = QDateTime::currentDateTime(); testSyncResultErrorActivity._subject = QStringLiteral("Sample failed sync text"); testSyncResultErrorActivity._message = QStringLiteral("/path/to/thingy"); testSyncResultErrorActivity._link = QStringLiteral("/path/to/thingy"); testSyncResultErrorActivity._accName = accountState->account()->displayName(); testSyncFileItemActivity._id = 3; testSyncFileItemActivity._type = OCC::Activity::SyncFileItemType; //client activity testSyncFileItemActivity._syncFileItemStatus = OCC::SyncFileItem::Success; testSyncFileItemActivity._dateTime = QDateTime::currentDateTime(); testSyncFileItemActivity._message = QStringLiteral("Sample file successfully synced text"); testSyncFileItemActivity._link = accountState->account()->url(); testSyncFileItemActivity._accName = accountState->account()->displayName(); testSyncFileItemActivity._file = QStringLiteral("xyz.pdf"); testFileIgnoredActivity._id = 4; testFileIgnoredActivity._type = OCC::Activity::SyncFileItemType; testFileIgnoredActivity._syncFileItemStatus = OCC::SyncFileItem::FileIgnored; testFileIgnoredActivity._dateTime = QDateTime::currentDateTime(); testFileIgnoredActivity._subject = QStringLiteral("Sample ignored file sync text"); testFileIgnoredActivity._link = accountState->account()->url(); testFileIgnoredActivity._accName = accountState->account()->displayName(); testFileIgnoredActivity._folder = QStringLiteral("thingy"); testFileIgnoredActivity._file = QStringLiteral("test.txt"); }; // Test receiving activity from server void testFetchingRemoteActivity() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->setCurrentItem(FakeRemoteActivityStorage::instance()->startingIdLast()); model->startFetchJob(); QSignalSpy activitiesJob(model.data(), &TestingALM::activitiesProcessed); QVERIFY(activitiesJob.wait(3000)); QCOMPARE(model->rowCount(), 50); }; // Test receiving activity from local user action void testLocalSyncFileAction() { testActivityAdd(&TestingALM::addSyncFileItemToActivityList, testSyncFileItemActivity); }; void testAddNotification() { testActivityAdd(&TestingALM::addNotificationToActivityList, testNotificationActivity); }; void testAddError() { testActivityAdd(&TestingALM::addErrorToActivityList, testSyncResultErrorActivity, OCC::ActivityListModel::ErrorType::SyncError); }; void testAddIgnoredFile() { testActivityAdd(&TestingALM::addIgnoredFileToList, testFileIgnoredActivity); }; // Test removing activity from list void testRemoveActivityWithRow() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->addNotificationToActivityList(testNotificationActivity); QCOMPARE(model->rowCount(), 1); model->removeActivityFromActivityList(0); QCOMPARE(model->rowCount(), 0); } void testRemoveActivityWithActivity() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->addNotificationToActivityList(testNotificationActivity); QCOMPARE(model->rowCount(), 1); model->removeActivityFromActivityList(testNotificationActivity); QCOMPARE(model->rowCount(), 0); } void testDummyFetchingActivitiesActivity() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->setCurrentItem(FakeRemoteActivityStorage::instance()->startingIdLast()); model->startFetchJob(); // Check for the dummy before activities have arrived QCOMPARE(model->rowCount(), 1); QSignalSpy activitiesJob(model.data(), &TestingALM::activitiesProcessed); QVERIFY(activitiesJob.wait(3000)); // Test the dummy was removed QCOMPARE(model->rowCount(), 50); } // Test getting the data from the model void testData() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->setCurrentItem(FakeRemoteActivityStorage::instance()->startingIdLast()); model->startFetchJob(); QSignalSpy activitiesJob(model.data(), &TestingALM::activitiesProcessed); QVERIFY(activitiesJob.wait(3000)); QCOMPARE(model->rowCount(), 50); model->addSyncFileItemToActivityList(testSyncFileItemActivity); QCOMPARE(model->rowCount(), 51); model->addErrorToActivityList(testSyncResultErrorActivity, OCC::ActivityListModel::ErrorType::SyncError); QCOMPARE(model->rowCount(), 52); model->addIgnoredFileToList(testFileIgnoredActivity); QCOMPARE(model->rowCount(), 53); model->addNotificationToActivityList(testNotificationActivity); QCOMPARE(model->rowCount(), 54); // Test all rows for things in common for (int i = 0; i < model->rowCount(); i++) { const auto index = model->index(i, 0); auto text = index.data(OCC::ActivityListModel::ActionTextRole).toString(); QVERIFY(index.data(OCC::ActivityListModel::ActionRole).canConvert()); const auto type = index.data(OCC::ActivityListModel::ActionRole).toInt(); QVERIFY(type >= OCC::Activity::DummyFetchingActivityType); QVERIFY(!index.data(OCC::ActivityListModel::AccountRole).toString().isEmpty()); QVERIFY(!index.data(OCC::ActivityListModel::ActionTextColorRole).toString().isEmpty()); QVERIFY(!index.data(OCC::ActivityListModel::DarkIconRole).toString().isEmpty()); QVERIFY(!index.data(OCC::ActivityListModel::LightIconRole).toString().isEmpty()); QVERIFY(!index.data(OCC::ActivityListModel::PointInTimeRole).toString().isEmpty()); QVERIFY(index.data(OCC::ActivityListModel::ObjectTypeRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::ObjectNameRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::ObjectIdRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::ActionsLinksRole).canConvert>()); QVERIFY(index.data(OCC::ActivityListModel::ActionTextRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::MessageRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::LinkRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::ActionsLinksForActionButtonsRole).canConvert>()); QVERIFY(index.data(OCC::ActivityListModel::AccountConnectedRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::DisplayActions).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::TalkNotificationConversationTokenRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::TalkNotificationMessageIdRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::TalkNotificationMessageSentRole).canConvert()); QVERIFY(index.data(OCC::ActivityListModel::ActivityRole).canConvert()); // Unfortunately, trying to check anything relating to filepaths causes a crash // when the folder manager is invoked by the model to look for the relevant file } }; void testActivityActionsData() { const auto model = testingALM(); QCOMPARE(model->rowCount(), 0); model->setCurrentItem(FakeRemoteActivityStorage::instance()->startingIdLast()); int prevModelRowCount = model->rowCount(); do { prevModelRowCount = model->rowCount(); model->startFetchJob(); QSignalSpy activitiesJob(model.data(), &TestingALM::activitiesProcessed); QVERIFY(activitiesJob.wait(3000)); for (int i = prevModelRowCount; i < model->rowCount(); i++) { const auto index = model->index(i, 0); const auto actionsLinks = index.data(OCC::ActivityListModel::ActionsLinksRole).toList(); if (!actionsLinks.isEmpty()) { const auto actionsLinksContextMenu = index.data(OCC::ActivityListModel::ActionsLinksContextMenuRole).toList(); // context menu must be shorter than total action links QVERIFY(actionsLinksContextMenu.isEmpty() || actionsLinksContextMenu.size() < actionsLinks.size()); // context menu must not contain the primary action QVERIFY(std::find_if(std::begin(actionsLinksContextMenu), std::end(actionsLinksContextMenu), [](const QVariant &entry) { return entry.value()._primary; }) == std::end(actionsLinksContextMenu)); const auto objectType = index.data(OCC::ActivityListModel::ObjectTypeRole).toString(); const auto actionButtonsLinks = index.data(OCC::ActivityListModel::ActionsLinksForActionButtonsRole).toList(); // Login attempt notification if (objectType == QStringLiteral("2fa_id")) { QVERIFY(actionsLinks.size() == 2); QVERIFY(actionsLinks[0].value()._primary); QVERIFY(!actionsLinks[1].value()._primary); QVERIFY(actionsLinksContextMenu.isEmpty()); } // Generate 2FA backup codes notification if (objectType == QStringLiteral("create")) { QVERIFY(actionsLinks.size() == 1); QVERIFY(!actionsLinks[0].value()._primary); QVERIFY(actionsLinksContextMenu.isEmpty()); } if ((objectType == QStringLiteral("chat") || objectType == QStringLiteral("call") || objectType == QStringLiteral("room"))) { auto replyActionPos = 0; if (objectType == QStringLiteral("call")) { replyActionPos = 1; } // both action links and buttons must contain a "REPLY" verb element as secondary action QVERIFY(actionsLinks[replyActionPos].value()._verb == QStringLiteral("REPLY")); //QVERIFY(actionButtonsLinks[replyActionPos].value()._verb == QStringLiteral("REPLY")); // the first action button for chat must have image set //QVERIFY(!actionButtonsLinks[replyActionPos].value()._imageSource.isEmpty()); //QVERIFY(!actionButtonsLinks[replyActionPos].value()._imageSourceHovered.isEmpty()); // logic for "chat" and other types of activities with multiple actions if ((objectType == QStringLiteral("chat") || (objectType != QStringLiteral("room") && objectType != QStringLiteral("call")))) { // button's label for "chat" must be renamed to "Reply" QVERIFY(actionButtonsLinks[0].value()._label == QObject::tr("Reply")); if (static_cast(actionsLinks.size()) > OCC::ActivityListModel::maxActionButtons()) { // in case total actions is longer than ActivityListModel::maxActionButtons, only one button must be present in a list of action buttons QVERIFY(actionButtonsLinks.size() == 1); const auto actionButtonsAndContextMenuEntries = actionButtonsLinks + actionsLinksContextMenu; // in case total actions is longer than ActivityListModel::maxActionButtons, then a sum of action buttons and action menu entries must be equal to a total of action links QVERIFY(actionButtonsLinks.size() + actionsLinksContextMenu.size() == actionsLinks.size()); } } else if ((objectType == QStringLiteral("call"))) { QVERIFY( actionButtonsLinks[0].value()._label == QStringLiteral("Call back")); } } } } } while (prevModelRowCount < model->rowCount()); }; }; QTEST_MAIN(TestActivityListModel) #include "testactivitylistmodel.moc"