Commit graph

22034 commits

Author SHA1 Message Date
Elsie Hupp
de55ae9b5e Show/Hide Menubar and Dock Icon
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
2024-10-17 11:33:31 +02:00
Matthieu Gallien
5bdc2b911d
Merge pull request #7343 from nextcloud/backport/7334/stable-3.14
[stable-3.14] Bugfix/use file id to track renamed items
2024-10-17 11:22:57 +02:00
Matthieu Gallien
a758ab3957 remove the enforcement of identical etag for a server side item MOVE
orignally added by https://github.com/owncloud/client/pull/6632

most probably a too strong assumption on the behavior of the Nextcloud
server

better check real item metadata like fileid, size or modification time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 11:22:48 +02:00
Matthieu Gallien
486750670e handle NEW/NEW conflicts by being real conflicts
NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions

we stop doing this and handle them like any other conflicts

that would cause more download from the server

those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata

will enable more changes to improve MOVE detection from server side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 11:22:48 +02:00
Matthieu Gallien
7a2443bf91 in automated tests, update modtime when modifying the content of a file
why one would not update the modification time when modifying a remote
file during automated tests

there is no reason to not update the modification time as this is what
is done by the server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 11:22:48 +02:00
Matthieu Gallien
65e5b50cf4
Merge pull request #7342 from nextcloud/backport/7291/stable-3.14
[stable-3.14] better logs to understand when a folder is locally discovered
2024-10-17 11:22:24 +02:00
Matthieu Gallien
5bc1f78331 better logs tounderstand when a folder is local scanned
should hopefully allows to understand when local file system discovery
is done or omitted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 11:22:11 +02:00
Matthieu Gallien
55d7dd864c
Merge pull request #7338 from nextcloud/backport/7285/stable-3.14
[stable-3.14] test syncing of read-only .lnk windows shorcuts
2024-10-17 11:21:46 +02:00
Matthieu Gallien
8728b4f61c test syncing of read-only .lnk windows shorcuts
related to https://github.com/nextcloud/desktop/pull/7282

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 11:21:38 +02:00
Matthieu Gallien
6f9f1ce33d
Merge pull request #7335 from nextcloud/backport/7333/stable-3.14
[stable-3.14] Bugfix/signature
2024-10-17 11:21:13 +02:00
Camila Ayres
87ffb0c80d Fail with error before calling folder metada setup when received empty signature.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-17 11:21:04 +02:00
Camila Ayres
f424f1151b Report client status error when signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-17 11:21:04 +02:00
Camila Ayres
48dcda9008 Add test testFolderMetadataWithEmptySignatureDecryptFails.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-17 11:21:04 +02:00
Camila Ayres
4828dde8e9 Check if signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-17 11:21:04 +02:00
Matthieu Gallien
e65e581933
Merge pull request #7332 from nextcloud/backport/7322/stable-3.14
[stable-3.14] Fix crash caused due to null accountstate in FileProviderSocketController
2024-10-17 11:20:40 +02:00
Claudio Cambra
e26266868f Fix crash caused by null accountstate due to bad domain identifier parsed from FPExt
Turns out since we are forced to replace colons with hyphens we need to
replace them back to colons when we receive the domain identifier from
the file provider extension. If we do not then we get a null
accountState pointer in the socket controller and this causes a crash

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-17 09:53:57 +02:00
Matthieu Gallien
cb8182a4a3
Merge pull request #7329 from nextcloud/backport/7319/stable-3.14
[stable-3.14] improve wordings of confirmation dialog when many files are deleted
2024-10-17 09:53:36 +02:00
Matthieu Gallien
1740f4d2b2 improve wordings of confirmation dialog when many files are deleted
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-16 07:45:26 +00:00
Matthieu Gallien
31742d8544
Merge pull request #7308 from nextcloud/backport/7290/stable-3.14
[stable-3.14] Cleaning logs
2024-10-11 17:41:49 +02:00
Matthieu Gallien
19e2754203 improve log when too many deleted files are detected
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-11 15:40:33 +00:00
Matthieu Gallien
dbedbaf93b
Merge pull request #7306 from nextcloud/backport/7251/stable-3.14
[stable-3.14] message should say many not all: would be triggered by 200 files
2024-10-11 17:39:47 +02:00
Matthieu Gallien
e3c7c764e8 message should say many not all: would be triggered by 200 files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-11 15:38:30 +00:00
Matthieu Gallien
816a762c1d
Merge pull request #7304 from nextcloud/backport/7116/stable-3.14
[stable-3.14] count the files deletion and warn if threshold is exceeded
2024-10-11 17:37:08 +02:00
Matthieu Gallien
17d5ef6985 count the files deletion and warn if threshold is exceeded
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-11 17:35:42 +02:00
Matthieu Gallien
1bdcb33863
Merge pull request #7301 from nextcloud/backport/7286/stable-3.14
[stable-3.14] Properly check for webdav or dav path in provided host url for cmd.cpp
2024-10-11 17:19:20 +02:00
Claudio Cambra
5e14c7c9d5 Properly check for webdav or dav path in provided host url for cmd.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 21:29:18 +08:00
Claudio Cambra
02f9acb2ca Encourage use of https in error message for cmd.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 21:29:18 +08:00
Claudio Cambra
35a4e7f086 Remove unused <random> import in cmd.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 21:29:18 +08:00
Claudio Cambra
e05ab4116d
Merge pull request #7302 from nextcloud/backport/7240/stable-3.14
[stable-3.14] Fix authentication issues for macOS File Provider Extension
2024-10-11 21:29:03 +08:00
Claudio Cambra
5eceb725c8 Stop fetching user profile details now that is not necessary in file provider extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
49f7b06261 Handle userId correctly in File Provider Extension client interface
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
5b472a238c Properly provide both user-provided username AND backing user ID to File Provider Extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
94b84a5c46 Fetch user profile (and user ID) when setting up domain account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
47bb200fb7 Wait for task to complete synchronously after setting up domain account rather than wrapping everything in task
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
35073e61f8 Retry authentication if connection timed out
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
e7e958ed82 Try to authenticate new account details before setting them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Matthieu Gallien
5c34390478
Merge pull request #7295 from nextcloud/backport/7290/stable-3.14
[stable-3.14] Cleaning logs
2024-10-10 16:10:38 +02:00
Matthieu Gallien
f3e3a581f2 remove info level output from activity list model: not so usefull
they just are printed when everything is working fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 13:11:55 +00:00
Matthieu Gallien
72480f61d5 remove not so usefull log output
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 13:11:55 +00:00
Matthieu Gallien
629cbf47fb
Merge pull request #7292 from nextcloud/backport/7289/stable-3.14
[stable-3.14] remove extra argument from QString::arg: string has only 1 placeholder
2024-10-10 15:08:21 +02:00
Matthieu Gallien
b5d4c976fa remove extra argument from QString::arg: string has only 1 placeholder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 12:35:22 +00:00
Matthieu Gallien
86d7d2f44c
Merge pull request #7283 from nextcloud/backport/7282/stable-3.14
[stable-3.14] properly catch std::filesystem exceptions
2024-10-08 14:36:46 +02:00
Matthieu Gallien
afa176c069 properly catch std::filesystem exceptions
will prevent std::terminate from being called with uncatched exceptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-08 11:47:58 +00:00
Camila Ayres
fd18abc984
Merge pull request #7276 from nextcloud/backport/7163/stable-3.14
[stable-3.14] Add support for the new craft blueprint options relating to override server urls
2024-10-07 16:14:22 +02:00
Claudio Cambra
a8a6c85098 Add support for the new craft blueprint options relating to override server urls
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-07 16:13:58 +02:00
Matthieu Gallien
08b07405bc
Merge pull request #7275 from nextcloud/backport/7270/stable-3.14
[stable-3.14] Bugfix/use qml fusion on windows
2024-10-07 16:09:33 +02:00
Matthieu Gallien
7e729241c3 remove hard coded white color in elements of folder wizard
fix broken white backgrounds in folder wizard when using Windows dark
mode

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
0d3aee7aad switch folder wizar to modern style to avoid borken windows dark mode
the QWizard AeroStyle style is broken on windows dark mode, switch to
ModernStyle that is working fine

see upstream Qt bug: https://bugreports.qt.io/browse/QTBUG-123853

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
513a4bf46e qml Windows native style is broken on dark mode: switch to Fusion
we will temporarily be using Fusion generic desktop style

Close https://github.com/nextcloud/desktop/issues/7215

see upstream Qt bug
https://bugreports.qt.io/browse/QTBUG-113469?focusedId=724929&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-724929

they apparently do not plan to fix Windows qml style to support dark
mode on Windows 11

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
c49669f9d7
Merge pull request #7272 from nextcloud/backport/7263/stable-3.14
[stable-3.14] remove too verbose logs during discovery
2024-10-07 16:08:47 +02:00