mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-29 20:28:57 +03:00
Code Issues Projects Releases Packages Wiki Activity
19943 commits 481 branches 256 tags 516 MiB
Commit graph

9376 commits

Author SHA1 Message Date
Matthieu Gallien
b9761a23fe tidy code 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
fad55470d5 ensure e2ee can be disabled from client 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
ad34de1622 make sure e2ee init is either fully done or not at all 
make sure that we have only two cases:
1) keys are stored on the server and the client
2) keys are stored on the server and not yet on the client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
bef5d1a893 if keys are not on server, also delete local keys 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
c8e5ac7b5f fix upload of private key when initializing the end-to-end encryption 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
3a0e0f2097 can now generate the CSR again if the first try to upload failed 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
50234c5859 try to resend the public key if it is not on server but on local storage 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
d3b583d967 improvement to be able to retry the e2ee init steps 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
17484cd69f finish local save of keys and upload them to server 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
1b7c16e8ff solve memory mismanagement of object life time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
1cb632234c e2ee init rework 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
15f3e2acae backup private key early 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
da8fa7bfa7 prevent crash by resetting common pointer after deleting gobject menu 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 10:19:59 +02:00
Matthieu Gallien
033a37e7d1 remove wrong code 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Matthieu Gallien
0e002f35f4 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Matthieu Gallien
431ccfec5a ActivityListModel now keeps track of the account connection state 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Matthieu Gallien
8cf778ba94 declare state property in AccountState 
should make it more logic to find the property when needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Dimitri Papadopoulos
fa96e0d31a Fix typos found by codespell 
These change actual variable names.

Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
Dimitri Papadopoulos
9d830e94f9 Fix typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
alex-z
7e5031d75d Implemented a class ChecksumCalculator to allow stopping the checksum calculation thread on parent destruction. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-20 11:44:07 +02:00
alex-z
e6f003b00b Remove stale caseclash conflicts when one of conflicting files has been removed from server 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-15 10:13:22 +02:00
alex-z
bd37b711fe Fix clang compile error. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-14 15:01:43 +02:00
allexzander
63470c0e21 Correctly handle errors for unsupported filenames on the server. Allow user to rename those via dialog. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2023-06-14 12:48:56 +02:00
Matthieu Gallien
dddbe9193d
rotate logs based on the lines count instead of teh file size 
will omit querying teh file size repeatedly (and not cost free)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:57:00 +02:00
Matthieu Gallien
bfaa59e6ca
less info logs during discovery 
those log lines mostly duplicate info we already have at info level

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:57:00 +02:00
Matthieu Gallien
8c842ca0fa
enable "Processing" log lines again but with some removed data 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:57:00 +02:00
Matthieu Gallien
257bebb790
avoid info level for new entries in ActivityListModel 
should also decrease the number of log lines during heavy sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Matthieu Gallien
516649334f
by default hide most discovery log traces 
will make the logs much less usefull by default

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Matthieu Gallien
40b1987287
downgrade some log lines to be less verbose 
those log lines can easily be skipped from info level as they are needed
in very rare occasion

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Matthieu Gallien
8bd69ad941
fully hide some logs from release builds 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Matthieu Gallien
360fd93397 rotate the logs less often (around every 3 MB of compressed logs) 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-09 16:24:20 +02:00
Claudio Cambra
d986b47a21 Fix reply button visibility after reply field opened and reply text sent 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-09 08:34:45 +02:00
Claudio Cambra
beb651fb05 Fix colouring of NCRadioButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-08 18:05:42 +02:00
Matthieu Gallien
91ea14d49e addd a cmake option to enable single account desktop client 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-08 11:11:47 +02:00
alex-z
cc65f89d4c Fix UnifiedSearch text field placeholder text color for light and dark theme. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-08 09:00:48 +02:00
Matthieu Gallien
fe748fafa5 use a better user message for network errors 
tell users this is a network error and the client wll retry
automatically

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
Matthieu Gallien
5372276779 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
Matthieu Gallien
6b18fd9d69
declare ErrorCategory enum class and declare its metatype 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 12:48:20 +02:00
Matthieu Gallien
34dde88f0e
display subject when we have sync issues like network errors 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 12:48:05 +02:00
alex-z
fd69e6daca Bugfix. Conflict resolution button not clickable. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-07 10:56:32 +02:00
Matthieu Gallien
5a86446f91
do not log twice in debug mode 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-06 16:32:19 +02:00
Matthieu Gallien
a34bac35b7
rotate log files every 3 MBs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-06 16:32:18 +02:00
Matthieu Gallien
b28e635368
by default disable debug log level 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-06 16:32:15 +02:00
Claudio Cambra
fe427364c2 Fix progress bar palette 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-06 22:13:26 +08:00
Matthieu Gallien
47a7a267ea
fix build on windows by adding missing archive name properties on libs 
the archive output name is used on windows but was never set for 2
libraries

with this they will have a proper name matching other components of the
shared library

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-31 15:45:09 +02:00
Claudio Cambra
be84b2cf09
Use Style constants for UnifiedSearchInputContainer measurements 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 15:47:45 +08:00
Claudio Cambra
ca64951a6c
Fix switching from dark/light mode for checkboxes in file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 15:36:07 +08:00
Claudio Cambra
27f5d826bb
Fix faulty dark/light mode switching in UnifiedSearchInputContainer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 14:02:33 +08:00
Claudio Cambra
43a21717fa Fix macOS build when file provider module build is disabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 11:11:08 +02:00
Claudio Cambra
4c096a885c Declare hoverEnabled: true explicitly in CustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97cf9390fa Fix highlight in activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
1dc83bfbd3 Fix caret colour in basic combo box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
24e6435289 Remove unnecessary background components 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
d195922d17 Always use palette colours for colouring UI elements 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
46f54891e4 Define all QML windows as ApplicationWindows, define palettes here 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
10560f8b03 Fix contentwidth of dialogbuttonbox in ShareDetailsPage 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
1aa4cd0dc5 Fix dark mode in ResolveConflictsDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
de7697d6c7 Fix outline for progress bar in fusion 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c2c3484306 Fix checkbox palettes in share details 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
313592645d Unify small icon sizes in file details components 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
fef9f3b643 Fix dark mode switching issues with main tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
cde52f03fa Fix large number of warnings related to unavailable property 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c18fba6366 Fix image sizing and positioning in NCButtonContents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
6237898b73 Add darker hover to make hovering on an item within an item with lightHover visible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
3145f9cf83 Respect icon.height and width in custom button contents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
93efd2fb78 Respect icon.height and width in custom button contents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
ea43ebfe91 Limit the max height of images inside CustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97904d3b20 Simplify and fix activity content layout by going back to using RowLayout instead of Item 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c37e077dac Use standard size instead of unncessary additional value 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
659ccc3f07 Fix text lines, don't leave only one line 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
95a8ecf013 Move filedetails button to activity top row 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
03631bb659 Fix more button icon when in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
a106454b34 Use custombutton with filedetails button to make it not look horrible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
a0909cea60 Hide second subject line in activity when nothing is visible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
39b5e7653c Fix alignment of main subject line with time line in activity 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97c33d396c Use custombutton for dismiss button, give hover feedback 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Matthieu Gallien
ad503d9fe3 ensure that the file to test monitoring is hidden 
we create a file inside the sync folder to test file system monitoring

ensure this file is hidden (i.e. has the proper hidden property)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-25 08:25:56 +02:00
Matthieu Gallien
0ba16229c5 align activity text with "Sync now" text 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-23 11:15:56 +02:00
Claudio Cambra
bc64e990ce Fix colour of downward caret in tray folders button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-22 09:58:07 +02:00
Claudio Cambra
623190c620 Fix colour of icon for tray folders button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-22 09:58:07 +02:00
Matthieu Gallien
1accd60b86
just use padding to ensure a good width for "Sync now" button 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:11 +02:00
Matthieu Gallien
ce9540a252
do not color file details 3 dots button 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:11 +02:00
Matthieu Gallien
607d0da672
use a much more compact layout for activities 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
9dd5cc35f8
use a more compact format to display date of activities 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
ddeb629157
always enable entries in activity list to have consistent look and feel 
disable items will have weird look and behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
39c70c1f22
make highlight indicator in activity list have rounded corners 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
f8feb6403f
to dismiss an activity use a round button with hover enabled 
change size of dismiss button for items in activity list

fix #5275

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
4c1ab7092b
use Fusion qml style 
allows use of more standard qml styling and components

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
7d03007fa8
use standard and existing property to set icon url in buttons 
replace custom property imageSource by the use of the standard
icon.source

will make our code closer to Qt Quick Controls v2 and less our own
controls toolkit

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
e69a544b71
improve again qml bindings to notifications data 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
98ec08097b
make the API easier to read 
make a protected method overriding a public method be a public method
also

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
0d2742d88a
provide the full OCC::Activity instance to ActivityItemContent 
should allow accessing the required properties of teh activity to fine
tune the display of it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
f51af1734d
expose some properties of OCC::Activity gadget class 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
ce69856bfa
improve qml binding for more element of OCC::Activity 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
10f9ef5cd5
to store subjectRichParameters use a QVariantMap that is qml friendly 
will make it much easier to access fom qml in order to use the data
inside to improve activity list items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
bc9b7a05f4
repay some desbt in ActivityListModel::data 
only valid index are sent to QAbstractItemModel::data

we may want to do more checks in debug mode, let's do it

if we are going to show data, let's use a const variable to contain the
current activity item

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
9a90f15ceb
remove scary warning that is a false alarm 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
ad868daebe
remove custom property to set a source model in a sort proxy model 
custom property for source model is not needed

remove code that is not needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
32ee1a962f
remove custom property and use standard sourceModel for our proxy model 
a QSortFilterProxyModel will trigger a new sort whenever needed, so
custom code is not needed

we might have someone that would use the standard property and loose teh
side effects of setting the source model via thet non standard property

this makes it more complicated to read as one might wonder why a custom
property was needed

deletes a bunch of code not really needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
9bbabd3baa
prevent a 0 size to assert when creating icon from svg 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
d6d1a6dcd2
fix a few debug logs to use proper categorized logging 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
dc66a1254d
add missing copyright notices and upgrade qml module imports 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:07 +02:00
Matthieu Gallien
6c7f810095 improve code in activity list model 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8f60518d6f small qml cleanup to make code faster to read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
14bce6fdc2 improve reliability of memeory management when creating conflicts dialog 
use more automatyed memory management to reduce possible errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
5349395063 model improvements 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8d81257db0 improve translations for strings with placeholder to display numbers 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
b285b89605 define minimum sizes of conflict dialogs in Style component 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
635b1ec729 define constants specific for font sizes in conflict dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
31e4dede62 refactor common parts of conflict delegate into a separate component 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
230e2de23a solve multiple conflicts from choose resolution 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
739c56c04a allow selecting conflict resolutions for many conflicts 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8d52d4e4cc implement more feedback 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
fa135a4228 ensure the URL to mimetype icons are correct 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
382a58c6bd allow the conflicts dialog to close 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
2e501f0c75 add some margins at bottom of items in conflicts list view 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
6efa9f81be prevent close of conflicts dialog on focus lost 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
779cc3a75b display icons for files when solving many conflicts 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
789ca7230a plug models into the dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
f799d8c697 tune the pipes to really get a dialog to show for many conflicts 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
c118958d3d do not show many conflicts dialog for a single conflict 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
72b78c9011 replace "Sync now" button by "Solve all conflicts" for many conflicts 
offer an easy way to open a dialog to solve all conflicts at once
replacing the "Sync now" button

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
280094b220 model: first step 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8f61d539da replace "OK" button by "Resolve conflicts" to help users 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
4bd93e39d6 more qml feedback 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
396accd208 feedback from design review 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
1491c134c3 basic implementation of a dialog to resolve conflicts as a batch 
will allow solving all conflicts at once

FIX #2786

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
7b4245a3c3 fix #include header style 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Claudio Cambra
3dd838d28d Rename forcelegacyimport option to clearer forcelegacyconfigimport 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
b864bef2e8 Add application argument to force import of legacy accounts 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
c8f8c9cd2c Don't ask user whether to import legacy account configs if forcing legacy import 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
e43f627c9f Add forceLegacyImport property to accountmanager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
efce1b6abf Declare void setters and methods in accountmanager as slots 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
c3fda69e33 Place signals and slots for accountmanager in line with how this is done in other classes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
6eb2fd1cc0 Notify result of attempted account import with messagebox 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
fba808103c Ask before attempting to import legacy accounts 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:23:43 +08:00
Claudio Cambra
a9375c4d64 Animate copy share link button in share delegate 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
Claudio Cambra
0419e29395 Also customise appearance of copy button in sharedelegate when clicked 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
Claudio Cambra
191d8350c1 Replace use of magic numbers for animation durations in copy share link button with constants defined in Style.qml 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
Claudio Cambra
4e12bbf3e4 Smoothly animate change of state for copy share link button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
Claudio Cambra
7db143469a Reset state of copy share link button after 3 seconds 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
Claudio Cambra
c345b22bf2 Upon copying share link, trigger a change in the button to make copy action completed obvious 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 21:16:11 +08:00
allexzander
79c0fdc9f6
Merge pull request #5686 from nextcloud/bugfix/edit-locally-allow-opening-item-in-root 
Allow opening a file or folder in the local sync root.
 2023-05-16 13:33:33 +02:00
alex-z
81ecba8daa Allow opening a file or folder in the local sync root. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-16 12:33:34 +02:00
Claudio Cambra
b440e3011d Display tooltip showing names of overflowing tags in FileDetailsPage's overflow tag 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
30830b44cc Add overflow tag string property to filetagmodel which stringifies omitted tags 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
1bab57b176 Notify change in tags when maxTags set in filetagmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
b79a038d92 Add support for system tags in filetagmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
045541d323 Implement support for system tags in propfindjob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix
 2023-05-16 18:23:33 +08:00
Claudio Cambra
bfb720fc35 Extract propfind tag xml node processing into separate method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
29c17132e9 Properly parse tags in propfind request 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
b5cc4b41ce Extract propfind result data processing into separate method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
6e9fed0198 Clean up includes in networkjobs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix for header fix
 2023-05-16 18:23:33 +08:00
Claudio Cambra
a386d8f008 Do not use magic string for propfind prop element tag name 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
9324fe0d78 Use constexpr in networkjobs notModifiedStatusCode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
43bcecdeb0 Simplify Propfind XML parsing using QDomDocument instead of complex QXmlStreamReader-based parsing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
06b3dc9cc8 Modernise PropfindJob with new for and const auto 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
e2bd9e69e1 Fix layout of tags with differing sizes and oversized tags 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
65e7f6da9c Simplify file tag model updating in filedetails, only require folder pointer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
cb8cab6f41 Display filetags in file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
a3fc467cf0 Simplify FileTag component 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
791eb87afc Instantiate FileTagModel in FileDetails 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
c6d29e7d77 Add ability to limit maximum amount of tags displayed 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
213e3743e1 Expose account and serverRelativePath of FileTagModel as QPROPERTYs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
49b5fb32f9 Implement FileTagModel QAbstractListModel methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
9cc241bf96 Add capability for FileTagModel to fetch tags 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
84c8392491 Get account and relativeserverpath in constructor for FileTagModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
f763bd00fb Add a FileTagModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Claudio Cambra
0bdab1ee58 Add FileTag QML component 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-16 18:23:33 +08:00
Camila
d6db8fcbd6 Add a dismiss link for notifications without it. 
- Fix for #5606 and #5585.
- That is how it is done in the server and other clients.
- Update tests.

Signed-off-by: Camila <hello@camila.codes>
 2023-05-16 11:17:37 +02:00
Claudio Cambra
49bb5a005c Modernise BandwidthManager::absoluteLimitTimerExpired 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
23890b7d4c Use modern for loop in BandwidthManager::relativeDownloadDelayTimerExpired 
getFileJobSigned-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
dbdce45797 Bring improvements of new cpp to BandwidthManager::relativeDownloadMeasuringTimerExpired 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
350fa72478 Modernise and improve readability of BandwidthManager::relativeUploadDelayTimerExpired 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
c8e78673c9 Modernise BandwidthManager::relativeUploadMeasuringTimerExpired with const auto, readability, etc 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
a547f55f2f Fix deadlock when using putmultifilejob with rate limits enabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
f28a1a368e Modernise BandwidthManager::switchingTimerExpired 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
7d763fa6bc Log if PutMultiFileJob oneDevice has error 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
651615ce94 Do not close putmultifilejob devices if not open, log when they are not open 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
35b05fca85 Increase logging around emission of putmultifilejobs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
811a4036cb Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr 2023-05-15 20:46:21 +08:00
Claudio Cambra
afddc1bca0 Improve general readability of bulkpropagatorjob.cpp 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
98b8fde2f0 Remove unnecessary double declaration of namespace in bulkpropagatorjob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
4375a24f0f Clean up and const autofy BulkPropagatorJob::scheduleSelfOrChild 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
37cf71a9a7 Don't bother creating a unique ptr for PutMultiFileJob as we never use the guarded ptr 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
311dcf29c6 Clean up putmultifilejob class definition 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-15 20:46:21 +08:00
Claudio Cambra
23855a128b
Do not exclude file provider config entries from compile on non-macOS platforms 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:40 +08:00
Claudio Cambra
246347f88a
Do not initialise file provider module if not enabled in config 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:39 +08:00
Claudio Cambra
ab070fc7c2
Add config entry for file provider module enabling 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:39 +08:00
Claudio Cambra
3d6acb5371
Use consistent if defined in application.cpp 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:38 +08:00
Claudio Cambra
2c3fa71405
Rename FileProviderDomainManager::Private to FileProviderDomainManager::MacImplementation 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:38 +08:00
Claudio Cambra
f37e7cc3b6
Remove readdFileProviderDomain hack in FileProviderDomainManager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 16:02:38 +08:00
Claudio Cambra
9fff10fd5d
Do not use QSharedPointer to store FileProviderSocketControllers, use QPointer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:29:54 +08:00
Claudio Cambra
4327b152fb
Move accountStateFromFileProviderDomainIdentifier to FileProviderDomainManager where we have methods to guarantee conversion 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:47 +08:00
Claudio Cambra
95c6e7a3f4
Add informative messages after Q_ASSERTs for sockets in FileProviderSocketController for release mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:47 +08:00
Claudio Cambra
3254595fa4
Do not emit socketDestroyed twice in FileProviderSocketController 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:47 +08:00
Claudio Cambra
6e84aa67a4
Clean up header for FileProviderSocketController 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:47 +08:00
Claudio Cambra
578e8ea2d9
Clean up FileProviderSocketServer header, remove unnecessary ifdefs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:46 +08:00
Claudio Cambra
22fc43e7b0
Improve initialisation of C++ FileProvider class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:46 +08:00
Claudio Cambra
23e623ef0a
Make it possible to disable building file provider module 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-12 13:28:45 +08:00