mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-20 12:52:06 +03:00
Code Issues Projects Releases Packages Wiki Activity
20660 commits 487 branches 258 tags 463 MiB
Commit graph

205 commits

Author SHA1 Message Date
Claudio Cambra
e7a99a8e9a Use braced initialiser where possible for folderstatusmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-05 11:48:05 +08:00
Claudio Cambra
c070ed2b6d Const autofy where possible in folderstatusmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-05 11:48:05 +08:00
Claudio Cambra
d66827c91f Avoid excessive single letter variables in FolderStatusModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-05 11:48:05 +08:00
Claudio Cambra
c8c7bdbf40 Fix undecided lists in fodlerstatusmodel comment 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-05 11:48:05 +08:00
Claudio Cambra
4b1f502be7 Modernise and replace foreach loops with for in loops in folderstatusmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-05 11:48:05 +08:00
alex-z
e9a0dbd16c Allow event processing between each XML parser run, to improve GUI performance. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-01-29 18:32:01 +01:00
Dimitri Papadopoulos
8a73a9a6f5 Fix new typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-09-17 10:41:38 +02:00
Claudio Cambra
21656cce17
Replace all manual isntancesof adding trailing slash with use of utility method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-08-04 17:40:42 +08:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
alex-z
d8980a8567 Fix bad string for translation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-23 13:07:41 +01:00
Claudio Cambra
6146f7d5cf Add 'emit' keyword to signal emissions that were missing them 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:07:55 +01:00
alex-z
867249f339 Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-15 15:09:25 +01:00
allexzander
65cd8d06bc Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
alex-z
1b98733b1a Start sync immediately after modifying the selective sync settings. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 13:38:09 +03:00
alex-z
7ba681544c Fix wrong estimated time when doing sync. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 09:31:05 +03:00
Felix Weilbach
5622c33f40 Fix various deprecated warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-30 06:21:05 +00:00
Valdnet
a3b2dc669c
One more apostrophe change 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:34:22 +02:00
allexzander
81a090b362 Allow creation of new folders from the Settings Dialog. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-02-04 10:05:18 +02:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders 
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.

So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs 
Fixes: #8131
 2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead 
Fixes: #8139
 2020-12-15 10:59:20 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns 2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad 
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787

e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
 2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible 2020-12-15 10:59:17 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported 
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
 2020-12-15 10:59:08 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts 
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a

I removed a few lines of code there which are already part of fetchMore()

Fixes: #7336
 2020-12-15 10:59:07 +01:00
Hannah von Reth
c8dd333e31
[Sanity] Remove old ifdef 2020-12-15 10:59:06 +01:00
Christian Kamm
a587cd3a13
AccountSettings: Fetch subitems after wiping them 
That helps avoid empty lists after account creation #7336
 2020-12-15 10:58:54 +01:00
Christian Kamm
238ac53666
Ensure local discovery on selective sync changes 
As far as I'm aware local discovery can be skipped on folders that are
selective-sync blacklisted, so a local discovery is required when an
entry is removed from the blacklist.

Also rename
avoidReadFromDbOnNextSync() -> schedulePathForRemoteDiscovery()
since the old name might also imply it's not read from db in the local
discovery - which is not the case. Use Folder::
schedulePathForLocalDiscovery() for that.
 2020-12-15 10:58:41 +01:00
Christian Kamm
4c04351360
Fix warnings about signedness 
Sizes are always qint64, not unsigned.
TransferIds are always uint.
 2020-12-15 10:58:41 +01:00
Christian Kamm
0eb4065197
Folder: Add remoteFolderTrailingSlash() 
There were cases where the "/" exception wasn't handled correctly
and there'd be extra slashes in generated paths.
 2020-12-15 10:58:39 +01:00
Christian Kamm
5728256763
Folder: Add selective sync / ui related flags 
supportsSelectiveSync(): clearer than !supportsVirtualFiles() and allows
  extra logic

isVfsOnOffSwitchPending(): Somewhat awkward way of dealing with the
  phase between a user requesting vfs state to be switched and it
  actually happening
 2020-12-15 10:58:34 +01:00
Christian Kamm
3b923e2afe
vfs: Change per-folder message on vfs support 
I'm unsure this note is all that useful. Remove entirely?
 2020-12-15 10:58:33 +01:00
Christian Kamm
cbb32edee2
vfs: Disable selective sync if vfs support is available 2020-12-15 10:58:32 +01:00
Christian Kamm
305d439c41
vfs: Separate vfs availability from new-files-virtual 
This helps support 2.5 settings where there are virtual files in the
tree but new files aren't created virtual.

It's also a prelude for #6815

There's currently no way of
- upgrading vfs plugins (a silent suffix->winvfs upgrade is attempted
  once only, when moving to master)
- disabling vfs capabilities outright
 2020-12-15 10:58:27 +01:00
Christian Kamm
c3b1a872aa
FolderMan: Remove assumption of unique running sync 2020-12-15 10:58:21 +01:00
Olivier Goffart
75a57778d9
Virtual files: Don't show selective sync 
Issue #6724
 2020-12-15 10:58:06 +01:00
Olivier Goffart
358aadfb98
Account Settings: Add a text for folder using vierual files 
Issue #6723
 2020-12-15 10:58:04 +01:00
Olivier Goffart
4837bc8d60
FolderStatusModel: Do not abort applying selective sync if one folder has an error 
Issue #6675
 2020-12-15 10:58:03 +01:00
Olivier Goffart
0d21936e95
FolderStatusModel: Fix crash when there is an error while expanding folders 
In FolderStatusModel::slotLscolFinishedWithError, the call to parentInfo->resetSubs
deleted the 'job' and the reply 'r' which we accessed later to get the error code.

Fix this problem twice by
 1) Get the error code before caling resetSubs
 2) in FolderStatusModel::SubFolderInfo::resetSubs, call deleteLater instead of delete

Regression introduced in commit d69936e0

Issue #6562
 2020-12-15 10:57:55 +01:00
Camila San
03b1c0b84a
Fix crash when clicking on folder with status 403 in the main dialog. 
LsColJob was still being used after delete was called.

Signed-off-by: Camila San <hello@camila.codes>
 2020-10-20 16:19:27 +02:00
Nicolas Fella
6f17bbe6d5 Don't use nullptr for QFlags 
This fixes some deprecation warnings

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-10-12 11:52:53 +00:00
Kevin Ottens
c8ea848596 Enable the bugprone-branch-clone clang-tidy check 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-09-01 06:37:03 +00:00
Kevin Ottens
866ffc2a6b Enable the modernize-loop-convert check on clang-tidy 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-13 12:55:14 +00:00
Kevin Ottens
a5b4922a0e Remove unused method 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-13 12:55:14 +00:00
Kevin Ottens
cb9ba9702b Properly display encryption status for non root folder connection 
Since the e2e oracle works only in term of absolute remote paths and
that our model x._path was relative, we need to properly convert.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-07-01 16:58:29 +00:00