Claudio Cambra
|
f529dd6e6d
|
Merge pull request #5872 from nextcloud/work/do-not-mod-new-files-unnecessarily
Do not modify discovered files on disk if not necessary
|
2023-08-07 17:28:37 +08:00 |
|
Claudio Cambra
|
812e696d53
|
Set modificationHappened to also depend on file size change
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
1cd537f928
|
Add test for unmodified local files not getting mtimes changed upon upload to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
67e6546e1a
|
Add find method to DiskFileModifier class in SyncEngineTestUtils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
4681d27de5
|
Ensure file modification time is set if item modtime differs from journal modtime
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
961033efc1
|
Only attempt conversion to placeholder on new file if VFS enabled in SyncEngine::slotItemDiscovered
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
fe829e2693
|
Only change modification time if any modifications were actually made on downsynced file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
9811d35a96
|
Return bool from FileSystem::setFileReadOnlyWeak depending on whether permission change was actually made or not
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Claudio Cambra
|
32145342c8
|
Unify else and if in SyncEngine::slotItemDiscovered for filesystem setmodtime check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-07 16:25:19 +08:00 |
|
Nextcloud bot
|
0a86967f14
|
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2023-08-07 02:41:59 +00:00 |
|
Nextcloud bot
|
2d4568648f
|
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2023-08-06 02:37:40 +00:00 |
|
Nextcloud bot
|
e05086f989
|
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2023-08-05 02:41:35 +00:00 |
|
Claudio Cambra
|
a89fe84459
|
Merge pull request #5868 from nextcloud/work/folder-threshold-improve
Add option to notify when synced folder overcomes set size limit
|
2023-08-04 18:29:56 +08:00 |
|
Claudio Cambra
|
a5d7c75e6f
|
Add additional logging for folder size check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:23 +08:00 |
|
Claudio Cambra
|
6d56621520
|
Deduplicate whitelistFolderPath and blacklistFolderPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:23 +08:00 |
|
Claudio Cambra
|
a7fcb846ab
|
Extract folder now big activity generation into separate method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
cbad4347bd
|
Extract notifying of existing folder now big to separate static method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
e1f342c320
|
Declare whitelist and blacklist activity verbs as static constexprs in activitydata, refer to this in usage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
5db79261f6
|
Fix breakages in testactivitylistmodel caused by recent activitylistmodel changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
e987fe88c5
|
Fix generation of context menu activity links
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
9b5391bdc1
|
Ensure generated activity buttons are within count set by maxActionButtons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
af45017e94
|
Do not clear the whitelist on sync success
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
449bac837b
|
Do not always re-notify user on existing folder now big if this folder already black or white listed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
2324a60c76
|
Stop current sync when existing folder becomes big and we have enabled disabling sync of folders that become big
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:22 +08:00 |
|
Claudio Cambra
|
bd7ccf5738
|
Add UI element in general settings to stop syncing existing folders that have now overcome limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:21 +08:00 |
|
Claudio Cambra
|
1342f81cab
|
Add config option to stop synchronising existing folders when they grow beyond size
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:44:15 +08:00 |
|
Claudio Cambra
|
0b13be663b
|
Add test for correct reporting of existing folder overcoming size limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:42:35 +08:00 |
|
Claudio Cambra
|
4cdf525df2
|
Report size for directories in syncenginetestutils propfind response
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:43 +08:00 |
|
Claudio Cambra
|
21656cce17
|
Replace all manual isntancesof adding trailing slash with use of utility method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:42 +08:00 |
|
Claudio Cambra
|
3b208bf838
|
Move trailingSlashPath convenience function into Utility class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:42 +08:00 |
|
Claudio Cambra
|
ac8e9c4274
|
Fix trailing slash procedure in DiscoveryPhase::checkSelectiveSyncNewFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:42 +08:00 |
|
Claudio Cambra
|
9fa5ae3604
|
Use simpler sort methods for white and black lists in discoveryphase
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:42 +08:00 |
|
Claudio Cambra
|
82f6fd5c27
|
Remove use of old foreach in SyncJournalDb::setSelectiveSyncList
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:42 +08:00 |
|
Claudio Cambra
|
1b73011f59
|
Constify SyncJournalDb::findPathInSelectiveSyncList
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
74c4ec88a2
|
Const autofy variables in ProcessDirectoryJob::processFile
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
a93279bcbf
|
Default to adding existing now big folders to whitelist when undecided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
6682b3ade4
|
Ensure folder whitelist and blacklist helper methods remove path from other lists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
f9bde98aad
|
Prevent possible accountsettings crash by sorting blacklist before checking
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
e2535d6ce8
|
Prevent double notification of folder now big in activities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
5f250a5dad
|
Ensure newly whitelisted or blacklisted paths are removed from undecided list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:41 +08:00 |
|
Claudio Cambra
|
7d1fa16a3f
|
Add activity for existing folder going over set limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:40 +08:00 |
|
Claudio Cambra
|
c975d40fb8
|
Do not create dismiss links for notifications as these are not used anyway
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:40 +08:00 |
|
Claudio Cambra
|
12931069c0
|
Create more than one converted activity link, therby respecting maxactionbuttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:40 +08:00 |
|
Claudio Cambra
|
fe59d4ec79
|
Ensure whitelist/blacklist procedure removes activity
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:40 +08:00 |
|
Claudio Cambra
|
e985367b5e
|
Add method to add notification activity in activity list in User
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:40 +08:00 |
|
Claudio Cambra
|
10989fa810
|
Add method to get user pointer in UserModel by AccountState pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:39 +08:00 |
|
Claudio Cambra
|
29cc9c06f9
|
Handle WHITELIST_FOLDER and BLACKLIST_FOLDER verbs in activitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:39 +08:00 |
|
Claudio Cambra
|
7e17e9226b
|
Add convenience methods to folderman so that classes can add and remove paths from folders without needing to know which folder the path belongs to
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:39 +08:00 |
|
Claudio Cambra
|
2bcefd6105
|
Add methods to Folder so that other classes can easily add folder paths to white/blacklists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:39 +08:00 |
|
Claudio Cambra
|
993ee6cb5b
|
Remove redundant "optional" gui log functions which relly just call gui log under the hood
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2023-08-04 17:40:39 +08:00 |
|