mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-21 21:24:40 +03:00
Code Issues Projects Releases Packages Wiki Activity
17295 commits 486 branches 258 tags 464 MiB
Commit graph

8238 commits

Author SHA1 Message Date
Felix Weilbach
9e792369b2 Refactor key-value store query code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Felix Weilbach
c76a77e431 Correct virtual files placeholder files if needed 
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Matthieu Gallien
c59f88ca82 avoid adding icon data in a cache we never use 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-16 16:11:44 +01:00
Carl Schwan
d84673376d More fixes to the menu implementation 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Carl Schwan
69def04ec2 Fix focus indicator 
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Felix Weilbach
07a8e8c91d Check if the server has user status app enabled 
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-15 16:20:58 +00:00
Alexander Batischev
d8560dcb19
CMake: fail if Qt5::GuiPrivate is not found 
`nextcloud` and `nextcloudCore` depend on three Qt5 components which
aren't mentioned in `find_library`: `Xml`, `Network`, and `GuiPrivate`.
The first two are omitted by mistake, apparently, so this commit just
adds them.

`GuiPrivate` is a special case: it doesn't have its own CMake config, so
adding it to "required components" in `find_package` will always fail
the build. Thus, we implement our own check instead.

Signed-off-by: Alexander Batischev <eual.jp@gmail.com>
 2021-11-15 13:57:18 +03:00
Felix Weilbach
3e368ee4df IconJob: Send request through the accounts NAS 
This helps tracking requests on the server

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:49 +01:00
Felix Weilbach
db337c4457 Add profile page 
Fix: #3889

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:47 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
rakekniven
416d98716f Make argument singular to fix i18n issue 
Reported at Transifex.
See https://www.transifex.com/nextcloud/nextcloud/translate/#hu_HU/client/309577611

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-11-05 10:00:17 +01:00
alex-z
2f3c58daac Fix review comments. Use QImage for QML and QPixmap for rest of code. Do not cache images for QML. Fix tests. Use signal in QML. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0b8ab5c079 Use SvgRenderer for Unified Search input icons. Refactor IconUtils. Extend unit tests. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0d8375e798 Clear Unified Search Input Field in a proper way 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
Felix Weilbach
d661e91a58 Don't do a connection checks when using push notifications 
When using push notifications, it is not necessary to do regular
connection checks because the push notifications will take care of it.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-04 18:07:22 +00:00
Felix Weilbach
650578ee64 Don't convert exclude file to placeholder file 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-04 18:18:50 +01:00
Matthieu Gallien
43ec429fe4 improve logs when place holder info cannot be read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Matthieu Gallien
9658aea963 on switch to VFS real plugin, convert existing files to placeholders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
alex-z
d88e086b94 ShareLinkWidget. Fix incorrect calendar mindate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 13:23:00 +02:00
alex-z
6c3c45dadd Implement expiration date for federated shares 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 10:54:18 +00:00
alex-z
c52718c104 Replace deprecated QRegExp with QRegularExpression. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-02 08:54:06 +00:00
Matthieu Gallien
a62905f17a properly extract the file id when querying server 
use the proper local file id to get the e2ee meta data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-02 08:15:54 +00:00
Matthieu Gallien
8226c30d84 by default we produce debug logs because we need them 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-28 13:48:55 +00:00
Camila
d68b8604ac Refactor toggleButtonAnimation function. 
Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
ab524d2392 Fix display of deleted note. 
Even after removing note from share link,
the previous text was being displayed.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
72c91362f2 Refactor ShareLinkWidget show/hide widgets functions. 
- Remove unecessary call to setupUiOptions after saving share password.
- Slot to create label: do not set it if nothing changed.
- Refactor showPasswordOptions, toggle/PasswordOptions/ExpireDateOptions/NoteOptions.
- Add const, auto and {} whenever possible.
- Refactor slotToggleButtonAnimation => toggleButtonAnimation.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
5788f35e82
Skip sync exclude file from list of exclude files if it doesn't exist. 
The file might not exist anymore because the user deleted it by hand or
the folder where it was located got unchecked in the selective sync
view. It is a fix for #2632.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 11:37:56 +02:00
alex-z
db4e54025a Forbid trusting the untrusted certificate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
alex-z
907ebc1959 Request OCSP validation data from the server during the SSL handshake. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
Matthieu Gallien
87c583dcb6 schedule files upload after all other jobs have been completed 
should allow smarter policy dedicated to optimizing files upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 14:26:28 +02:00
Matthieu Gallien
24428d9980 add missing Q_ENUM macro to improve logging 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
Matthieu Gallien
b0ef5e0635 no oneliner if: a bug waiting to happen 
it is much too easy to get a bug because one could miss the lask of {
and }

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
rakekniven
c39b97adb3
Update UnifiedSearchInputContainer.qml 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 10:44:07 +02:00
rakekniven
beffd63512
Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 07:35:47 +02:00
Matthieu Gallien
69d6f4acec our source code files have lower case names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-25 15:38:21 +02:00
alex-z
1b8448402a Fix JsonApiJob incorrect 'statuscode' parsing. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-25 14:45:05 +03:00
alex-z
c1dab7e4cb Unified Search via Tray window 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-25 14:45:05 +03:00
rakekniven
91884eef4a Changed wording to suggestion 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
rakekniven
fb3c740129 Changed wording of status message 
The files themselves have no problem. The sync process has problems. 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
alex-z
da03acc656 Fix folder creation issues. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-20 19:47:41 +00:00
Felix Weilbach
9f35fa6d3d Also update sync state summary based on connectivity 
Otherwise, with zero folders configured, the state will stay at
offline.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-20 12:31:55 +02:00
Felix Weilbach
1156d82594 Log file name and line number 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-19 17:10:44 +00:00
alex-z
bd731a9cda Windows. Remove CWD from DLL search paths. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-19 06:40:56 +00:00
Felix Weilbach
24f6bc5203 Only use basic authentication if needed 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-18 12:20:20 +02:00
Camila
c6e629c30d
Give the user a more descriptive error message when syncing is aborted. 
Signed-off-by: Camila <hello@camila.codes>
 2021-10-18 09:50:02 +02:00
Valdnet
22b0a2e196
i18n: Correct typo and remove apostrophe 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-10-15 08:44:02 +02:00
Felix Weilbach
d51bfec61d Remove unnecessary braces 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
f27ef02273 Set dialog max and min width and height before width and height 
Otherwise, resize events will not be processed correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
a663d235ef Add .sync-exclude.lst to exclude files 
Previously the .sync-exclude.lst file of the sync root directory was
not added to the exclude files, because the current logic did only
recognize .sync-exclude.lst files when their containing directory was
discovered during the discovery phase. Therefore the sync root
.sync-exclude.lst file was never discovered. See also
ExcludedFiles::traversalPatternMatch().

Fix: #3830, #2728

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 14:02:29 +00:00
Felix Weilbach
df11424596 Trim trailing spaces before uploading files 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 11:22:59 +00:00
Matthieu Gallien
46bc0452c7 provide logs of SSL errors including the certificate chain 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-13 15:20:52 +00:00
Felix Weilbach
0792dc36c2 Check if current user exists before getting it's account state 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-13 11:25:13 +02:00
Felix Weilbach
4c11f6763e Show sync progress in main dialog 
Fixes #3662

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-12 16:14:24 +00:00
Matthieu Gallien
d76778e3ee fix macOs build after targets name are not changed by branding 
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-11 07:41:29 +00:00
Felix Weilbach
2da6dab403 Add missing copyright headers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-08 13:19:10 +02:00
Kevin Ottens
5fe63a4d9a Display the right endpoint in the warning in case of error 
At that point in time _pollEndpoint isn't set yet. All the checks are
against pollEndpoint so display that one in the warning. Otherwise one
always end up with an empty URL in the logs which is not very useful for
debugging purposes.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
 2021-10-06 10:17:38 +00:00
Matthieu Gallien
833237b2e4 use alias target for internal libraries 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Matthieu Gallien
c751fd5672 ensure DLL are generated with branded names 
cmake distinct runtime and library

on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Felix Weilbach
0c9dce1154 Add file activity dialog 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-05 12:41:34 +00:00
alex-z
6cafcc1124 Remove Temporary solution for file restoration issue due to failing to set the data-fingerprint. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-30 08:39:47 +00:00
Guido Falsi
b0b70d1e77 Check for argp library before depending on it. 
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
 2021-09-29 15:46:07 +02:00
Guido Falsi
5f036641b9 Add -largp on non linux systems. 
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
 2021-09-29 15:46:07 +02:00
Felix Weilbach
d6e60cd8d4 Don't log encryption data in release mode 
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-27 19:50:38 +00:00
Camila
df38e5c08b Apply server default permissions for federated file sharing too. 
See nextcloud/server#24729 comments.

Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
Camila
8f847906c6 Check server capabilities for file sharing default permissions. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
alex-z
dc22307a42 Fix review comments + also check against trailing bakslash. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-27 08:13:29 +00:00
alex-z
e16402a102 Fix incorrect db name for nextcloud command line client. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-27 08:13:29 +00:00
rakekniven
68e02bc62d Fixed context 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1 Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631 Add dialog to resolve invalid filenames 
Fixes #3751

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5 set default format for QSurface to handle NVidia context loss events 
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver

close #3759

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-22 08:56:16 +00:00
alex-z
59199fc907 General Settings window. Allow opening the update URL via mouse. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-21 16:21:38 +02:00
Camila
db447c4676 Refactor OcsShareJob creation. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65 Add option to create label for share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da TextInput by default do not allow selecting text by mouse 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-21 08:07:19 +00:00
rakekniven
af49a7993a
Fixed placeholder numbering 
Fix for #3812 

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-20 11:39:51 +02:00
Felix Weilbach
0074d6c40a Disable Qt deprecation warnings 
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1 Fix warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f Display share note when there is one associated with a share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Camila
4581279d23 Fix indentation sharelinkwidget.h. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca Accept nc scheme in provider page 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 09:01:18 +00:00
Felix Weilbach
86da74908a Emit user status changed after clear user status 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 07:26:46 +00:00
Felix Weilbach
9aee46b3a4 Remove unnecessary logging statements 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 07:26:46 +00:00
Dmytro Korchynskyi
cffceaae1f Fixed warning: extra ';' in Q_ENUM_NS(PinState); 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
5f232c30be Fixed warnings from ntstatus.h on Windows 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
608fc5fb3a Fixed warnings by using static_cast 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Valdnet
a441d733dc l10n: Correct two typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454 Add dialog to set user status 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-09 11:18:22 +02:00
alex-z
4018f8d554 Prompt reboot when runing the auto update. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40 Fix various deprecated warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
93f590c6de Replace deprecated use of QProcess::execute() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
c9863dc225 Use QRecursiveMutex 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
b6e3c6d718 Replace deprecated use of QProcess::start() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
0af83dd1b6 Use QRandomGenerator instead of qrand 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
2fe3a7947e endl has been deprecated 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Matthieu Gallien
95e3ecfd3c prevent infinte recursion when closing a websocket in case of SSL errors 
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-07 07:09:43 +00:00
Felix Weilbach
6fd0adda52 Close wizard if done 
This is needed because of the changes in 02bb5db544

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-07 06:43:27 +00:00
Felix Weilbach
031b2e0683 Remove assert that caues crashes 
This assert does not add value. Utility::concatUrlPath() takes care of
appending paths correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-06 15:54:44 +00:00
allexzander
a3fc812539 Enable share to Talk and Email. Display correct icon. Added unit tests. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-09-06 13:27:39 +00:00
Hannah von Reth
02bb5db544 Remove wizard page that has been dead for 4 years 2021-09-03 16:08:37 +02:00