Commit graph

182 commits

Author SHA1 Message Date
Claudio Cambra
44f640a330 Signal enumeration of locked/unlocked file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
71454fc40e Display checkmark when file lock completed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
820fbbd3c3 Fix NSExtensionFileProviderActionActivationRules for locking menu items
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
ec8b65c248 Add warn image to locking view if there is an error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
6d87b210c3 Fix internal layouting of lock view by simply using a nsview rather than fumbling with a stack view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
51fba996cb Fix XIB initialisation in LockViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
e805993b9f Fix file lock server url in lockviewcontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
8533fdd4a0 Make sure not to check for kit before we should in shares table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
bcbfdc942e Once finished locking/unlocking, stop loading indicator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
4db6f8c2ed Pull out error handling from completionHandler for nckit lockunlock
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
cce98f1e84 Stop loading indicator when presenting error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
c5be665ce0 Add convenience function to stop/hide loading indicator in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
2b7734ac4d Perform lock/unlock procedure in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
72ec0d5f1f Process target item on init of lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
7cd50005c2 Add method to simply provide file details in locking view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
70d0c74b84 Add convenience method to present and log errors in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
58586e84ac Move item metadata fetch into util file in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
9ccbf3f2c5 Move service connection fetcher method into a utils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
1b2fc0e034 Add close action to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
515cc5c96c Design lock view in file provider ui
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
86a741bc40 Add basic properties to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
954b6ca942 Handle new locking action identifiers in document action view controller of FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
b975b2dfa1 Add lock/unlock actions in FileProviderUIExt info plist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
3a983c22bf Add basic LockViewController components
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
3c4d6bda2f Move all sharing components for FileProviderUIExt into a Sharing folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 10:15:58 +02:00
Claudio Cambra
92f6de9ca9 Always correctly set values for all fields in File Provider sharing UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:12:56 +02:00
Claudio Cambra
b80afca177
Wrap access of itemUrl in security scoping
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 04:56:31 +08:00
Claudio Cambra
59928a6c33
Explicitly set bundle name and identifiers from env vars in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 04:56:31 +08:00
Claudio Cambra
96f1ba656f
Unify FileProviderUIExt entitlements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 02:26:49 +08:00
Claudio Cambra
19cf69ccd3
Make sure network error is shown in UI instead of generic error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 02:07:48 +08:00
Claudio Cambra
ac1b11708f
Improve logging across file provider sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 01:58:38 +08:00
Claudio Cambra
1f78b9f685
Fix build of ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:15:02 +08:00
Claudio Cambra
b9483f0c55
Remove use of all code now available in NextcloudFileProviderKit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:15:01 +08:00
Claudio Cambra
1beb04371c Add a "no shares" label if there are no shares available in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
3bdb1ca1cb Update description label in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
5070c370a6 Display shareWith in nkshare displaystring extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
af2b2e7aa1 Clean up TODO comments in file provider ui ext
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
395cf9649c Fix SuggestionsTextFieldKit import
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
4464f7e460 Simplify configuration of text field delegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
66f77233a8 Fix suggestion labels for sharees
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
db20e44850 Use suggestions window controller in share options view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
07b6391688 Improve logging in ShareeSuggestionsDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
798e060032 Post suggestions changed notification in ShareeSuggestionsDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
c91d5827ab Update suggestions on inputString change in sharee suggestions data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
ad43c13882 Add converter method fro nksharee to suggestion
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
3012976d9b Add sharee fetcher method to shareesuggestionsdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
74cea5e57a Add basic shareesuggestionsdatasource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
ca94b452f1 Add package dependency NextcloudCapabilitiesKit to NextcloudIntegration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
e54652b690 Retry getting information from FileProviderExt if doing so has failed (usually due to opening share view before auth details are present)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00
Claudio Cambra
1f3d636a92 Deduplicate error presentation in ShareTableViewDataSource
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:11:50 +08:00