mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-22 21:50:30 +03:00
Code Issues Projects Releases Packages Wiki Activity
19008 commits 486 branches 258 tags 464 MiB
Commit graph

19008 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matthieu Gallien
73ae8a11c2
Merge pull request #5436 from nextcloud/ci/clangTidyChecksInitVariables 
Ci/clang tidy checks init variables
 2023-02-22 17:53:45 +01:00
Matthieu Gallien
151d17aed4
fix ignored return values in windows specific code 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:21 +01:00
Matthieu Gallien
5b2a691f4c
use of QStringLiteral() is invalid: QString() must be used 
fix windows specific code compilation warnings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
c0549c5c03
fix issues reported by compiling windows code with clang-tidy 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
c895359e6b
manually fix some variables without init values 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
a4f8837233
do not use static_cast to downcast: can generate runtime issues 
using a static_cast like this means that the compiler will not check the
validity of the cast

this could lead now or later to crash and other issues if the real type
is not the one in the cast

done with clang-tidy

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
011d668a23
modernize use auto 
done with clang-tidy

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-auto' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:20 +01:00
Matthieu Gallien
6df6c8d44c
sets clang-tidy configuration in cmake to get automatic checking 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-22 16:50:19 +01:00
Nextcloud bot
41a24b4971
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-22 15:12:55 +00:00
Nextcloud bot
616d7c1661
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-22 03:43:20 +00:00
Nextcloud bot
df19b79a69
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-21 13:22:50 +00:00
Matthieu Gallien
ee4b38277d
Merge pull request #5427 from nextcloud/rakekniven-patch-1 
l10n: Added dot to end of sentence
 2023-02-21 10:09:26 +01:00
rakekniven
c195513049 l10n: Added dot to end of sentence 
Aligned end of sentences in about dialog.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-02-21 08:51:10 +01:00
Nextcloud bot
7ef5ca81a7
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-21 03:42:21 +00:00
Matthieu Gallien
96dfa7add0
Merge pull request #5448 from nextcloud/bugfix/ignoreInvalidE2EMetadata 
skip e2e encrypted files with empty filename in metadata
 2023-02-20 18:49:33 +01:00
Matthieu Gallien
a8a5dfe6c6 skip e2e encrypted files with empty filename in metadata 
we cannot decrypt a file without a name

for now we will ignore them

we should probably do much more for the user but I fail to see how to
generate errors from e2ee module

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-20 09:50:34 +01:00
Nextcloud bot
b99775bb23
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-20 03:41:31 +00:00
Nextcloud bot
f6901fa065
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-19 03:41:02 +00:00
Matthieu Gallien
ec7fd9542c
Merge pull request #5444 from nextcloud/bugfix/useProperUserIdForEditLocally 
fix edit locally job not finding the user account: wrong user id
 2023-02-17 11:21:56 +01:00
Matthieu Gallien
24fc49f99d fix edit locally job not finding the user account: wrong user id 
the only correct id for an user is Account::_davUser

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-17 09:47:06 +01:00
Nextcloud bot
8843ea7882
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-17 03:41:54 +00:00
Claudio Cambra
7deef8fce3
Merge pull request #5442 from nextcloud/bugfix/fix-share-load 
Fix share dialog infinite loading
 2023-02-16 13:47:32 +01:00
Claudio Cambra
89ebfcae8e Try to initialise share manager again if we receive updated sharing permissions that would have previously prevented sharing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-16 13:06:35 +01:00
Claudio Cambra
2fbdf1be8f Simplify check for file record sharing permission 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-16 13:06:35 +01:00
Nextcloud bot
9bd5823bac
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-16 03:40:49 +00:00
allexzander
be0bd5e332
Merge pull request #5430 from nextcloud/rakekniven-patch-2 
l10n: Fixed grammar
 2023-02-15 22:35:58 +01:00
rakekniven
09a0fa7908
l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-02-15 19:58:23 +01:00
Nextcloud bot
b2ce28d52e
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-15 03:40:36 +00:00
Claudio Cambra
ccedff3272
Merge pull request #5416 from nextcloud/bugfix/remove-account-crash 
Clean up account creation and deletion code
 2023-02-14 21:18:36 +01:00
Claudio Cambra
72fb279508 More accurately log what happens when deleteAppPassword is complete in Account 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
893adb8280 Remove unused slotDeleteAccount in AccountSettings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
7084310a9f Remove unused AccountState::writeToSettings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
446bb29155 Avoid trying to delete keychain encryption data if there is no encryption data configured 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
2c17305864 Add sensitiveDataRemaining convenience method to clientsideencryption 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
e7c978551d Make sure to return in checkAllSensitiveDataDeleted 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
4ded5e1b38 Don't early return in sensitive data deletion for clientsideencryption if the entries were never stored in keychain 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 20:22:51 +01:00
Claudio Cambra
8483a4553a
Merge pull request #5435 from nextcloud/bugfix/create-folders-settings-menu 
Fix "Create new folder" menu entries in settings not working correctly on macOS
 2023-02-14 20:13:11 +01:00
Claudio Cambra
69d73d1333 Respond to folder creation at specific creation path on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 18:27:03 +01:00
Claudio Cambra
30ce2eab02 Notify when folder is created with full folder path in FolderCreationDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 18:27:03 +01:00
Claudio Cambra
89d3022649 Do not search for folder twice 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 18:27:03 +01:00
Claudio Cambra
6c548145a2 Make sure to manually call folderwatcher when creating new folder from settings menu in macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-14 18:27:03 +01:00
Nextcloud bot
0e2cf63fe5
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-14 03:40:06 +00:00
Claudio Cambra
7da0c2cb78
Merge pull request #5410 from nextcloud/feature/terminal-logging 
Log to stdout when built in Debug config
 2023-02-13 20:47:35 +01:00
Claudio Cambra
4d9fef81c9 Log to stdout when in debug mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-13 19:59:46 +01:00
Claudio Cambra
4b380dc23a Fix indentation in logger constructor 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-13 19:59:46 +01:00
Nextcloud bot
7953d4ebc6
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-13 03:42:56 +00:00
Nextcloud bot
daa87d03a2
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-12 03:38:59 +00:00
Nextcloud bot
6eae28a935
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-11 03:38:20 +00:00
Nextcloud bot
36db9f3a12
Fix(l10n): 🔠 Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2023-02-10 03:45:04 +00:00
Claudio Cambra
16612d7a69
Merge pull request #5351 from nextcloud/checkTranslations 
check German translation for wrong wording
 2023-02-09 22:40:19 +01:00