mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-25 06:25:56 +03:00
Code Issues Projects Releases Packages Wiki Activity
18550 commits 473 branches 255 tags 511 MiB
Commit graph

375 commits

Author SHA1 Message Date
Claudio Cambra
19a2f8cc7d Add support for macOS to flake 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-12-13 16:42:35 +01:00
Claudio Cambra
46381f5ddc Update macOS shell integration deployment targets 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-29 11:35:35 +01:00
Marvin Schmidt
7f72678d32 cmake: Use FindPkgConfig's pkg_get_variable instead of custom macro 
Commit b34a901838 ("Use FindPkgConfig to find libcloudproviders and
related libs") introduced the usage of cmake's FindPkgConfig module
which provides `pkg_get_variable` since version 3.4 that can be used
instead of the custom `PKGCONFIG_GETVAR` macro

Signed-off-by: Marvin Schmidt <marv@exherbo.org>
 2022-11-24 12:04:54 +01:00
István Váradi
2002c98b68 Modernize the Dolphin action plugin 
Instead of installing a .desktop file, it is now converted
to JSON and compiled into the plugin itself. The plugin is
also installed into a different directory.

Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2022-11-23 13:35:49 +01:00
Nathan Pratta Teodosio
2ba08206af Fix compatibility with newer python3-nautilus 
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
 2022-10-29 14:37:41 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
Claudio Cambra
a74f9b367d Ensure the dispatch source only gets deallocated after the dispatch_source_cancel is done 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-01 13:15:40 +02:00
Claudio Cambra
1f04073e7c Fix possible overflow on lineWritten 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-19 12:40:59 +02:00
Claudio Cambra
683e7794a3 Fix crashing of finder sync extension caused by dispatch_source_cancel of nullptr 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 12:48:23 +02:00
Claudio Cambra
628ee10008 Implement local socket to communicate with finder extension 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 11:46:57 +00:00
Matthieu Gallien
75bcc9a24e require cmake 3.16 
close #3572

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-09 13:07:48 +00:00
Matthieu Gallien
4371c0cbfe add headers in cmake files to get them properly detected 
qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-11 14:31:22 +00:00
Felix Weilbach
ec64246dc7 Only build app bundle if requested 
For development a app bundle is not needed. The app bundle is only
needed for distribution and macdeployqt takes a lot of time.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-23 11:41:29 +00:00
Felix Weilbach
113ba716e6 Compile finder extensions for arm and x86 
Fix: https://github.com/nextcloud/desktop/issues/3967

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-16 08:54:48 +00:00
Matthieu Gallien
f8a8e3f2f9 target names are not changed in branded builds only the output filenames 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-15 15:22:29 +02:00
Mathias Eggert
51cfe76d65 add ContextMenuOptIn to COM registration, to allow Placeholder support. Issue #3584 
Signed-off-by: Mathias Eggert <mathias.eggert@nexenio.com>
 2021-09-28 11:20:30 +02:00
Dmytro Korchynskyi
8351c398bc Fixed warnings in RemotePathChecker on Windows 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Nicolas Fella
18ddb9df4a Use CMAKE_INSTALL_DATADIR instead of custom DATADIR 
CMake provides what we wan out of the box

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-09-01 11:43:03 +00:00
Matthieu Gallien
d17d831205 switch from Q_DECL_OVERRIDE to plain override 
our requirements guarantee availability of override keyword so we just
use it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:57 +00:00
Felix Weilbach
332a48e6a1 Update to Qt 5.15 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-19 14:01:46 +02:00
allexzander
871210326f Windows. Nextcloud Overlay Identifiers. Set 16 spaces before each identifier's name. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-14 16:15:02 +03:00
Hannah von Reth
bff386e5c1 Fix int uint warning 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
Nicolas Fella
b8879dbf07 Only include libcloudproviders dir when cloudproviders is found 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-13 11:29:29 +00:00
Nicolas Fella
df3ebb11f6 [shellintegration] Simplify cmake code 
We don't need ECM to check for KIO

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-13 11:22:19 +00:00
Nicolas Fella
e207cfdbfc [dolphin] Clean up CMake code 
Remove some stuff that is not needed.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-12 13:27:46 +00:00
Hannah von Reth
58bc9e837c
Remove junk files 2020-12-15 10:59:26 +01:00
Christian Kamm
2b20985875
winvfs: initial work 
Done by ckamm and dschmidt
 2020-12-15 10:58:21 +01:00
Olivier Goffart
919debccfc
nautilus shell integration: Fix when there are several branded client installed 
It appears that several extension can be loaded at the same time, but their
classname for the extension need to be different, otherwise only the last
loaded one would be active.

Issue #6524
 2020-12-15 10:57:55 +01:00
Michael Schuster
61dc4b9137
Update comments 
Everyone uses their private mail, so ensure people can get in touch.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-10-15 02:18:52 +02:00
Michael Schuster
fc365df5de
Windows MSI: Let CMake install Shell Extensions WiX fragment to "msi/" 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-09-21 16:40:19 +02:00
Michael Schuster
4df8db4ff6
Fix spacing 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
db05f65e0d
Windows shell extensions: Add WiX (MSI) fragment 
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
11632da7ea
Windows shell extensions: Change NCUtil Pipe name from ownCloud to APPLICATION_EXECUTABLE 
Avoid interference with foreign pipes as this is always a bad idea ;p

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
0ba5df597f
Windows shell extensions: Rename all files and classes from OC* to NC*, update version info 
This also ensures a clear separation in the system registry.

SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.

For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks

Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.

Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html

Example:

  [HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
  @="1.0.0.0"

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
8ce13b7bdb
Windows shell extensions: Use custom GUIDs via CMake and prepare MSI reg 
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.

Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.

Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
4675869fb3
Remove dead code 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
bfd7707ff4
2.7 has less automatic includes on Windows 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
34e9e2f288
Cleanup Windows shell extensions 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
6c9a31f6ee
Remove outdated visual studio projects, we now use cmake 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt
13d4b91935
Avoid warning because /MT overrides /MD flag 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt
e4b53b12e1
Make OCUtil helper lib static and link it statically against crt 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Olivier Goffart
906556640d
Windows Shell Integration: Don't limit the size of the buffer 
Otherwise we can't have operation that has many many filename

As reported in #6780

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Christian Kamm
77cc262337
Windows shellext: Update copyrights and company name 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Olivier Goffart
6274462036
windows shell extension: add OCUtil/resource.h 
It's a copy from OCContextMenu/resources.h

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Christian Kamm
c6fc46aa09
Windows shellext: Add rc for OCUtil #6554 
To set the dll's metadata.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Kevin Ottens
d58ec4bf70
Enable the modernize-use-using check on clang-tidy 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-12 18:18:57 +02:00
Kevin Ottens
c50a968a1e
Add more raw string literals missed previously 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-12 09:48:29 +02:00
Michael Schuster
456c1eadbe
Simplify nullptr comparisons where appropriate 
Make the codebase consistent, we already have a lot of implicit pointer comparisons.

Exception: Stay explicit on return's, example:
  return _db != nullptr;

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-06-11 00:27:30 +02:00
Michael Schuster
2b680cadd3 Fix nullptr regression in RegistryUtil::ReadRegistry 
Merging PR #2057 caused the Windows build to fail:

shell_integration\windows\OCUtil\RegistryUtil.cpp(43): error C2664: 'LSTATUS RegOpenKeyExW(HKEY,LPCWSTR,DWORD,REGSAM,PHKEY)': cannot convert argument 3 from 'nullptr' to 'DWORD'

The previous implementation prior the PR supplied NULL as the argument 3 to RegOpenKeyEx,
so it was silently accepted and translated to zero, satisfying the DWORD's type requirement.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-06-09 18:34:43 +02:00
Stephan Beyer
ea16804751 Replace NULL by nullptr in all C++ files 
We keep NULL in the pure C files in src/csync/std and test/csync.

We also replace Doxygen documentation referring to "NULL" to
"\c nullptr" (formatted as code).

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-06-08 20:07:50 +02:00