mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 12:22:16 +03:00
Code Issues Projects Releases Packages Wiki Activity
17950 commits 487 branches 258 tags 462 MiB
Commit graph

8448 commits

Author SHA1 Message Date
Matthieu Gallien
d4081c99a7 prevent updating files when that would result in invalid mtime 
ensure that we never try to sync a file with a sync that would result in
setting it up to an invalid mtime

test a recovery scenario with plain old sync folder and virtual files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-17 23:28:02 +00:00
Matthieu Gallien
b8ff1525f7 let error during update of metadata of virtual files propagate to users 
errors duing update of metadata of virtual files are being ignored and
not propagated to users to be shonw in main dialog

ensure they are real errors from sync engine point of view and let them
be taken into account

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-17 23:28:02 +00:00
Matthieu Gallien
541447723a remove all usage of QDateTime::toTime_t() to avoid overflow 
QDateTime::toTime_t() can overflow if called with a date outside its
domain of working

this method is obsolete and QDateTime::toSecsSinceEpoch() is the
replacement

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-17 23:28:02 +00:00
Matthieu Gallien
a7adca84e2 remove wrong assert that is blocing the run of debug client 
if the server has files with invalid modtime this assert will trigger
even though the code is handling the situation

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-17 23:28:02 +00:00
Camila
73bae8cd30
Add TalkReply class and tests. 
- Add struct TalkNotificationData to handle token and messageId.
- Handle chat and call notifications with the new struct.
- Add talk token and messageId to data roles in ActivityListModel.
- Add Talk Reply component to the ActivityList.
- User Loader to display the TalkReply component.
- Move Talk Reply from ActivityItem to ActivityItemContent due to PR #4186.
- Use TextField instead of Text.
- Disable send reply button instead of changing border color when field is empty.

Signed-off-by: Camila <hello@camila.codes>
 2022-03-17 17:50:33 +01:00
Claudio Cambra
628ee10008 Implement local socket to communicate with finder extension 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 11:46:57 +00:00
Claudio Cambra
65f2bada3e Add thumbnails for files in the activity view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 10:46:09 +00:00
Claudio Cambra
f585b8bd48 Add support for server color theming by using server color as accent 
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 13:57:45 +01:00
Claudio Cambra
02f3a1aed6 File activity dialog now works for all file actions activities (e.g. deleted files) 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 08:38:14 +01:00
Claudio Cambra
ead4cc6fe3 Increase max line of text in activity item text to two 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-15 09:22:11 +00:00
Claudio Cambra
2f795df701 Ensure file activity dialog appears in centre of screen 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-13 22:11:26 +00:00
Matthieu Gallien
11e7ebd5fa properly ask Qt to create qml opengl surface with proper options 
should prevent context losses error with some opengl drivers

should prevent corruptions to occur with come opengl drivers

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-10 14:19:46 +00:00
alex-z
01eb050cd8 Do not remove files from a Group folder and its nested folders whe it is renamed or removed while not allowed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-03-09 10:54:39 +02:00
rakekniven
8aa3ab3d37
Merge branch 'master' into rakekniven-patch-1 2022-03-04 12:22:31 +01:00
Camila
2c20f81a53 Add 'Help' action back. 
I think it was a mistake that caused this.

Signed-off-by: Camila <hello@camila.codes>
 2022-03-03 11:16:09 +00:00
Claudio Cambra
f6b377ab17 Simplify currentScreen 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-02 13:37:30 +00:00
Claudio Cambra
655a2e1c39 No longer assume status bar height, calculate, fixing notch borking 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-02 13:22:55 +01:00
rakekniven
5045394b43
l10n: Changed spelling 
Reported at Transifex.

Fix for #4004 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-02-28 18:40:26 +01:00
alex-z
bf80efc7ab Fix review comments from Matthieu. Using curent reverse iterator when searching for parent. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-25 15:31:26 +00:00
alex-z
6c690a1b09 Do not remove a folder that has files that were not uploaded yet during propagation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-25 15:31:26 +00:00
alex-z
3443de4388 Rollback local move when server move has failed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-23 16:53:26 +02:00
Valdnet
e098e73b06
l10n: Change to lowercase 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-02-12 18:38:26 +01:00
Matthieu Gallien
4371c0cbfe add headers in cmake files to get them properly detected 
qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-11 14:31:22 +00:00
Matthieu Gallien
e4590d7a3b ensure that bulk upload network job errors are handled 
in case we get a network error during bulk propagator POST network
request, report all files within this upload as files in error that will
then be sent using the plain old WebDAV protocol

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-11 09:44:20 +01:00
Matthieu Gallien
8decd475e5 clean transition when files with spaces exist already 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-07 21:32:06 +00:00
Matthieu Gallien
e89268bdd7 ensure we emit a rename command for renamed files 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-07 21:32:05 +00:00
alex-z
ae44dd5978 Adjust icons for activity entries in main dialog. Refactor the dialog by splitting it to separate components. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-04 17:52:37 +02:00
alex-z
0776df65c3 Always build with updater. Use 'beta/stable' channel seletor in 'General Settins' dialog with default 'stable'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-02 10:46:11 +00:00
alex-z
0ea7e8d3a6 Cmake option to disable proxy 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-02 10:02:34 +00:00
Claudio Cambra
a2524763c8
Merge branch 'master' into bugfix/account-menu-scroll 2022-02-01 17:01:51 +01:00
Claudio Cambra
ce5494b4ec Add testing for ActivityListModel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-02-01 13:57:08 +00:00
Claudio Cambra
7a1eae45d3 Account menu can now scroll 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-31 15:06:55 +00:00
Matthieu Gallien
20a4ed6e7e use proper API to dehydrate a placeholder file 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-01-24 14:16:40 +00:00
Claudio Cambra
624213956e Add ability to copy internal link from share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-24 09:40:28 +00:00
Felix Weilbach
12610baeba Replace Text with Label 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Felix Weilbach
f4bf4da44d Remove commented out code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Felix Weilbach
99457e8c38 Use the font size that Qt suggest 
Fixes: https://github.com/nextcloud/desktop/issues/3797

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Claudio Cambra
2a27882307 Show only filenames in tray activity items, with full path in tooltip 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-14 08:02:08 +00:00
Camila
fd8186ff0e ShareDialog: group links and users in one scrollbar. 
- Remove the scrollbar used only for user shares
- Resize share dialog when removing share links
- Fix widget margins and max height of the share dialog
- slotAdjustScrollWidgetSize => adjustScrollWidgetSize

Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
82aed71d09 Just trying to make the sahre dialog look nicer. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
c08a291742 Remove unused slots. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
a10f84b5c1 Add scroll area for share links. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
rakekniven
5cec3c3ca1 l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-01-13 09:39:13 +00:00
alex-z
3aaaaaf2d0 Bugfix. Re-init sharing manager to enable link sharing UI when receiving sharing permissions. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-13 10:42:48 +02:00
rakekniven
961cea92ca l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-01-12 15:55:56 +01:00
alex-z
39d1ca3a3c Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
39e2292acd Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
3d7fc166b4 Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
4a8433d297 Display error message when creating a link share with compromised password. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
Dmytro Korchynskyi
c872514571 write logs to Output window of Visual Studio 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2022-01-12 11:59:34 +02:00
alex-z
225753a8c0 Refactor DeleteJob and DeleteApiJob to use SimpleFileJob. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-11 13:37:09 +00:00
alex-z
190d278fd4 Checksum validation PropagateDownload unit tests. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-11 13:37:09 +00:00
alex-z
6f5f3e769f Fix typo in usernamePrefillServerVersionMinSupportedMajor. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-11 13:37:09 +00:00
alex-z
b7be10f712 Ask server to recalculate checksum on validatin failure. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-11 13:37:09 +00:00
Claudio Cambra
f23c7007a5 Fix space 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
a1d42b4177 Make compiler required when option is on, removed unused def 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
8ad04f5a5e Remove AUTORCC 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
e25140d72e Add option of enabling QtQuick compiler 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
alex-z
77d7a0b7ed Do not display 'Conflict when uploading some files to a folder 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-07 08:46:22 +00:00
alex-z
62b0a9b9f1 Try to sign-in after being signed-out due to SslHandshakeFailedError 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-05 10:01:13 +02:00
Claudio Cambra
8c091a2daa Hide share button for deleted and ignored files in tray activity 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2021-12-20 16:07:11 +00:00
Valdnet
cedf079762
Remove parenthesis 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-12-17 08:53:35 +01:00
Matthieu Gallien
3e82466d5e ensure any errors after calling FileSystem::getModTime are handled 
be sure that even in release mode no errors when calling getModTime
could be ignored

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-16 15:28:46 +01:00
alex-z
b66ba8ba0a Added sync stop when failed to cancel delete jobs. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-15 13:41:30 +00:00
alex-z
6381acf85b Do not crash on findAndCancelDeletedJob. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-15 13:41:29 +00:00
alex-z
2482ca7ea7 Fix CMake error in ECMAddAppIcon for mac. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 17:31:21 +00:00
Matthieu Gallien
24f1d2ce89 fix review comment 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-14 15:28:42 +00:00
Matthieu Gallien
f581f71058 ensure bulk upload jobs finished after an error 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-14 15:28:42 +00:00
alex-z
3f3b752e44 Save folder settings to config when force-switching VFS. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 16:33:35 +02:00
alex-z
1244e96681 Enforce VFS. Disable 'Make always available locally'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 15:03:57 +02:00
Matthieu Gallien
9a201a8963 force download from server for local files that have invalid dates 
will trigger if local state is incoherent
like the file itself haveing 0 or negative modtime and the database not

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-14 10:00:59 +01:00
Matthieu Gallien
8ead035016 do not get stuck forever in sync in case of errors 
when a local file has invalid date and we try to upload it, properly
handle the error such that we are not stuck forever in sync state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-10 11:28:35 +01:00
Matthieu Gallien
66d981aa64 remove files which gets downloaded with an invalid modified time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-09 10:00:36 +01:00
Matthieu Gallien
8696670909 add log statements for each new assert about invalid modified time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
791073bd28 recover from local invalid modifie time: force download from server 
force file download if local modified time is invalid and server has
valid modified time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
41c86d6459 prevent cases where desktop client would store invalid modified time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
b1977dfb18 prevent injecting invalid modified time through CfApi calls 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
76c8d7287e do not consider that a file has changed if its mtime is invalid 
a mtime should never be 0 or negative

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
389424c54b avoid downloading a file from server when modified time is invalid 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
c9f63b5744 prevent invalid modified time from being propagated 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
9523c036d6 assert on invalid modtime 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
alex-z
77bf892809 Use different icon for a sync folder on Windows depending on zoom level. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-07 15:48:16 +00:00
Matthieu Gallien
b053cf9e2a do not forget the path when renaming files with invalid names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-07 11:35:38 +01:00
alex-z
25785841a3 Always prefill username from Windows login name based on server version 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-03 11:08:35 +02:00
rakekniven
7dfd8181fa l10n: Changed case of word 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-11-30 11:52:46 +00:00
Matthieu Gallien
c53159cb0c fix random error when updating CfApi metadata 
initialiazing all fields in a structure is required to not have random
behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-29 18:04:00 +01:00
Matthieu Gallien
1a9aade28e use the error message sent by the server for bulk upload 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 16:32:08 +01:00
Matthieu Gallien
34c4c28879 allow sending parallel batch of files: curretly disabled 
can allow to send a new batch before the reply to a previous one is
received

due to concerns with the reliability on the server side this is disabled

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 16:32:08 +01:00
Matthieu Gallien
a272b34809 really check that this is a valid answer when receiving batch upload 
we could somehow miss that the reply is missing proper fields

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien
05b8d1e40d batch upload: only handle file that are in the reply 
do not handle all files sent but only received ones

should allow to submit more than one request in parallel

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien
e14502606c make sure we do not start a new batch when the previous one is not sent 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien
59953d857b use a proper constant for the size of batch 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 15:49:25 +01:00
Matthieu Gallien
f56985938d if BulkPropagatorJob abort after an error emit finished signal 
prevent sync engine being stuck because of an error when preparing bulk
upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-26 12:48:38 +01:00
Matthieu Gallien
c194605c35 implement bulk upload 
add PutMultiFileJob to send many files at once

use it in BulkPropagatorJob to implement bulk upload feature

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
Matthieu Gallien
112be18635 read capabilities for bulk upload from server 
use it in dedicated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
Matthieu Gallien
802c7ac906 make AbstractNetworkJob::errorString virtual: it is already overriden 
in practice AbstractNetworkJob::errorString is already overriden but the
overrided code is probably never called while the intention looked like
the opposite

fix that by making the method virtual in base class

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-24 16:17:47 +01:00
alex-z
b03bf1c1f0 Pass username from Windows to login page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-24 10:04:22 +00:00
Matthieu Gallien
83a8058b51 improve logging for CfApi 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
072e9d44bd gracefully handle one case of invalid handles 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
a3013de6ea fix OCC::CfApiWrapper::handleForPath when path does not exist 
sometime it can be called with a path that is already deleted

ensure we always go to the correct code path

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
9eed62a854 remove too noisy log print 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
alex-z
b3914f627d Cleanup system bindings from Windows when removing a local sync folder 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-23 08:32:55 +00:00
Matthieu Gallien
684d70985e fix button that should be disabled when force VFS 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 14:22:59 +01:00
Matthieu Gallien
12c6d6e3bd add a network access factory to qml engine 
ensure network access made via qml are using our user agent

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 12:21:58 +00:00
Carl Schwan
38ac585e7c Add WheelHandler to the Search result list too 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
Carl Schwan
892d289f38 [tray] Makes scrolling with a touchpad in activiy list more natural 
This basically use the same method that is used in Kirigami and Plasma
Components3.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
alex-z
8e6896ba03 Quick fix! Disable VFS folders removal for non-Windows VFS. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-22 12:37:18 +02:00
Matthieu Gallien
f1d834df8e properly query sync journal DB to know when to run fix for VFS 
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run

the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-19 14:19:04 +01:00
alex-z
73db636361 Added more logs to 'postProcessLocalNew'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-19 09:10:20 +00:00
alex-z
911e35bc50 Use QUrl::fromLocalFile to open local files in Unified Search results. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-18 09:34:54 +00:00
Felix Weilbach
9e792369b2 Refactor key-value store query code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Felix Weilbach
c76a77e431 Correct virtual files placeholder files if needed 
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Matthieu Gallien
c59f88ca82 avoid adding icon data in a cache we never use 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-16 16:11:44 +01:00
Carl Schwan
d84673376d More fixes to the menu implementation 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Carl Schwan
69def04ec2 Fix focus indicator 
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Felix Weilbach
07a8e8c91d Check if the server has user status app enabled 
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-15 16:20:58 +00:00
Alexander Batischev
d8560dcb19
CMake: fail if Qt5::GuiPrivate is not found 
`nextcloud` and `nextcloudCore` depend on three Qt5 components which
aren't mentioned in `find_library`: `Xml`, `Network`, and `GuiPrivate`.
The first two are omitted by mistake, apparently, so this commit just
adds them.

`GuiPrivate` is a special case: it doesn't have its own CMake config, so
adding it to "required components" in `find_package` will always fail
the build. Thus, we implement our own check instead.

Signed-off-by: Alexander Batischev <eual.jp@gmail.com>
 2021-11-15 13:57:18 +03:00
Felix Weilbach
3e368ee4df IconJob: Send request through the accounts NAS 
This helps tracking requests on the server

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:49 +01:00
Felix Weilbach
db337c4457 Add profile page 
Fix: #3889

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:47 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
rakekniven
416d98716f Make argument singular to fix i18n issue 
Reported at Transifex.
See https://www.transifex.com/nextcloud/nextcloud/translate/#hu_HU/client/309577611

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-11-05 10:00:17 +01:00
alex-z
2f3c58daac Fix review comments. Use QImage for QML and QPixmap for rest of code. Do not cache images for QML. Fix tests. Use signal in QML. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0b8ab5c079 Use SvgRenderer for Unified Search input icons. Refactor IconUtils. Extend unit tests. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0d8375e798 Clear Unified Search Input Field in a proper way 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
Felix Weilbach
d661e91a58 Don't do a connection checks when using push notifications 
When using push notifications, it is not necessary to do regular
connection checks because the push notifications will take care of it.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-04 18:07:22 +00:00
Felix Weilbach
650578ee64 Don't convert exclude file to placeholder file 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-04 18:18:50 +01:00
Matthieu Gallien
43ec429fe4 improve logs when place holder info cannot be read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Matthieu Gallien
9658aea963 on switch to VFS real plugin, convert existing files to placeholders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
alex-z
d88e086b94 ShareLinkWidget. Fix incorrect calendar mindate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 13:23:00 +02:00
alex-z
6c3c45dadd Implement expiration date for federated shares 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 10:54:18 +00:00
alex-z
c52718c104 Replace deprecated QRegExp with QRegularExpression. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-02 08:54:06 +00:00
Matthieu Gallien
a62905f17a properly extract the file id when querying server 
use the proper local file id to get the e2ee meta data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-02 08:15:54 +00:00
Matthieu Gallien
8226c30d84 by default we produce debug logs because we need them 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-28 13:48:55 +00:00
Camila
d68b8604ac Refactor toggleButtonAnimation function. 
Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
ab524d2392 Fix display of deleted note. 
Even after removing note from share link,
the previous text was being displayed.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
72c91362f2 Refactor ShareLinkWidget show/hide widgets functions. 
- Remove unecessary call to setupUiOptions after saving share password.
- Slot to create label: do not set it if nothing changed.
- Refactor showPasswordOptions, toggle/PasswordOptions/ExpireDateOptions/NoteOptions.
- Add const, auto and {} whenever possible.
- Refactor slotToggleButtonAnimation => toggleButtonAnimation.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
5788f35e82
Skip sync exclude file from list of exclude files if it doesn't exist. 
The file might not exist anymore because the user deleted it by hand or
the folder where it was located got unchecked in the selective sync
view. It is a fix for #2632.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 11:37:56 +02:00
alex-z
db4e54025a Forbid trusting the untrusted certificate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
alex-z
907ebc1959 Request OCSP validation data from the server during the SSL handshake. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
Matthieu Gallien
87c583dcb6 schedule files upload after all other jobs have been completed 
should allow smarter policy dedicated to optimizing files upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 14:26:28 +02:00
Matthieu Gallien
24428d9980 add missing Q_ENUM macro to improve logging 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
Matthieu Gallien
b0ef5e0635 no oneliner if: a bug waiting to happen 
it is much too easy to get a bug because one could miss the lask of {
and }

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-26 12:45:15 +02:00
rakekniven
c39b97adb3
Update UnifiedSearchInputContainer.qml 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 10:44:07 +02:00
rakekniven
beffd63512
Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 07:35:47 +02:00
Matthieu Gallien
69d6f4acec our source code files have lower case names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-25 15:38:21 +02:00
alex-z
1b8448402a Fix JsonApiJob incorrect 'statuscode' parsing. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-25 14:45:05 +03:00
alex-z
c1dab7e4cb Unified Search via Tray window 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-25 14:45:05 +03:00
rakekniven
91884eef4a Changed wording to suggestion 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
rakekniven
fb3c740129 Changed wording of status message 
The files themselves have no problem. The sync process has problems. 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
alex-z
da03acc656 Fix folder creation issues. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-20 19:47:41 +00:00
Felix Weilbach
9f35fa6d3d Also update sync state summary based on connectivity 
Otherwise, with zero folders configured, the state will stay at
offline.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-20 12:31:55 +02:00
Felix Weilbach
1156d82594 Log file name and line number 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-19 17:10:44 +00:00
alex-z
bd731a9cda Windows. Remove CWD from DLL search paths. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-19 06:40:56 +00:00
Felix Weilbach
24f6bc5203 Only use basic authentication if needed 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-18 12:20:20 +02:00
Camila
c6e629c30d
Give the user a more descriptive error message when syncing is aborted. 
Signed-off-by: Camila <hello@camila.codes>
 2021-10-18 09:50:02 +02:00
Valdnet
22b0a2e196
i18n: Correct typo and remove apostrophe 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-10-15 08:44:02 +02:00
Felix Weilbach
d51bfec61d Remove unnecessary braces 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
f27ef02273 Set dialog max and min width and height before width and height 
Otherwise, resize events will not be processed correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
a663d235ef Add .sync-exclude.lst to exclude files 
Previously the .sync-exclude.lst file of the sync root directory was
not added to the exclude files, because the current logic did only
recognize .sync-exclude.lst files when their containing directory was
discovered during the discovery phase. Therefore the sync root
.sync-exclude.lst file was never discovered. See also
ExcludedFiles::traversalPatternMatch().

Fix: #3830, #2728

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 14:02:29 +00:00
Felix Weilbach
df11424596 Trim trailing spaces before uploading files 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 11:22:59 +00:00
Matthieu Gallien
46bc0452c7 provide logs of SSL errors including the certificate chain 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-13 15:20:52 +00:00
Felix Weilbach
0792dc36c2 Check if current user exists before getting it's account state 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-13 11:25:13 +02:00
Felix Weilbach
4c11f6763e Show sync progress in main dialog 
Fixes #3662

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-12 16:14:24 +00:00
Matthieu Gallien
d76778e3ee fix macOs build after targets name are not changed by branding 
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-11 07:41:29 +00:00
Felix Weilbach
2da6dab403 Add missing copyright headers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-08 13:19:10 +02:00
Kevin Ottens
5fe63a4d9a Display the right endpoint in the warning in case of error 
At that point in time _pollEndpoint isn't set yet. All the checks are
against pollEndpoint so display that one in the warning. Otherwise one
always end up with an empty URL in the logs which is not very useful for
debugging purposes.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
 2021-10-06 10:17:38 +00:00
Matthieu Gallien
833237b2e4 use alias target for internal libraries 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Matthieu Gallien
c751fd5672 ensure DLL are generated with branded names 
cmake distinct runtime and library

on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Felix Weilbach
0c9dce1154 Add file activity dialog 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-05 12:41:34 +00:00
alex-z
6cafcc1124 Remove Temporary solution for file restoration issue due to failing to set the data-fingerprint. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-30 08:39:47 +00:00
Guido Falsi
b0b70d1e77 Check for argp library before depending on it. 
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
 2021-09-29 15:46:07 +02:00
Guido Falsi
5f036641b9 Add -largp on non linux systems. 
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
 2021-09-29 15:46:07 +02:00
Felix Weilbach
d6e60cd8d4 Don't log encryption data in release mode 
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-27 19:50:38 +00:00
Camila
df38e5c08b Apply server default permissions for federated file sharing too. 
See nextcloud/server#24729 comments.

Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
Camila
8f847906c6 Check server capabilities for file sharing default permissions. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
alex-z
dc22307a42 Fix review comments + also check against trailing bakslash. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-27 08:13:29 +00:00
alex-z
e16402a102 Fix incorrect db name for nextcloud command line client. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-27 08:13:29 +00:00
rakekniven
68e02bc62d Fixed context 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1 Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631 Add dialog to resolve invalid filenames 
Fixes #3751

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5 set default format for QSurface to handle NVidia context loss events 
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver

close #3759

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-22 08:56:16 +00:00
alex-z
59199fc907 General Settings window. Allow opening the update URL via mouse. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-21 16:21:38 +02:00
Camila
db447c4676 Refactor OcsShareJob creation. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65 Add option to create label for share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da TextInput by default do not allow selecting text by mouse 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-21 08:07:19 +00:00
rakekniven
af49a7993a
Fixed placeholder numbering 
Fix for #3812 

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-20 11:39:51 +02:00
Felix Weilbach
0074d6c40a Disable Qt deprecation warnings 
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1 Fix warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f Display share note when there is one associated with a share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Camila
4581279d23 Fix indentation sharelinkwidget.h. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca Accept nc scheme in provider page 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 09:01:18 +00:00
Felix Weilbach
86da74908a Emit user status changed after clear user status 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 07:26:46 +00:00
Felix Weilbach
9aee46b3a4 Remove unnecessary logging statements 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 07:26:46 +00:00
Dmytro Korchynskyi
cffceaae1f Fixed warning: extra ';' in Q_ENUM_NS(PinState); 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
5f232c30be Fixed warnings from ntstatus.h on Windows 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
608fc5fb3a Fixed warnings by using static_cast 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Valdnet
a441d733dc l10n: Correct two typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454 Add dialog to set user status 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-09 11:18:22 +02:00
alex-z
4018f8d554 Prompt reboot when runing the auto update. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40 Fix various deprecated warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00