Commit graph

213 commits

Author SHA1 Message Date
Claudio Cambra
da581e2b0e
Do not treat bundles as executables in codesign check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 16:24:52 +08:00
Claudio Cambra
87a5b245fe Do a codesign of the app bundle itself as final step
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:18:20 +08:00
Claudio Cambra
2ea991228e Also sign executables during recursive codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:18:20 +08:00
Claudio Cambra
16c177cf4d Do not do deep codesign as default
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:18:20 +08:00
Claudio Cambra
0239ee3eae Escape code sign entitlement paths in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 18:16:51 +08:00
Claudio Cambra
4d15f47e09
Fix codesign path for app bundle main binaries
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 18:03:33 +08:00
Claudio Cambra
f5d91953bf
Use recursive codesign instead of broken wildcard path for sparkle Autoupdate app
Broken when we starting escaping paths in codesign arguments

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 16:34:09 +08:00
Claudio Cambra
7c171b8e20
Also add options to recursive codesign function
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 16:33:36 +08:00
Claudio Cambra
f6eb3f9b79
Also escape codesign call with saving entitlements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 16:11:32 +08:00
Claudio Cambra
533b04baf9 Ensure paths are passed properly escaped into codesign command in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 12:13:25 +08:00
Claudio Cambra
62bc088ea1 Add option to create developer builds of client via mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:32:30 +08:00
Camila Ayres
d24f3e1220
Fix the list of steps order.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-08 14:35:01 +02:00
Claudio Cambra
aaa6dad3a5 Match the universal build instructions with what we actually do with mac-crafter and make_universal
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-08 14:32:37 +02:00
Claudio Cambra
a2f07866f8 Clarify architecture setting has automatic default in mac-crafter readme
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-08 14:32:37 +02:00
Claudio Cambra
7b53352969 Simplify build instructions in mac-crafter README
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-08 14:32:37 +02:00
Camila Ayres
6acdee0813 Add README about mac-crafter.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-08 14:32:37 +02:00
Claudio Cambra
89b13285fe Codesign webengineprocess with correct entitlements on macOS with mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-30 11:54:10 +08:00
Claudio Cambra
0fe925f978 Add support for the new craft blueprint options relating to override server urls
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-29 23:16:20 +08:00
Claudio Cambra
c405ce34d6 Add note about packaging tooling in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
a77aca3ab2 Add package command for mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
facec09fa8 Make specific step functions for packaging fileprivate in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
0b588b8db4 Move packaging procedures into a single function in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
b1ad91d7cb Create convenience function to convert architecture string to craft target string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
1e61986f17 Fix work build path used in mac crafter packaging stage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
3b635c263b Remove unused sparkleFile var
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
b5ace6055b Use appName for packaging step in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
d195186332 Add logging to packaging procedures in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
d60f02ab0e Add ability to build and sign sparkle tbz from mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
7b76243290 Add ability to notarise package from mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
64e7d662ff Add ability to sign pkg from mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
8577a73b8e Add flag to build pkg in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
9d8b27e829 Add buildPackage function to mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:30:10 +08:00
Claudio Cambra
bc22272573 Correctly kill processes spawned by mac-crafter if mac-crafter quits/is killed/etc
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 16:28:50 +08:00
Claudio Cambra
7f3b13718a
Move building into separate subcommand, add subcommand just for codesigning
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 03:54:01 +08:00
Claudio Cambra
8620ff5127
Always move final product to product path in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 03:53:41 +08:00
Claudio Cambra
dcd640a504
Fix codesigning of qtwebengine related helper app in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 23:26:51 +08:00
Claudio Cambra
ad428c759f
Use deep codesigning by default in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 23:26:30 +08:00
Claudio Cambra
9126b66ad4
Make sure to code-sign all binaries in app bundle
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:41 +08:00
Claudio Cambra
d51def6638
Remove get-task-allow entitlement when code-signing app extensions
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:40 +08:00
Claudio Cambra
b0c4f650fe
Fix notarisation issues for Sparkle in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:40 +08:00
Claudio Cambra
76fbf012ea
Add convenience method to save the entitlements of a bundle to a file as XML
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 21:54:49 +08:00
Claudio Cambra
e1df119bf3
Fix issue with placing app bundle in product directory if an existing build is there
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 21:54:18 +08:00
Claudio Cambra
d82c342d7e Fix make_universal.py not taking into account 64-bit bundle dylibs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-09 08:43:36 +02:00
Camila Ayres
65fcac8d70 Remove QtWebEngineProcess.entitlements.
In the past, due to security reasons this file needed to be signed by us so the webview would work on mac OS.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-05 17:48:26 +02:00
Claudio Cambra
f8bde40ea9 Add mac-crafter Package.resolved to gitignore
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-06 11:05:16 +02:00
Claudio Cambra
a3081f2177 Add default product folder to gitignore
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-06 11:05:16 +02:00
Claudio Cambra
d1cb170d9d Only create product path's directory if it doesn't exist already
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-06 11:05:16 +02:00
Claudio Cambra
3588c139b8 Fix final path that app is copied to in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-06 11:05:16 +02:00
Claudio Cambra
73432d1dac Add option to set product path in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-19 16:57:23 +08:00
Claudio Cambra
b539861fcc Use default long arg type for build path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-07-19 16:57:23 +08:00