Olivier Goffart
4dbe0693df
FolderMan::checkPathValidityForNewFolder
...
factorize the function to check the validity of a new folder out of
the folder wizard to the FolderMan.
There is even a test for it now.
That way we can also use it in the normal wizard
2015-07-13 14:35:19 +02:00
Markus Goetz
a8fb94f51b
OS X Installer: Select app in Finder after install
...
This is to improve UX in #2410
2015-07-13 10:52:48 +02:00
Roeland Jago Douma
c052f6d4c9
Use capabilities to not allow removing of expiredate and password
...
If the server admin has enforced the expiration date and the password our UI
should not give the user the option to remove those.
2015-07-10 15:50:01 +02:00
Roeland Jago Douma
7f893aa676
Fore password request if required by capabilities
2015-07-10 15:26:26 +02:00
Olivier Goffart
45180a024d
Rename should_update_etag to should_update_metadata
...
This should avoid some confusion
2015-07-09 15:05:37 +02:00
Olivier Goffart
992d375e90
owncloudGui: Do not reset folders when login in or out.
...
This made no sens. Folders are setup when the account is setup.
Also this had the bad side effect to shut the sync engine too early,
leaving the SyncEngine::_syncRunning to true, and leading to ASSERT later
Issue #3427
2015-07-09 13:25:27 +02:00
Olivier Goffart
644486871b
owncloudGui: Fix crash when sign in
...
The sign in action from within that menu might change the account state
and call setupContextMenu. We must not delete the menu from there
Issue #3427
2015-07-09 12:17:27 +02:00
Olivier Goffart
08fcf650eb
Fix Qt4 build
2015-07-08 19:48:57 +02:00
Klaas Freitag
e28fab0c61
Folder: let path() always end on "/" rather than on platform spec. delim.
2015-07-08 18:13:41 +02:00
Klaas Freitag
7f628e6f7e
c_path: Fix function description.
2015-07-08 18:13:41 +02:00
Klaas Freitag
a076a170ee
vio_local: strncat only needs two chars as limit.
2015-07-08 18:13:41 +02:00
Klaas Freitag
ccc91a52a8
vio_local: Give strncpy and strncat enough space to copy closing zero.
2015-07-08 18:13:41 +02:00
Klaas Freitag
4cb78999d2
vio_local: Simplify and fix the error out behaviour of win32 impl.
...
This avoids leaking of a stat struct in error case.
2015-07-08 18:13:41 +02:00
Klaas Freitag
1a69e2ae8d
vio_local: Remove commented code.
2015-07-08 18:13:41 +02:00
Klaas Freitag
c7ba7c8e9f
Fix comment for c_path_to_UNC, plus cleanup of superflous debug.
2015-07-08 18:13:41 +02:00
Klaas Freitag
8bb1a49aaf
Use strncat and strncpy rather than the strcpy and friends.
2015-07-08 18:13:40 +02:00
Klaas Freitag
b8077d2f5b
FileSystem: Use long file name handling method from csync.
...
This helps to only maintain one version of the function.
2015-07-08 18:13:40 +02:00
Klaas Freitag
02a5a8ea3b
SyncJournal: Use proper long path handling.
2015-07-08 18:13:40 +02:00
Klaas Freitag
56954c6482
FileSystem: Add missing EXPORT macro.
2015-07-08 18:13:40 +02:00
Klaas Freitag
bb1b1ab7e3
FolderWatcher Win: Use proper lang path handling in folder watcher.
2015-07-08 18:13:40 +02:00
Klaas Freitag
d303df7fa0
do not use the path function here.
2015-07-08 18:13:40 +02:00
Klaas Freitag
a280007dc2
Added another test case with content in the deep path (also win32).
2015-07-08 18:13:40 +02:00
Klaas Freitag
d9b44b3a69
Created two functions c_utf8_string_to_locale and c_utf8_path_to_locale.
...
Before we only had c_utf8_to_locale, but now functionality is needed to
convert a path to UNC before converting it. That does c_utf8_path_to_locale
now, while c_utf8_string_to_locale only converts the plain string, ie.
to generate wide char strings for output.
2015-07-08 18:13:39 +02:00
Klaas Freitag
5214189eb2
Moved the makeWinLongPath function to c_path and rename to c_path_to_UNC
...
Other cleanups like streamlined allocation and more.
2015-07-08 18:13:39 +02:00
Klaas Freitag
3aed7fc0be
Removed dead code from csync_utils. Functionality moved to Qt based code.
2015-07-08 18:13:39 +02:00
Klaas Freitag
2e04eba74b
Long Win Pathes: Added test to test dir traversal with long pathes.
2015-07-08 18:13:39 +02:00
Klaas Freitag
2cce8065ab
CMocka Testing: Install the cmocka library
2015-07-08 18:13:39 +02:00
Klaas Freitag
8183c37dfe
long win pathes: Some minor refinements and documentations
2015-07-08 18:13:39 +02:00
Klaas Freitag
201d397391
CMocka tests: install the test utilities with make install.
2015-07-08 18:13:39 +02:00
Klaas Freitag
f98af43d31
Add cross platform definition for chdir and getcwd.
2015-07-08 18:13:39 +02:00
Klaas Freitag
b9b5e1cf33
Long win pathes: Make makeLongWinPath function return the num of alloc bytes.
...
This enables the calling function to free these accordingly. That is needed
because the makeLongWinPath for efficiency reasons does not always realloc
the original string.
2015-07-08 18:13:39 +02:00
Klaas Freitag
2b391396c6
vio local: Use win32 native functions to traverse the file tree.
...
Native functions to replace the not native readdir and opendir functions.
This works with long filenames now.
2015-07-08 18:13:39 +02:00
Klaas Freitag
5caff8cc93
Add a FIXME comment.
2015-07-08 18:13:39 +02:00
Klaas Freitag
599ee90500
Remove definition of TDIR, its not longer in use.
...
The directory traverse handle struct is platform dependant now.
2015-07-08 18:13:39 +02:00
Klaas Freitag
e74801fd3d
Win32 long filename format for Qt functions.
2015-07-08 18:13:39 +02:00
Klaas Freitag
2f0a404116
Unit test for the long filename conversion on win32
2015-07-08 18:13:38 +02:00
Klaas Freitag
472eed7f20
Added function to change the filename to be longer than MAX_PATH
2015-07-08 18:13:38 +02:00
Klaas Freitag
7d2bb261dc
Removed the setFileHidden function for now
2015-07-08 18:13:38 +02:00
Olivier Goffart
68668e25bd
FolderStatusModel: uses int64 for the sizes to prevent overflow
...
Issue #3420
(The change in Utility just make sure never to use the scientific notation,
even if it should never happen)
2015-07-08 14:52:58 +02:00
Olivier Goffart
e2cb6e8086
Utility: remove useless QList
...
Not used anymore
2015-07-08 11:16:32 +02:00
Olivier Goffart
d1bfc7a636
Settings: fix broken signal/slot connection:
...
No such slot OCC::GeneralSettings::slotForceRemoteDiscoveryOnFolders()
(sender name: 'OCC__IgnoreListEditor')
(receiver name: 'OCC__GeneralSettings')
The slot was in another settings page (because the button 'edit ignored files'
was moved.
Move the actual code to IgnoreListEditor where it logically belong.
Add a comment on the why this code is there.
2015-07-07 20:46:39 +02:00
Olivier Goffart
41111541c5
Confirm feature: Add an option for it
2015-07-07 16:28:48 +02:00
Olivier Goffart
f87d0139e1
AccountState: fix Sing-in of a connected account
...
Issue #3413
There was two problem:
- First, when singing in we were setting an account that was connected
to disconnected (AccountState::State)
- Second, while getting the result from the ConnectionValidator, we would
not set the state to connected if the previous call to ConnectionValidator
was ConnectionValidator::Connected, regardless of the old state of the account
2015-07-07 14:44:16 +02:00
Olivier Goffart
ceddbe248e
FolderStatusDelegate: style the Add Folder button
2015-07-06 16:04:06 +02:00
Olivier Goffart
ef1f2d2b79
FolderStatusDelegate: Fix identation and remove empty functions
2015-07-06 14:44:53 +02:00
Olivier Goffart
9c9ff886c9
Fix qt4 build
...
Qt5 automatically declares many types as QMetaType.
Qt4 needs them manually declared
2015-07-06 11:04:17 +02:00
Markus Goetz
ed0fb76cd7
Merge pull request #3404 from owncloud/fix-2702
...
Command Line: clear error hint with wrong command line options
2015-07-04 12:56:06 +02:00
Arthur Schiwon
263fa5882b
clear error hint went wrongly use command line options
2015-07-03 16:01:24 +02:00
Christian Kamm
ae69ff032b
Folders: Show as disconnected when account is disconnected.
...
Previously you could get a green folder icon even when the account
was signed out or disconnected for another reason.
2015-07-03 15:03:18 +02:00
Christian Kamm
1a58e6606c
TrayMenu: Show submenus per account.
...
This addresses the inability to sign out from one account while
keeping the other active. See #3399 , #3400 , #3379
2015-07-03 14:54:20 +02:00
