9418 commits

Author	SHA1	Message	Date
Matthieu Gallien	a7c163968a	update read-only status of virtual files when needed for lock state ... Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>	2023-08-21 12:57:16 +02:00
Matthieu Gallien	f90cb239f3	on windows file names can always be encoded: fix wrong test ... inspired by https://github.com/owncloud/client/pull/6820 Close #5935 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>	2023-08-16 10:44:37 +02:00
Claudio Cambra	d428915d35	More distinctly name server allowing resharing property ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	372cd9b9a4	Hide 'Allow resharing' checkbox when resharing not allowed by server ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	172c7ab711	Add resharing allowed property to ShareModel ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	4b3d6c5316	Make busy indicator for share permissions cover all share permission check/radio boxes ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	a344ff7c91	Add checkbox in share details page for resharing allowed setting ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	acb22b1684	Add role for resharing allowed in share model ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	c05e1920bb	Fix share permission values ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-11 22:59:59 +08:00
Claudio Cambra	812e696d53	Set modificationHappened to also depend on file size change ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	4681d27de5	Ensure file modification time is set if item modtime differs from journal modtime ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	961033efc1	Only attempt conversion to placeholder on new file if VFS enabled in SyncEngine::slotItemDiscovered ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	fe829e2693	Only change modification time if any modifications were actually made on downsynced file ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	9811d35a96	Return bool from FileSystem::setFileReadOnlyWeak depending on whether permission change was actually made or not ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	32145342c8	Unify else and if in SyncEngine::slotItemDiscovered for filesystem setmodtime check ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-07 16:25:19 +08:00
Claudio Cambra	a5d7c75e6f	Add additional logging for folder size check ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:23 +08:00
Claudio Cambra	6d56621520	Deduplicate whitelistFolderPath and blacklistFolderPath ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:23 +08:00
Claudio Cambra	a7fcb846ab	Extract folder now big activity generation into separate method ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	cbad4347bd	Extract notifying of existing folder now big to separate static method ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	e1f342c320	Declare whitelist and blacklist activity verbs as static constexprs in activitydata, refer to this in usage ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	e987fe88c5	Fix generation of context menu activity links ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	9b5391bdc1	Ensure generated activity buttons are within count set by maxActionButtons ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	af45017e94	Do not clear the whitelist on sync success ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	449bac837b	Do not always re-notify user on existing folder now big if this folder already black or white listed ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	2324a60c76	Stop current sync when existing folder becomes big and we have enabled disabling sync of folders that become big ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:22 +08:00
Claudio Cambra	bd7ccf5738	Add UI element in general settings to stop syncing existing folders that have now overcome limit ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:21 +08:00
Claudio Cambra	1342f81cab	Add config option to stop synchronising existing folders when they grow beyond size ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:44:15 +08:00
Claudio Cambra	21656cce17	Replace all manual isntancesof adding trailing slash with use of utility method ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:42 +08:00
Claudio Cambra	3b208bf838	Move trailingSlashPath convenience function into Utility class ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:42 +08:00
Claudio Cambra	ac8e9c4274	Fix trailing slash procedure in DiscoveryPhase::checkSelectiveSyncNewFolder ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:42 +08:00
Claudio Cambra	9fa5ae3604	Use simpler sort methods for white and black lists in discoveryphase ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:42 +08:00
Claudio Cambra	82f6fd5c27	Remove use of old foreach in SyncJournalDb::setSelectiveSyncList ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:42 +08:00
Claudio Cambra	1b73011f59	Constify SyncJournalDb::findPathInSelectiveSyncList ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	74c4ec88a2	Const autofy variables in ProcessDirectoryJob::processFile ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	a93279bcbf	Default to adding existing now big folders to whitelist when undecided ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	6682b3ade4	Ensure folder whitelist and blacklist helper methods remove path from other lists ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	f9bde98aad	Prevent possible accountsettings crash by sorting blacklist before checking ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	e2535d6ce8	Prevent double notification of folder now big in activities ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	5f250a5dad	Ensure newly whitelisted or blacklisted paths are removed from undecided list ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:41 +08:00
Claudio Cambra	7d1fa16a3f	Add activity for existing folder going over set limit ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:40 +08:00
Claudio Cambra	c975d40fb8	Do not create dismiss links for notifications as these are not used anyway ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:40 +08:00
Claudio Cambra	12931069c0	Create more than one converted activity link, therby respecting maxactionbuttons ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:40 +08:00
Claudio Cambra	fe59d4ec79	Ensure whitelist/blacklist procedure removes activity ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:40 +08:00
Claudio Cambra	e985367b5e	Add method to add notification activity in activity list in User ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:40 +08:00
Claudio Cambra	10989fa810	Add method to get user pointer in UserModel by AccountState pointer ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	29cc9c06f9	Handle WHITELIST_FOLDER and BLACKLIST_FOLDER verbs in activitylistmodel ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	7e17e9226b	Add convenience methods to folderman so that classes can add and remove paths from folders without needing to know which folder the path belongs to ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	2bcefd6105	Add methods to Folder so that other classes can easily add folder paths to white/blacklists ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	993ee6cb5b	Remove redundant "optional" gui log functions which relly just call gui log under the hood ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	e05cf7665a	Add specific message for existing folders exceeding warning limit in accountsettings ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	017dca2328	Move findPathInList from discoveryphase to common syncjournaldb ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:39 +08:00
Claudio Cambra	a97bdb95ee	Clean up AccountSettings::refreshSelectiveSyncStatus ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:38 +08:00
Claudio Cambra	2a4ba398e2	Do not notify about folders growing beyond threshold by default ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:38 +08:00
Claudio Cambra	83b69032ff	Ensure notify big folders checkbox state is changed when parent checkbox changes ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:38 +08:00
Claudio Cambra	61057334f6	Do not notify if setting is not enabled for folders going over limit ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:38 +08:00
Claudio Cambra	e6f5fb6382	Hook up existing folder notification size checkbox in general settings ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	b06cbf4dce	Add config settings for notifying existing folders going over limit ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	e8b82115e2	Add a checkbox in UI to obey folder size limit for existing folders ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	aa20c102b6	Properly check folder size on server ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	5acacdd4d8	Make checkFolderSizeLimit more task agnostic ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	6f2e63d52f	Create and connect specific signal for existing folder now being discovered to be big ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:37 +08:00
Claudio Cambra	10dd03f50a	Add slot for existing folders becoming big in Folder ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	ac218b000e	Use single convenience method to handle trailing slash in paths for Folder ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	5844b2763d	Check selective sync state directories that have been updated and now have differing size ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	7145d73f15	Add DiscoveryPhase::checkSelectiveSyncExistingFolder ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	e3dc6be371	Extract processServerNew into a proper method instead of large lambda ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	e5f399ff51	Move active folder size limit check to independent convenience method ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:36 +08:00
Claudio Cambra	17de46cec2	Clean up declaration of DiscoveryPhase::checkSelectiveSyncNewFolder by using const auto, renaming single letter variables, more ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:35 +08:00
Claudio Cambra	75f0e53ce6	Const autofy variables in ProcessDirectoryJob::processFileAnalyzeRemoteInfo ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-08-04 17:40:34 +08:00
alex-z	2cb03e497a	Fix review comments. ... Signed-off-by: alex-z <blackslayer4@gmail.com>	2023-07-26 16:18:39 +02:00
alex-z	7a3e43507a	Iteration. ... Signed-off-by: alex-z <blackslayer4@gmail.com>	2023-07-26 16:18:39 +02:00
alex-z	cd4b72967c	Check server's 204 endpoint every minute and restore connection immidiately after successful status code. ... Signed-off-by: alex-z <blackslayer4@gmail.com>	2023-07-26 16:18:39 +02:00
Dries Mys	243fcfedb9	Small coding improvements ... Signed-off-by: Dries Mys <dries.mys@my-dreams.be>	2023-07-26 11:05:50 +02:00
Dries Mys	fb21eb55cf	Alter testUnexpectedNonPlaceholder to better reflect the actual use case ... Signed-off-by: Dries Mys <dries.mys@my-dreams.be>	2023-07-26 11:05:50 +02:00
Dries Mys	984d06e82a	Convert VFS file to placeholder again if needed ... Note that Windows may convert a placeholder file to a regular file when it is replaced by another file, even if the old and new file (inode, modified time, file size) are identical. WIN32_FIND_DATA::dwReserved0 is only initialised in case of FILE_ATTRIBUTE_REPARSE_POINT is set. This field is not a bit set. Check corrected to only include all cloud reparse points and not other special reparse points. Signed-off-by: Dries Mys <dries.mys@my-dreams.be>	2023-07-26 11:05:50 +02:00
Claudio Cambra	b7283fa18c	Clean up declarations in activitylistmodel header, remove unused methods ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:28 +08:00
Claudio Cambra	cd56841156	Make TestingALM a friend class of ActivityListModel ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:27 +08:00
Claudio Cambra	6364c6226c	Replace unnecessary folder include in ActivityData with SyncResult ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:27 +08:00
Claudio Cambra	55fc6a1d0f	Place all sorts of sync file item status errors near the top ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:26 +08:00
Claudio Cambra	68d92e1ca7	Move activity list SyncResult errors to the top of the list ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:26 +08:00
Claudio Cambra	a5e2de7e1d	Move activity list syncfileitemstatus errors to the top of the list ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 08:40:26 +08:00
Claudio Cambra	53cc438bf1	Use QSharedPointer<T>::create for talk reply in systray.mm ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 07:14:03 +08:00
Claudio Cambra	08098b8d92	Fix spacing and indentation in systray.mm ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 07:14:03 +08:00
Claudio Cambra	91d5d9dc02	Modernise property accessing in systray.mm ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 07:14:03 +08:00
Claudio Cambra	5ecfa96d9c	Use const auto for C++ variables in systray.mm ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 07:14:03 +08:00
Claudio Cambra	fdcc623cf1	Constify object pointers in systray.mm ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-25 07:14:03 +08:00
Claudio Cambra	298a0f4dfb	Convert directly from QUrl to NSURL ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	ff1fbdacf2	Clean up declaration in SparkleUpdater header ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	70cc0bf18f	Fix localisation of updater status strings ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	892abd984b	Properly handle skipping auto update checks in the sparkle updater ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	c9275743d1	Only instantiate sparkle updater if autoupdating is available ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	5f9837b2b2	Fix qbytearray related clazy warnings in objective-c++ sparkle updater side ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	5ff0191757	Only enable check for update button when the sparkle updater is not working ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	07ac1b8c99	Implement proper notifying of sparkle updater state changes ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	73c42719b4	Also record sparkle updater state ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	5f87f6687c	Properly display status string for changes in updater ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	40f7da0106	Add ability for sparkle updater to notify UI when state has changed ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	85f8332f32	Add q pointer to SparkleInterface ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	427ed0d47d	Replace private class with an interfacing class to bridge Obj-C delegate class and owner CPP class ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00
Claudio Cambra	aa3b315c32	Name sparkle updater delegate more reasonably ... Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>	2023-07-22 11:16:39 +02:00