mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-20 12:52:06 +03:00
Code Issues Projects Releases Packages Wiki Activity
14695 commits 487 branches 258 tags 463 MiB
Commit graph

2628 commits

Author SHA1 Message Date
Kevin Ottens
b579b49a5c Get rid of redundant parentheses 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-25 20:03:01 +02:00
Stephan Beyer
f46ce2ce98 Show URL placeholder hint in wizard 
In owncloudsetupnocredspage.ui, the URL input field leUrl has a
placeholder text saying "https://..." which is a very useful hint
for the user.  However, in the OwncloudSetupPage constructor, the
placeholer text is overwritten by the return string of the theme's
wizardUrlHint() method.  The NextcloudTheme class does not override
this virtual method, so an empty string is used.

To make available the "https://..." hint, it is moved from the
UI file to NextcloudTheme::wizardUrlHint().  Note that, if a
theme is used which does not allow a custom server URL, the
placeholder text is now empty.  This makes sense because the
input field is disabled in that case.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-23 18:32:15 +02:00
Stephan Beyer
deff3230f5 Change vertical size policy of URL input field in wizard 
The input field for the nextcloud server URL is vertically too
big (because of the icon next to it in the same horizontal layout).
This commit solves this issue by changing its vertical size policy
from Ignored to Fixed.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-23 18:32:10 +02:00
Kevin Ottens
89316ced9e
Merge pull request #1987 from sbeyer/fix-leaks 
Fix a few leaks
 2020-05-21 17:12:04 +02:00
Stephan Beyer
faeb233a74 Use default member initializers in OCC::FolderStatusModel sub-structs 
This allows to remove their explicit default constructor definitions.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:45:13 +02:00
Stephan Beyer
8bc1525df5 Fix leak in Systray 
The member _trayEngine, allocated in the constructor, was leaking.

This commit sets the Systray instance as the Qt object tree parent of
the _trayEngine to fix the leak.

While at it, a few unused header includes have been removed.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:22:15 +02:00
Stephan Beyer
eaf4aa0e5b Fix leak in CloudProviderManager 
The member _map, allocated in the constructor, was leaking.

The ad-hoc way to fix the leak would have been to add a destructor
that deletes _map.  However, there is no good reason why _map has
to be a pointer to a QMap (instead of a QMap).
Hence this commit changes the type of the _map member from a QMap
pointer to a QMap.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:22:15 +02:00
Stephan Beyer
71a474129b Fix leak in CloudProviderWrapper 
The member _recentlyChanged, allocated in the constructor, was leaking.

The ad-hoc way to fix the leak would have been to add a destructor
that deletes _recentlyChanged.  However, there is no good reason why
_recentlyChanged has to be a pointer to a QList (instead of a QList).
Hence this commit changes the type of the _recentlyChanged member
from a QList pointer to a QList.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 01:22:15 +02:00
Stephan Beyer
15bdfa9fbf Use default member initializers in OCC::FolderDefinition 
Using default member initializers (available since C++11) in
OCC::FolderDefinition allows to remove its explicit default
constructor, which is favorable.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 00:56:26 +02:00
Stephan Beyer
ff192e48d0 Remove unused member in OCC::FolderDefinition 
OCC::FolderDefinition has a member called isClientSideEncrypted
that was introduced by commit 9318c487b9 but has not been used
in any way since.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
 2020-05-21 00:56:06 +02:00
Dominique Fuchs
e9a82dff77 Merge remote-tracking branch 'origin/master' into traywindow-listview-actions 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-20 10:48:46 +02:00
Michael Schuster
7804b8e006
Fix spacing 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-05-20 03:57:33 +02:00
Kevin Ottens
712869db9a Use auto to avoiding repeating type names 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-20 03:54:41 +02:00
Michael Schuster
7fd431b50f
Use the default parameter: QUrl::path(QUrl::PrettyDecoded = 0x000000) 
Change it to path() to be consistent with the other usages in the project :)

See: https://doc.qt.io/qt-5/qurl.html#path

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-05-20 02:30:45 +02:00
Kevin Ottens
dea6ebaa35 Use nullptr when appropriate 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-20 02:21:26 +02:00
Dominique Fuchs
9bfcdbae3a More code cleanupand style-preference adjustments. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-20 00:09:41 +02:00
Dominique Fuchs
aa13aa533a Removed publiclink param and corresponding if branch. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-19 23:29:59 +02:00
Dominique Fuchs
fa9dddf567 Code cleanup and this-> removals. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-05-19 23:25:21 +02:00
Kevin Ottens
3b6ab2fa5a Indicate this is a dialog and not a regular window 
This is necessary with some window managers which would otherwise
consider they can reposition and resize the tray window as they wish
(yes, even though the user can't do it directly).

This is for instance the case if you use the tiling mode scripts of
KWin. It automatically ignores dialogs but might force windows to be
fullscreen (which would badly break the layout in our case).

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-07 09:39:08 +02:00
Kevin Ottens
de7021e85e Force the default QQC2 style 
This works around a bug in KDE's qqc2-desktop-style which breaks buttons
with icons not based on a name. By forcing a style name the KDE Plasma
platformtheme plugin won't try to force qqc2-desktops-style anymore.

Can be removed once the bug in qqc2-desktop-style is gone.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-05-07 02:07:02 +02:00
Sandro Knauß
6cdae6c19e Fix typos. 
Debian has a list of known typos in their checking tools.

Signed-off-by: Sandro Knauß <hefee@debian.org>
 2020-05-04 18:11:36 +00:00
Dominique Fuchs
671961e641 Added share icon from nc server repo, changed corresp. btn icon 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-04-27 08:06:58 +02:00
Dominique Fuchs
1c21bfdd7c
Merge pull request #1922 from taaem/fix-recent-files 
Fix cloudprovider crashing - don't clear the _recentMenu pointer
 2020-04-25 13:37:29 +02:00
Dominique Fuchs
6df75328fd
Merge pull request #1893 from nicolasfella/override 
override specifier missing
 2020-04-25 12:18:56 +02:00
Dominique Fuchs
210253ce35
Merge pull request #1889 from nicolasfella/applicationengine 
Use QQmlApplicationEngine instead of QQmlEngine
 2020-04-25 12:15:33 +02:00
Dominique Fuchs
4bd5e9d79b Implemented share functionality in tray window and changed actions / button logic. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-04-25 10:17:53 +02:00
Michael Schuster
6e220b10e4
Merge pull request #1883 from nicolasfella/contexticon 
[dolphin] Add icon to context menu
 2020-04-16 02:52:34 +02:00
Michael Schuster
45342d7952
Merge pull request #1882 from nicolasfella/detach 
Fix container detaching
 2020-04-15 21:28:51 +02:00
Michael Schuster
ef42635c23
Merge pull request #1880 from nicolasfella/timeout 
Remove timeout parameter from showMessage
 2020-04-15 17:28:02 +02:00
Nicolas Fella
29fa924853 Use LINUX_APPLICATION_ID 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-04-14 21:38:33 +02:00
Tim Klocke
18615d0297 CloudProviders: Don't clear the _recentMenu pointer 
The _recentMenu pointer ref should not be freed, when building the
menu.
This fixes #1920 and #1818
 2020-04-10 23:08:07 +02:00
Nicolas Fella
b4d1a63c14 Use override 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-22 21:58:15 +01:00
Nicolas Fella
d54add6233 Use QQmlApplicationEngine 
This simplifies the code a bit.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-22 16:14:56 +01:00
Nicolas Fella
e1f4d17446 [dolphin] Add icon to context menu 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 02:04:42 +01:00
Nicolas Fella
1afda2b875 Fix container detaching 
Found by clazy

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 01:24:37 +01:00
Nicolas Fella
b84a1eeb8d Remove timeout parameter from showMessage 
It it never set by calling code so the default value of 10000 is used. It is only used in the call to QSystemTrayIcon, which uses 10000 as default value too.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 00:40:40 +01:00
Nicolas Fella
2f54e911b7 Add desktop-entry hint to notifications 
This allows the notification server to map a notification to the program's desktop file, which allows the server to do extra things. For example KDE Plasma adds the Nextcloud icon to the notification and allows to configure notifications from Nextcloud.

This is a standard hint from https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#hints

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2020-03-21 00:25:33 +01:00
Michael Schuster
102369bfbe
WebView: Add missing Q_OBJECT macros 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-11 01:18:11 +01:00
Michael Schuster
78776f81e4
Merge pull request #1847 from nextcloud/enh/updater 
Updater: Enhance UI, make build optional
 2020-03-10 15:53:47 +01:00
Michael Schuster
e833e86da6 Updater: Add CMake option BUILD_UPDATER to make the updater optional 
- Default: BUILD_UPDATER = NO

  To ease builds for distro packages and contributors (regardless of the specified update URL)

- Enable updater build for Drone CI and AppImage builds

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
c812d896aa Fix OCUpdater: Also change status on network error or invalid XML 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
c043a4e55c Updater UI: Implement auto-update option and update button 
- Add checkbox and button to UI
- Add new parameter autoUpdateCheck to ConfigFile

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 02:34:55 +01:00
Michael Schuster
555b41f300
Fix Legal notice dialog: Correct title and header font 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-09 00:41:59 +01:00
Michael Schuster
d8c407ac97
Settings dialog: Move detailed version info from About section to Legal notice dialog 
- Enlarge dialog widget to show full content
- Implement Dark-/Light-Mode switching (hyperlinks)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:45:41 +01:00
Michael Schuster
6685722cb3
Add missing --version parameter to help screen 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-07 06:20:00 +01:00
Michael Schuster
0e60bf7c82
Merge pull request #1838 from nextcloud/enh/share_circles 
Allow sharing to circles: https://github.com/nextcloud/circles
 2020-03-06 02:17:36 +01:00
Roeland Jago Douma
3776a04206
Allow sharing to circles 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-05 10:44:06 +01:00
Michael Schuster
ff642085b4
Fix Explorer pinning: Add fallbacks for Shell commands (fixes #1599) 
See: #1599

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 18:45:58 +01:00
Michael Schuster
ab1099f13e
WebFlowCredentials: Make username comparison case-insensitive (fix #1741) 
Fixes issue #1741

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 06:01:27 +01:00
Michael Schuster
aab735a595
Fix MSVC warnings: Missing return value, cast type 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-03 02:08:37 +01:00
Michael Schuster
eb7ed33d98
Merge pull request #1744 from nextcloud/qt-traygeometry-workaround 
Fix wrong window position on some linux DEs - worked around invalid g…
 2020-03-01 07:07:47 +01:00
Michael Schuster
712fef0cac
Merge branch 'master' into qml-singleton-style and fix merge conflict 
Migrate changes in client.qrc to resources.qrc

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 06:47:46 +01:00
Michael Schuster
318c749558
Merge pull request #1736 from nextcloud/resource-cleanup 
Resource cleanup and application-wide svg usage
 2020-03-01 06:11:17 +01:00
Michael Schuster
5b2877a63e
Merge branch 'master' into resource-cleanup 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:34:12 +01:00
Michael Schuster
29e02d0579
owncloudsetuppage.cpp: adapt to string change from master: url -> URL 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:32:59 +01:00
Michael Schuster
a92a764c2a
owncloudsetuppage.cpp: also rename client/theme/lock-http(s) PNGs to SVG 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 05:12:59 +01:00
Michael Schuster
40767f7ae0
Fix Explorer integration: Hide option on non-Windows 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 04:03:29 +01:00
Michael Schuster
f1dd312b2e
Fix Explorer integration re-save (fixes issue #1807) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-03-01 03:39:24 +01:00
Michael Schuster
bf838bd336
Merge pull request #1809 from sroracle/cmake-qml-quick 
Fix cmake inclusion of Qml and Quick
 2020-02-29 21:18:11 +01:00
rakekniven
b936cc1f6e
l10n: Change spelling of "webdav" 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:14:34 +01:00
rakekniven
62bc9d025e
l10n: Removed colon from translation 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:13:34 +01:00
rakekniven
961c05363a
l10n: Removed blank before colon 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:10:05 +01:00
rakekniven
3f7cd5c0f3
l10n: Change case of one word 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-24 11:08:56 +01:00
Max Rees
3d3021e3b0
Fix cmake inclusion of Qml and Quick 
Signed-off-by: Max Rees <maxcrees@me.com>
 2020-02-23 23:44:54 -06:00
Michael Schuster
9c8a0204e5
Updater: Add query-parameter 'updatesegment' to the update check 
Used to throttle down desktop release rollout in order to keep the update servers alive at peak times.

See: https://github.com/nextcloud/client_updater_server/pull/36

Targeted issues: #1795, #1800

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-21 21:28:42 +01:00
Michael Schuster
640655ea10
Code cleanup 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-14 03:00:20 +01:00
Michael Schuster
abfebcf291
Add UserInfo class and fetch quota via API instead of PropfindJob 
The PropfindJob quota includes the size of shares and thus leads to confusion
in regard of the real space available, as shown in the UI.
This commit aims to streamline the behaviour with the Android and iOS apps,
which also utilize the API.

Details:
- Refactor the QuotaInfo class into UserInfo
- Use JsonApiJob (ocs/v1.php/cloud/user) instead of PropfindJob
- Let ConnectionValidator use the new UserInfo class to fetch
  the user and the avatar image (to avoid code duplication)
- Allow updating the avatar image upon AccountSettings visibility,
  using UserInfo's quota fetching

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-02-14 02:10:01 +01:00
Dominique Fuchs
6d23ce82d7
Merge pull request #1770 from nextcloud/rakekniven-patch-1 
l10n: Changed grammar and triple dots to ellipsis
 2020-02-06 08:17:38 +01:00
Dominique Fuchs
4b8b84f2dd
Merge pull request #1759 from nextcloud/fix/do_not_save_all_the_time 
Do not save notes on text change
 2020-02-06 07:49:28 +01:00
Dominique Fuchs
e7b5cc8974
Merge pull request #1763 from nextcloud/tintou/cloudprovider-valid-dbus-path 
Make sure that the libcloudprovider integration is using a valid D-Bus path
 2020-02-06 07:17:35 +01:00
rakekniven
da66b3956e
l10n: Changed grammar 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:55:51 +01:00
rakekniven
1988511c55
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:54:32 +01:00
rakekniven
abcadec94a
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:53:17 +01:00
rakekniven
8f82fc2e51
Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:52:17 +01:00
rakekniven
f9d27e4e3b
l10n: Triple dot to ellipsis 
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-02-05 06:50:27 +01:00
rakekniven
32c2c062c0 l10n: Changed spelling of "user name" to "username" 
Using "username" like on > 200 strings over the whole Nextcloud project.

Signed-off-by: rakekniven mark.ziegler@rakekniven.de
 2020-02-03 10:42:37 +01:00
Corentin Noël
a7d6555de2 Make sure that the libcloudprovider integration is using a valid D-Bus path 
Set a simple unique identifier per folder to ensure that it is always unique.

Fixes https://github.com/nextcloud/desktop/issues/1704

Signed-off-by: Corentin Noël <corentin@elementary.io>
 2020-01-30 21:05:13 +01:00
rakekniven
dfdb872e7b Changed product name to Nextcloud 
Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-01-30 19:16:01 +01:00
Roeland Jago Douma
bd9b0cf23f Am empty note is not a valid note 
Do not show the note edit field for empty new shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-28 12:46:15 +01:00
Roeland Jago Douma
d449912a0a
Do not save notes on text change 
Only save notes on submit. Else you will get spammed with a ton of
requests (and possibly mails)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-01-28 12:09:17 +01:00
Dominique Fuchs
0697c81ae6 Rewrite of screen selection logic, plus synamic screen selection Window.qml 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 13:54:04 +01:00
Dominique Fuchs
77be6729a2 Fix also screen selection for different Qt versions and for buggy linux DEs 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 12:16:24 +01:00
Julius Härtl
baf082df7c
Use system proxy by default if no config file is present 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-01-21 11:59:07 +01:00
Dominique Fuchs
f3062f6c96 Fix wrong window position on some linux DEs - worked around invalid geometry() returned by QT 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-21 09:55:26 +01:00
Dominique Fuchs
bb757c6a27 Merge branch 'master' into resource-cleanup 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:44:59 +01:00
Dominique Fuchs
6593317afa Merge branch 'master' into qml-singleton-style 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:43:36 +01:00
Dominique Fuchs
9deb51c846 Module styling also for UserLine.qml 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:40:49 +01:00
Dominique Fuchs
3a39e636ae Introduced Style module 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-19 20:13:12 +01:00
Michael Schuster
03cddabfd0
Tray menu: Only show time ago (view too noisy) 
Don't show date and time for now, rather as a tool tip later.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-19 19:12:34 +01:00
Dominique Fuchs
d3cd422b46
Fix crash on start without any accounts 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
(cherry picked from commit 9935606c87)
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-19 14:14:23 +01:00
István Váradi
835cd2ac80 Qt 5.5 compatibility ifdef 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-01-19 13:16:17 +01:00
Dominique Fuchs
01e9343d8b Cleanup/Removal/Adaption/Update to resource files and crresponding code, esp. regarding svg usage 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-18 17:47:17 +01:00
Michael Schuster
c0863ede02
Share context menu: Use directEditing capability in SocketApi 
- Allow direct editing "Edit" when an editor is available for the mime type
- Show "Open in browser" if editing is unavailable (as previously)
  (now on top of the menu list)
- Rename the menu title to the app name, "Nextcloud" instead of "Share via ..."

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 15:12:16 +01:00
Michael Schuster
45b39cdbc1
Add support for the directEditing capability 
- Fetch in ConnectionValidator::slotCapabilitiesRecieved
- Add editors to a list made of the new DirectEditor class

TODO:
- Add support for re-fetch and continously check for changes (ETag)

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 15:07:51 +01:00
Michael Schuster
2039872ee5
Merge pull request #1565 from nextcloud/qml-tray-menu 
New tray window
 2020-01-18 13:18:45 +01:00
Michael Schuster
016a90d7b0
More code maintenance 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-18 12:56:26 +01:00
Dominique Fuchs
9b5bb1365c Code maintenance - correct some syntax, fix some warnings. 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-18 10:30:34 +01:00
Michael Schuster
de74057cc8
Add grey hint Activity entry if limit is reached 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:26:48 +01:00
Michael Schuster
e2188b109a
Limit fetching Activities to 100 or max. 30 days old 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:25:41 +01:00
Michael Schuster
3ae55c2555
AccountState: Add helper to find navigation App 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:21:42 +01:00
Michael Schuster
b47adb7aeb
Notifications bug fix: Don't init ETag response header with * 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:20:37 +01:00
Michael Schuster
889cb636d3
Add Activity date and time 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-17 20:16:20 +01:00
Dominique Fuchs
c9719f44dc Fix hover property wrongly placed in button, not MouseArea 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 16:30:27 +01:00
Dominique Fuchs
599dae0486 Inclusion of possible 'notification' type descriptions in activity 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 14:50:05 +01:00
Dominique Fuchs
1c5cdc4d36 Adapted currentId logic for activity fetching to new API (should fix endless fetch bug) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 14:29:54 +01:00
Dominique Fuchs
0156edf320 Removed visibility workaround 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 11:21:43 +01:00
Dominique Fuchs
f425dfdfea Set sourceSize to prevent blurry rerendering of svg source in activityIcon 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 10:38:21 +01:00
Dominique Fuchs
7ea2f3fa59 Refresh visibility of ListView based on presence of items on showWindow 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 09:09:42 +01:00
Dominique Fuchs
1c22070a74 Refresh immediately on showWindow, regardless of the timer 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-17 09:04:24 +01:00
Michael Schuster
9abc1eb921
Add initial support for Apps menu icon display (show remote SVGs) 
Caching and showing them from local data-URLs leaded to blurry rendering in Qt.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 18:43:48 +01:00
Dominique Fuchs
94325359d7 Fixed bug regarding additional but empty delegate at end of activitylist 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 18:01:18 +01:00
Dominique Fuchs
585094a719 Minor property hierarchy fix 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:40:47 +01:00
Dominique Fuchs
4b79c597dc Disabled animations until population glitches are fixed 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:11:08 +01:00
Dominique Fuchs
1bc8ec59aa Streamlining local sync notification/activity icons with server ones. Added fileAction logic for local sync activities 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 17:09:34 +01:00
Dominique Fuchs
b9a350e201 Minor layout adjustments 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 15:19:17 +01:00
Dominique Fuchs
cd80c749d6 Retreive and svg data from icon property url for activity entries 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 14:01:54 +01:00
Dominique Fuchs
06fdde8f1e Upgrade of NC server API usage + corresponding activity queries and properties including icon ref 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 12:43:04 +01:00
Dominique Fuchs
9f259bda27 Add check if applist rowCount() already empty to prevent assert exception 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 11:30:51 +01:00
Dominique Fuchs
246f7e9395 1px border #0082c9 around tray window 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-16 08:01:09 +01:00
Michael Schuster
7fe138330e
Double the width of the Apps menu (x starts at the Talk button) 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 00:57:49 +01:00
Michael Schuster
3488fd7c7f
Fix font sizes for "Log out" and "Remove account" and the Apps menu 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-16 00:45:31 +01:00
Dominique Fuchs
00d73a9389 Add visual separation between accountStateIndicator and avatar 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 20:11:50 +01:00
Dominique Fuchs
ddf67ff948 Preserve a 2px distance from tray border (streamlining with acount menu) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 19:28:40 +01:00
Dominique Fuchs
9b32ebdae4 Allow text to expand further if one or both buttons aren't visible 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 19:15:25 +01:00
Dominique Fuchs
0ec2291bd7 Layout adjustments & also show remote path in activitylist 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 18:44:33 +01:00
Michael Schuster
026bf02c85
App menu: Filter out Talk because we have a dedicated button for it 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 18:14:20 +01:00
Michael Schuster
42ebc7e995
Remove debug output 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 18:09:33 +01:00
Michael Schuster
b4b6366ba8
Add App list menu to Tray UI 
- Modify Window.qml and Systray to show the App menu upon clicking the App button
  on the top-right. Fall back to opening the general URL in case no apps are found.

- Introduce a new UserAppsModel in UserModel.cpp to access the fetched server Apps
  from AccountState (propagated down from the User class).

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:42:06 +01:00
Michael Schuster
7b740f5e9a
Remove setTalkCapability() from AccountState and filter for Talk upon App list building 
Since the per Account App list is now being built in AccountState's slotNavigationAppsFetched
it's easy to filter for the availability of the Talk app on the server by its ID property
upon App list building, thus eliminating the need for an extra fetch job.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:30:05 +01:00
Michael Schuster
cb328d6cea
Fetch server Apps in AccountState (moved from ownCloudGui) 
- Add a new class AccountApp to keep them in an AccountAppList
  and also save properties like ID and Icon URL.

- Clear the app list upon re-fetch to avoid endlessly growing lists
  like in the previous implementation in ownCloudGui.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-15 16:23:46 +01:00
Dominique Fuchs
b57b8cfb66 Resized add account icon, adapted layout for new size 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-15 08:01:54 +01:00
Dominique Fuchs
29138cc533 Font and icon size improvements, svg transfer to new folder 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 19:48:21 +01:00
Dominique Fuchs
c09dd9287c Fix missing trayScreen init in non-OSX clause 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 08:55:39 +01:00
Dominique Fuchs
65b47d4613 Make qml UI strings translatable 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-14 07:59:28 +01:00
Dominique Fuchs
f748a4bb50 Made tray window positioning HighDPI aware 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 22:11:57 +01:00
Dominique Fuchs
e4b19d0cb5 Activity refresh in background 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 14:35:58 +01:00
Dominique Fuchs
eeefbe57af Added progressInfo / cleanup to acitivtymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 13:10:32 +01:00
Dominique Fuchs
84066634e7 Integrated local error messages in activitymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 12:54:38 +01:00
Dominique Fuchs
9e82ba60b4 Integrated local sync activities in activitymodel 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 12:20:41 +01:00
Dominique Fuchs
96a74d9ef0 Minor improvements 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 11:46:49 +01:00
Dominique Fuchs
1ebcd3a0fb Icon selection, svg path transfers, scrollbar 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 09:59:34 +01:00
Michael Schuster
8f9101773c Fix Explorer integration on Windows and the crash on other systems 
- Ensure that the folder integration stays persistent in Explorer,
  the uninstaller removes the folder upon updating the client.
  Recreate all entries upon start. This has the benefit of removing
  old remains of non-working, outdated entries.

- Don't crash on the other systems when the user clicks the option
  button "Show sync folders in Explorer's Navigation Pane".
  Even though the option currently doesn't work on the other platforms,
  crashing is never good...

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-01-13 09:25:01 +01:00
Dominique Fuchs
17fcfd4e41 Show ListView delegate only when model is populated (prevent dummy delegate) 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 09:12:44 +01:00
Dominique Fuchs
9e6df7a4dc Add populate transition 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 08:43:51 +01:00
Dominique Fuchs
9319210c4c Fix local folder not opening on windows, add extra slash 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-13 08:33:10 +01:00
Dominique Fuchs
58f1c3234d Temperarily disabling animations due to lags - FIXME 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 21:37:08 +01:00
Dominique Fuchs
715924cac6 Show activitylist on initial tray opening when logged in 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 21:19:18 +01:00
Dominique Fuchs
163ca3b58a Removed old account toolbox 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 19:53:02 +01:00
Dominique Fuchs
1c2916052d Bunch of fixes and optimizations for activityList 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 17:52:51 +01:00
Dominique Fuchs
b76da25ef1 Model/View improvements, also fixes crash on account removal 
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
 2020-01-12 16:16:24 +01:00