Commit graph

18880 commits

Author SHA1 Message Date
Claudio Cambra
ccedff3272
Merge pull request #5416 from nextcloud/bugfix/remove-account-crash
Clean up account creation and deletion code
2023-02-14 21:18:36 +01:00
Claudio Cambra
72fb279508 More accurately log what happens when deleteAppPassword is complete in Account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
893adb8280 Remove unused slotDeleteAccount in AccountSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
7084310a9f Remove unused AccountState::writeToSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
446bb29155 Avoid trying to delete keychain encryption data if there is no encryption data configured
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
2c17305864 Add sensitiveDataRemaining convenience method to clientsideencryption
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
e7c978551d Make sure to return in checkAllSensitiveDataDeleted
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
4ded5e1b38 Don't early return in sensitive data deletion for clientsideencryption if the entries were never stored in keychain
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
8483a4553a
Merge pull request #5435 from nextcloud/bugfix/create-folders-settings-menu
Fix "Create new folder" menu entries in settings not working correctly on macOS
2023-02-14 20:13:11 +01:00
Claudio Cambra
69d73d1333 Respond to folder creation at specific creation path on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
30ce2eab02 Notify when folder is created with full folder path in FolderCreationDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
89d3022649 Do not search for folder twice
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
6c548145a2 Make sure to manually call folderwatcher when creating new folder from settings menu in macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Nextcloud bot
0e2cf63fe5
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-14 03:40:06 +00:00
Claudio Cambra
7da0c2cb78
Merge pull request #5410 from nextcloud/feature/terminal-logging
Log to stdout when built in Debug config
2023-02-13 20:47:35 +01:00
Claudio Cambra
4d9fef81c9 Log to stdout when in debug mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-13 19:59:46 +01:00
Claudio Cambra
4b380dc23a Fix indentation in logger constructor
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-13 19:59:46 +01:00
Nextcloud bot
7953d4ebc6
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-13 03:42:56 +00:00
Nextcloud bot
daa87d03a2
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-12 03:38:59 +00:00
Nextcloud bot
6eae28a935
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-11 03:38:20 +00:00
Nextcloud bot
36db9f3a12
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-10 03:45:04 +00:00
Claudio Cambra
16612d7a69
Merge pull request #5351 from nextcloud/checkTranslations
check German translation for wrong wording
2023-02-09 22:40:19 +01:00
tobiasKaminsky
711db94590
check German translation for wrong wording
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2023-02-09 22:34:02 +01:00
Nextcloud bot
475cb58cdb
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-09 03:48:19 +00:00
Camila
690bc573f6
Merge pull request #5389 from nextcloud/update/changelog
Update CHANGELOG.
2023-02-07 17:08:01 +01:00
Camila
aaac85ab72 Add CHANGELOG for 3.7.0 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Camila
5805d5f822 Add CHANGELOG for 3.6.6 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Camila
0f3669dc6a Add CHANGELOG for 3.6.5 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Camila
d6426f30c1 Add CHANGELOG for 3.6.4 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Camila
ff7e3f43ea Add CHANGELOG for 3.6.3 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Camila
1e72f70887 Add CHANGELOG for 3.6.2 release.
Signed-off-by: Camila <hello@camila.codes>
2023-02-07 13:55:08 +00:00
Nextcloud bot
7a3c2afce5
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-07 03:38:52 +00:00
Claudio Cambra
2d3cdb3d03
Merge pull request #5391 from nextcloud/bugfix/sharemodel-crash
Prevent ShareModel crash from accessing bad pointers
2023-02-06 15:05:12 +01:00
Claudio Cambra
1d525911f1
Make ShareModel's accountState and folder pointers QPointers to guard against crashes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:30:50 +01:00
Claudio Cambra
bf8cb8305e
Create common validCapabilities used by several ShareModel methods checking account capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:29:35 +01:00
Matthieu Gallien
269f8c4202
Merge pull request #5393 from nextcloud/bugfix/initValueForPointers
Bugfix/init value for pointers
2023-02-06 11:54:22 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
76e88572d6
more fixes for attributes without init value
done with clang-tidy

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
ca932fe093
init attributes
discovered at runtime using valgrind

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
b4a8981c03
initialize all variables
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
82b062d2e9
prefer initialization of attribute inline
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d21da0d3af
prefer member init
done via clang-tidy and use of modernize-use-default-member-init

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Nextcloud bot
7e2de596e9
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-05 03:35:34 +00:00
Nextcloud bot
3f627c55c8
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-04 03:39:10 +00:00
Nextcloud bot
0f4a0defb2
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-03 03:40:25 +00:00
Matthieu Gallien
69275bb447
Merge pull request #5385 from nextcloud/bugfix/issue-5383
Only accept folder setup page if overrideLocalDir is set
2023-02-02 08:44:02 +01:00
Camila
e533c6047c Update code style.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
e0c1c67306 Fix: if the config did not exist, overrideserverurl had no effect.
When the client runs for the first time, setting the value was done before
the config file was created. It had no effect.

Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
3596562101 Do not exit application when overrideserverurl param is a valid url.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00