Commit graph

8429 commits

Author SHA1 Message Date
Claudio Cambra
8267136013 Rephrase button text to be in line with clients on other platforms
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-15 12:52:12 +02:00
alex-z
300446579c Fail build when Windows tests fail. Use GH Actions to build and run Windows tests. Create coverage and uppload it to codecov.io.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-06-10 15:18:54 +03:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 11:30:16 +02:00
allexzander
d7217d1c07
Merge pull request #4622 from nextcloud/feature/generate-state-icons-from-svg
Feature/generate state icons from svg
2022-06-10 12:15:45 +03:00
Claudio Cambra
9dd9c46493 Do not compile things that require the app bundle when building the client without the app bundle on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 10:43:36 +02:00
alex-z
6ef296d823 Generate state icons from SVG in CMake.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-06-10 11:37:29 +03:00
Claudio Cambra
4bdfe59270 Fix builds on macOS versions pre-11
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-31 11:10:17 +02:00
rakekniven
276616d211 l10n: Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-30 10:12:33 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons.
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'.
Signed-off-by: Camila <hello@camila.codes>
2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-23 17:01:22 +03:00
alex-z
e40142847b Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot automatically when running from the updater.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-19 12:52:40 +03:00
Claudio Cambra
a2cc2ace4a Explicitly ask user for notification authorisation on launch
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-19 10:59:12 +02:00
alex-z
be23e747de Stretch WebView to fit dialog's height.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-18 10:57:10 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:08:37 +02:00
Valdnet
83415062ba
i18n: Change three dots to an ellipsis
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:06:20 +02:00
Claudio Cambra
2d74a5752e Fix label borking and wrong icon colours in the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 22:59:00 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Matthieu Gallien
5f6277b3ee if an exclude file is deleted, skip it and remove it from internal list
ignore files can be removed: not an error so adjust tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-16 21:00:52 +02:00
Claudio Cambra
31f3800d0d Fixed share link expiration box being ineditable and always reloading invalid date
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 18:51:12 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:53 +02:00
Claudio Cambra
364d02a13f Actually reset menu when user accounts are added or removed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:20 +02:00
alex-z
101a92faf3 Bugfix. Take root folder's files size into account when displaying the total size in selective sync dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 17:40:30 +03:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api.
Signed-off-by: Camila <hello@camila.codes>
2022-05-12 12:47:48 +02:00
Claudio Cambra
c22d5959b8 Reimplement notifications for macOS and add support for actionable update notifications
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-11 17:33:33 +02:00
Matthieu Gallien
553d324d3d only add OCS-APIREQUEST header for 1st request of webflow v1
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-10 09:39:35 +02:00
rakekniven
ad17d39817 l10n: Remove string from translation
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-06 08:48:55 +02:00
Philip Allgaier
e75f37bf2e Remove "…" from "Create Debug Archive" button
Looks like an ellipsis (as if some text is cut off), but that is not the case => clearer without the dots

Signed-off-by: Philip Allgaier <philip.allgaier@gmx.de>
2022-05-05 22:26:58 +02:00
Claudio Cambra
cdae0a56d5 Stop dumping cache data in home dir, cache in default cache location
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-05 14:31:31 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 15:12:45 +02:00
Claudio Cambra
a5019f1f8e Add some logging
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Claudio Cambra
22e42ac6d3 Fix macOS autoupdater
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Matthieu Gallien
702e9abe4b display lock info in share dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
b55a099b61 allow lock/unlock of files from files explorer integration
add new commands to the contextual menu provided by our files explorer
plugins to allow locking/unlocking a file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
2ea68d75bd add automated tests for LockFileJob to validate proper behavior
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
fcd07f26a3 introduce new jobs to handle lock/unlock of files
close #4382

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
dc95f29165 fetch and store in sync database information abot lock state of files
fetch lock properties from server

decode them and store them in sync database

test to ensure we do properly handle those properties

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
860d7dd9de detect capabilities for lock/unlock of files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
b64c077469 reformat SyncJournalDb::setFileRecord to decrease complexity
reduce the measure of branching complexity by reformatting the method

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-29 20:59:56 +03:00
Matthieu Gallien
558c6cb1f6
adjust API of retry count to have everything private and simpler
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:53:38 +02:00
Matthieu Gallien
6798f2ca31
obsolete and no longer needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:31:32 +02:00
Matthieu Gallien
a6571e2d8a
improve readability of computation of currentDelay recoonect time
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:29:45 +02:00
Matthieu Gallien
4e348db1d0
increase time between connection tries
each time we do a failed attempt to connect increase the time until the
next try

use an elapsed timer to ensure we do properly wait between each attempt

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:15:15 +02:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues.
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link.
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link.
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Matthieu Gallien
908066072a avoid deleting renamed file with spaces in name
ensure that normal sync engine will nto delete new file renamed due to
trailing/leading spaces in name

rename before upload in the same job to avoid having invalid state in
local desktop client database to ensure any subsequent run of the sync
engine will not make wrong decisions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-06 07:32:02 +00:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-05 16:41:11 +00:00
Matthieu Gallien
2a3059d779 ensure we do properly failed hydration jobs
report status when the job is in error at end of hydration request
instead of doing the opposite

properly set status in db when a file failed to hydrate (still a virtual
file not a real one)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-03 16:12:42 +02:00
alex-z
71b610eee3 Remove redundant _guiAppInstance
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-01 08:41:35 +00:00
alex-z
b34f639fff Darkmode. Fix crash on exit.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-01 08:41:35 +00:00
Camila
7cc2486d79
Address PR comments.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
9b00e5268e
Rename functions.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
a46482ca91
Fix background color so it switches with light/dark theme.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
0890a78262
Display input once user clicked on Reply.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
b2056187a0
Let qml know the message reply was sent.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
94530b6305
Rename data role.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:53 +02:00
Claudio Cambra
3d086ae305 Fix dark mode stuff relating to unified search, fix macOS auto dark/light theme switching not always working, fix Windows detection of dark/light theme switching
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-28 09:21:35 +00:00
Matthieu Gallien
99c0aadabe
ensure we only store update channel not localized in settings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-23 17:35:39 +01:00
Claudio Cambra
bbd988d8c5 Fixes to UI issues
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-20 16:32:43 +00:00
Claudio Cambra
98e297bf0b Fix for VFS crashes
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-19 23:31:24 +01:00
Claudio Cambra
c342c304ac Added dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-18 16:43:15 +00:00
Claudio Cambra
97801a5acb Fix warn colour in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-18 12:08:12 +01:00
Matthieu Gallien
dc0026704e ensure discovery phase will not try to upload files with invalid mtime
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Matthieu Gallien
d4081c99a7 prevent updating files when that would result in invalid mtime
ensure that we never try to sync a file with a sync that would result in
setting it up to an invalid mtime

test a recovery scenario with plain old sync folder and virtual files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Matthieu Gallien
b8ff1525f7 let error during update of metadata of virtual files propagate to users
errors duing update of metadata of virtual files are being ignored and
not propagated to users to be shonw in main dialog

ensure they are real errors from sync engine point of view and let them
be taken into account

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Matthieu Gallien
541447723a remove all usage of QDateTime::toTime_t() to avoid overflow
QDateTime::toTime_t() can overflow if called with a date outside its
domain of working

this method is obsolete and QDateTime::toSecsSinceEpoch() is the
replacement

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Matthieu Gallien
a7adca84e2 remove wrong assert that is blocing the run of debug client
if the server has files with invalid modtime this assert will trigger
even though the code is handling the situation

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Camila
73bae8cd30
Add TalkReply class and tests.
- Add struct TalkNotificationData to handle token and messageId.
- Handle chat and call notifications with the new struct.
- Add talk token and messageId to data roles in ActivityListModel.
- Add Talk Reply component to the ActivityList.
- User Loader to display the TalkReply component.
- Move Talk Reply from ActivityItem to ActivityItemContent due to PR #4186.
- Use TextField instead of Text.
- Disable send reply button instead of changing border color when field is empty.

Signed-off-by: Camila <hello@camila.codes>
2022-03-17 17:50:33 +01:00
Claudio Cambra
628ee10008 Implement local socket to communicate with finder extension
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-17 11:46:57 +00:00
Claudio Cambra
65f2bada3e Add thumbnails for files in the activity view
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-17 10:46:09 +00:00
Claudio Cambra
f585b8bd48 Add support for server color theming by using server color as accent
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-16 13:57:45 +01:00
Claudio Cambra
02f3a1aed6 File activity dialog now works for all file actions activities (e.g. deleted files)
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-16 08:38:14 +01:00
Claudio Cambra
ead4cc6fe3 Increase max line of text in activity item text to two
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-15 09:22:11 +00:00
Claudio Cambra
2f795df701 Ensure file activity dialog appears in centre of screen
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-13 22:11:26 +00:00
Matthieu Gallien
11e7ebd5fa properly ask Qt to create qml opengl surface with proper options
should prevent context losses error with some opengl drivers

should prevent corruptions to occur with come opengl drivers

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-10 14:19:46 +00:00
alex-z
01eb050cd8 Do not remove files from a Group folder and its nested folders whe it is renamed or removed while not allowed.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-03-09 10:54:39 +02:00
rakekniven
8aa3ab3d37
Merge branch 'master' into rakekniven-patch-1 2022-03-04 12:22:31 +01:00
Camila
2c20f81a53 Add 'Help' action back.
I think it was a mistake that caused this.

Signed-off-by: Camila <hello@camila.codes>
2022-03-03 11:16:09 +00:00
Claudio Cambra
f6b377ab17 Simplify currentScreen
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-02 13:37:30 +00:00
Claudio Cambra
655a2e1c39 No longer assume status bar height, calculate, fixing notch borking
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-02 13:22:55 +01:00
rakekniven
5045394b43
l10n: Changed spelling
Reported at Transifex.

Fix for #4004 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-02-28 18:40:26 +01:00
alex-z
bf80efc7ab Fix review comments from Matthieu. Using curent reverse iterator when searching for parent.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-02-25 15:31:26 +00:00