mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-25 14:36:01 +03:00
Code Issues Projects Releases Packages Wiki Activity
21929 commits 471 branches 255 tags 511 MiB
Commit graph

21929 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jyrki Gadinger
bdc9539048 gui: add some context for translators 
Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
 2024-09-13 09:41:37 +00:00
Matthieu Gallien
8e80ed95b2
Merge pull request #7112 from nextcloud/backport/7098/stable-3.14 
[stable-3.14] Fix building of client on macOS 10.13 and 10.14
 2024-09-12 12:44:53 +02:00
Claudio Cambra
45aa8df11a Wrap use of folder permissions restore in mac ifdefs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 12:15:40 +02:00
Claudio Cambra
d1375281a2 Wrap all uses of FileSystem::setFolderPermissions in ifdefs for macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 12:15:40 +02:00
Matthieu Gallien
8d58e9bf1e
Merge pull request #7114 from nextcloud/backport/6970/stable-3.14 
[stable-3.14] Make sure we do not renotify notifications when we have received the same etag as during the last check
 2024-09-12 12:15:19 +02:00
Claudio Cambra
4417d98c26 Notify even if pre-fetch etag header is empty 
This prevents situations where the server does not provide an etag header. This would make the empty pre-fetch and empty post-fetch etag headers match, meaning notifications would never be notified

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 08:54:00 +00:00
Claudio Cambra
410e80b423 Make sure we do not renotify notifications when we have received the same etag as during the last check 
Do this regardless of what the server's response is

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 08:54:00 +00:00
Matthieu Gallien
78a7256036
Merge pull request #7110 from nextcloud/backport/6960/stable-3.14 
[stable-3.14] Feature/macos vfs locking
 2024-09-12 10:16:05 +02:00
Claudio Cambra
44f640a330 Signal enumeration of locked/unlocked file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
bda7d45a6b Do not provide items if account is not set up correctly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
71454fc40e Display checkmark when file lock completed 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
820fbbd3c3 Fix NSExtensionFileProviderActionActivationRules for locking menu items 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
ec8b65c248 Add warn image to locking view if there is an error 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
6d87b210c3 Fix internal layouting of lock view by simply using a nsview rather than fumbling with a stack view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
51fba996cb Fix XIB initialisation in LockViewController 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
e805993b9f Fix file lock server url in lockviewcontroller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
8533fdd4a0 Make sure not to check for kit before we should in shares table view data source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
bcbfdc942e Once finished locking/unlocking, stop loading indicator 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
4db6f8c2ed Pull out error handling from completionHandler for nckit lockunlock 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
cce98f1e84 Stop loading indicator when presenting error 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
c5be665ce0 Add convenience function to stop/hide loading indicator in lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
2b7734ac4d Perform lock/unlock procedure in lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
72ec0d5f1f Process target item on init of lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
7cd50005c2 Add method to simply provide file details in locking view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
70d0c74b84 Add convenience method to present and log errors in lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
58586e84ac Move item metadata fetch into util file in FileProviderUIExt 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
9ccbf3f2c5 Move service connection fetcher method into a utils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
1b2fc0e034 Add close action to lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
515cc5c96c Design lock view in file provider ui 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
86a741bc40 Add basic properties to lock view controller 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
954b6ca942 Handle new locking action identifiers in document action view controller of FileProviderUIExt 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
b975b2dfa1 Add lock/unlock actions in FileProviderUIExt info plist 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
3a983c22bf Add basic LockViewController components 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Claudio Cambra
3c4d6bda2f Move all sharing components for FileProviderUIExt into a Sharing folder 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 10:15:58 +02:00
Matthieu Gallien
c79ca8ce71
Merge pull request #7109 from nextcloud/backport/7102/stable-3.14 
[stable-3.14] Bugfix/fix one rename issue
 2024-09-12 10:15:26 +02:00
Matthieu Gallien
2f48389ed0 improve some log that are produced during discovery 
would be usefull to track bugs during rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 10:15:16 +02:00
Matthieu Gallien
a0982ca6d4 avoid wrong tracking of renamed folders during discovery 
ensure server rename operations are tracked as server rename operations

ensure local rename are tracked as local rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 10:15:16 +02:00
Matthieu Gallien
831f3430ab add automated tests for complex move scenario 
we rename the top folder and we rename a not direct child that is also
moved to another folder below the original renamed top folder

so
a/b/c
a/b/d/file

will be
e/b/c/f/file

with
a -> e
d-> f

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 10:15:16 +02:00
Matthieu Gallien
724aa0133d
Merge pull request #7108 from nextcloud/backport/7061/stable-3.14 
[stable-3.14] Bugfix/delete read only remnants folders
 2024-09-12 10:14:53 +02:00
Matthieu Gallien
1d9080a7e5
delete invalid folders and restart sync automatically 
users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 09:57:41 +02:00
Matthieu Gallien
27189bf4b1
let FileSystem::removeRecursively be able to delete read-only folders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 09:57:41 +02:00
Matthieu Gallien
5b8144f806
detect remnants read-only folders to delete: try to delete them 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 09:57:40 +02:00
Matthieu Gallien
ab2002596e
let cancel sync and finish sync lambda be reusable methods 
will enable implementation of other ways to interrupt sync after
discovery to get user feedback

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 09:57:40 +02:00
Matthieu Gallien
80793bbfff
collect remnant read-only folders during discovery 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-09-12 09:57:29 +02:00
Tobias Kaminsky
5b504a723f
Merge pull request #7105 from nextcloud/backport/7103/stable-3.14 
[stable-3.14] Code-sign client via mac-crafter so it may pass notarisation
 2024-09-12 07:19:38 +02:00
Claudio Cambra
7afa393844 Move building into separate subcommand, add subcommand just for codesigning 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 05:17:36 +00:00
Claudio Cambra
a5c208a453 Always move final product to product path in mac crafter 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 05:17:36 +00:00
Claudio Cambra
f5ed1f29a7 Fix codesigning of qtwebengine related helper app in mac crafter 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 05:17:36 +00:00
Claudio Cambra
12ba22f5c6 Use deep codesigning by default in mac crafter 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 05:17:36 +00:00
Claudio Cambra
0c8ffdb49f Make sure to code-sign all binaries in app bundle 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-09-12 05:17:36 +00:00