Claudio Cambra
d3eefee25a
Replace custom moveToTrash solution with Qt QFile::moveToTrash
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-21 00:07:59 +08:00
Claudio Cambra
a14f5bc90e
Merge pull request #5666 from nextcloud/bugfix/svg-provider-error-fix
...
Fix SVG rendering error in SvgImageProvider
2023-07-20 18:02:20 +02:00
Claudio Cambra
ed05436ea5
Remove empty statement, standalone semicolon
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:53:29 +08:00
Claudio Cambra
74d1629ad9
Extract custom color svg image finding into separate function
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:53:29 +08:00
Claudio Cambra
1284749d70
Simplify findSvgFilePath, define result value on definition
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:53:28 +08:00
Claudio Cambra
c42cb28741
Merge pull request #5717 from nextcloud/bugfix/better-password-gen
...
Fix password generation for shares, improve generator
2023-07-20 17:51:38 +02:00
Claudio Cambra
9df47cf1cc
Simplify loop to write bytes to password
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:28 +08:00
Claudio Cambra
4c8007e461
Use std::array to store hash bytes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:28 +08:00
Claudio Cambra
b404f1a546
Replace use of std::rand with improved C++11 random
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:28 +08:00
Claudio Cambra
f9ded784b5
Guarantee that the generated password for share will have all the types of characters needed to pass server check
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:28 +08:00
Claudio Cambra
32acf504cb
Simplify password generation in sharemodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:28 +08:00
Claudio Cambra
c4d1bdf46f
Generate better passwords for shares
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:32:27 +08:00
Claudio Cambra
bb87813a40
Merge pull request #5659 from nextcloud/bugfix/expire-date-set-share-view
...
Fix expire date field in Share settings
2023-07-20 17:21:50 +02:00
Claudio Cambra
d0e8e67c72
Track invalid input in ShareDetailsPage expireDateSpinBoxTextField
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:17:30 +08:00
Claudio Cambra
00ec93f031
Add ability for NCInputTextField to display red border when invalid input provided
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:17:29 +08:00
Claudio Cambra
da7d8c1f0a
Ensure the text for the expire date spin box is updated even in situations when the expire date is forced back down to the same one being currently held
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:17:29 +08:00
Claudio Cambra
aaeaad9918
Make sure to imperatively set text for spinbox textfield after user breaks binding by editing
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:17:29 +08:00
Claudio Cambra
e84a5dcb5f
Rename "moreMenu" ColumnLayout to "scrollContentsColumn" in ShareView, stop treating like menu which it used to be
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-20 23:17:29 +08:00
Matthieu Gallien
6f4e2dd303
Merge pull request #5890 from m7913d/fixCantUpdateNonExistingPlaceholder
...
Create placeholder while dehydrating if needed
2023-07-20 16:46:22 +02:00
Dries Mys
9256417612
Create placeholder while dehydrating if needed
...
When replacing an OnlineOnly file by another one, the file maintains it
OnlineOnly pin state, but it is converted to a regular file. So, the
dehydration should convert the regular file to a (dehydrated)
placeholder instead of trying to update the (non-existing) placeholder.
Closes #4274
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
2023-07-20 15:07:46 +02:00
Matthieu Gallien
759c2a246c
Merge pull request #5853 from m7913d/ignoredFilesExcludedPinState
...
Set VFS PinState to Excluded for ignored files.
2023-07-20 15:01:53 +02:00
Dries Mys
55f27cdb96
Small coding improvements
...
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
2023-07-20 13:44:55 +02:00
Dries Mys
e9aa97682c
Remove warning when querying pin state on non-placeholder file
...
F.ex. Folder::slotWatchedPathChanged calls this function on non-
placeholder files to check if the ignored file is already assigned an
Excluded pin state. Note that it is allowed to set the pin state to
Excluded on non-placeholder files.
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
2023-07-20 13:44:55 +02:00
Dries Mys
76376aa052
Set VFS PinState to Excluded for ignored files.
...
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.
Closes #5524
Closes #5594
Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
2023-07-20 13:44:55 +02:00
Nextcloud bot
7524853561
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-20 02:35:26 +00:00
Nextcloud bot
2579af56e1
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-19 02:35:31 +00:00
Claudio Cambra
1f9329c4fd
Merge pull request #5885 from nextcloud/bugfix/sharing-api-disabled-share-view
...
Disable share view completely when server does not support/has disabled file sharing
2023-07-18 15:58:13 +02:00
Claudio Cambra
d6125ca3a1
Swap folder nullness assert for return
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
c1b2e07e8c
Compress share page tab button width and height when sharing API is disabled
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
bccdb0e8f7
Make swipeIndex properties readonly
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
98ec8ff302
Fix background of tabbar in file details page
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
3fda519050
Do not handle setting page to sharing page if sharing not available
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
ea5397865d
Do not display sharing entry if sharing is not available on server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
4bcff7d991
Set sharingAvailable property in FileDetails from Folder account capabilities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Claudio Cambra
38d82dfb5f
Add sharingAvailable property to FileDetails class
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-18 15:49:17 +02:00
Matthieu Gallien
c6436c4c46
Merge pull request #4977 from tomdereub/patch-1
...
windows reserved word silently excluded - csync exclude.cpp
2023-07-18 14:32:23 +02:00
tomdereub
6aacf4ddac
Adapt test 2
...
Signed-off-by: tomdereub <pbtom@lamonerie.net>
2023-07-18 10:57:17 +02:00
tomdereub
d353f08be2
Adapt test to silent exclusion
...
Signed-off-by: tomdereub <pbtom@lamonerie.net>
2023-07-18 10:57:17 +02:00
tomdereub
39e59a1c79
windows reserved word silently excluded - csync exclude.cpp
...
Proposal to solve https://github.com/nextcloud/desktop/issues/3826 , by excluding silently windows reserved word like $RECYCLE.BIN.
Signed-off-by: tomdereub <pbtom@lamonerie.net>
2023-07-18 10:57:17 +02:00
Matthieu Gallien
871812d346
Merge pull request #5879 from nextcloud/bugfix/fix-incorrect-seen-chat-notifications-removal
...
Fix crash and incorrect implementation of seen chat notofications removal
2023-07-18 10:56:31 +02:00
Matthieu Gallien
5991e780f5
try to force use of python 3.8 for windows as required by craft
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-07-18 09:57:14 +02:00
alex-z
6ea828936f
Fix crash in _finalList removal loop. Fix incorrect implementation of seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-07-18 09:57:13 +02:00
Nextcloud bot
dec95970e7
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-18 02:34:16 +00:00
Matthieu Gallien
5ab548324e
Merge pull request #5848 from nextcloud/feature/detect-captive-portal
...
Added new state and new job to check if /index.php/204 is being redirected
2023-07-17 12:21:38 +02:00
alex-z
71f1d1aad4
Added new state and new job to check if /index.php/204 is being redirected.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-07-17 11:31:15 +02:00
Nextcloud bot
6c12a221ff
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-17 02:32:21 +00:00
Nextcloud bot
6ad8e0422f
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-16 02:34:35 +00:00
Nextcloud bot
36832f4feb
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-15 02:33:50 +00:00
Nextcloud bot
360c127ad8
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-07-14 02:37:15 +00:00
Joas Schilling
a51103ce39
Merge pull request #5886 from nextcloud/ci/sign-drone-master
...
chore(CI): Sign .drone.yml file
2023-07-13 13:20:59 +02:00