Commit graph

21281 commits

Author SHA1 Message Date
Claudio Cambra
ef08c5eb4e Only show successful debug archive creation dialog if it has indeed been successful
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:16:53 +02:00
Claudio Cambra
ef2423da53 Prevent crash on creating debug archive in non-writeable location
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:16:53 +02:00
Claudio Cambra
2323b843f0 Give debug archive save location dialog a default location
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:16:53 +02:00
Claudio Cambra
64b7282bd4 Re-run update sync paused state slot when folder list has changed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:15:13 +02:00
Claudio Cambra
d3aa7f8f51 Make sure to emit syncIsPausedChanged in syncIsPaused setter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:15:13 +02:00
Claudio Cambra
ccf6b5abe1 Make sure to emit relevant signals and set sync is paused to true if relevant
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:15:13 +02:00
Claudio Cambra
d497e265df Extract syncIsPaused initialisation into new updater slot
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:15:13 +02:00
Claudio Cambra
92f6de9ca9 Always correctly set values for all fields in File Provider sharing UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:12:56 +02:00
Claudio Cambra
1c84b832fe Fetch macOS VFS package in autoupdater if the client is using the file provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:11:41 +02:00
Claudio Cambra
591d5eebd2 Prevent use of invalid characters for file provider domain names
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:11:11 +02:00
Claudio Cambra
8f6c19e029 Fix "false" error about bad applying of nodiscard to value type
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 19:10:40 +02:00
Matthieu Gallien
510b3edc3c
Merge pull request #6606 from nextcloud/bugfix/doNotImplicitlyHydrateFilesDuringSync
do not cause implicit hydration of virtual files during sync
2024-04-23 18:28:34 +02:00
Matthieu Gallien
2141ccdb7d do not cause implicit hydration of virtual files during sync
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 18:28:25 +02:00
Matthieu Gallien
5450552339
Merge pull request #6621 from nextcloud/bugfix/fixMsgVfsState
if a virtual file change but nothing changed: set it as in sync
2024-04-23 18:04:48 +02:00
Matthieu Gallien
1522d01d5b if a virtual file change but bothing changed: set it as in sync
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it

in that case, we will let the sync engine go over it and decide what to
do

it is then possible in that case that we would just put it back in "in
sync" state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 18:04:35 +02:00
Claudio Cambra
03fe6494e4
Merge pull request #6670 from nextcloud/bugfix/dav-user-fileprovider
Use davUser instead of direct credentials user in file provider
2024-04-23 23:55:33 +08:00
Claudio Cambra
80afd8e737
Use davUser instead of direct credentials user in file provider
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-23 22:24:20 +08:00
Matthieu Gallien
c0af76ca5f
Merge pull request #6663 from nextcloud/bugfix/editLocallyShouldWorkForAllMachineUsers
create registry keys needed for edit locally in local machine category
2024-04-23 14:49:03 +02:00
Matthieu Gallien
06c2fecbe1 create registry keys needed for edit locally in local machine category
creating the registry keys via installer for the current user is not
enough to have the feature enabled for all user accounts on a given
machine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 13:48:14 +02:00
Matthieu Gallien
23772f18e0
Merge pull request #6622 from nextcloud/ci/endToEndTests
improving end-to-end tests
2024-04-23 13:44:43 +02:00
Matthieu Gallien
cd924de9d3
improving end-to-end tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 12:21:10 +02:00
Matthieu Gallien
dd8a16f9d6
improving end-to-end tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-04-23 12:21:09 +02:00
allexzander
f40b8ae198
Merge pull request #6655 from nextcloud/bugfix/folder-conflict-disappear
Bugfix/folder conflict disappear
2024-04-23 12:18:25 +02:00
alex-z
b52906a8a6 Fix tests failure. Refactoring.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
alex-z
f490989a1a Fix CI errors.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
alex-z
9ae60258e1 Unit tests for diverse conflicts in one folder.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
alex-z
57f6c7cda2 Also support nested folder scenarios.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
alex-z
d2bfb59d6a Bugfix. Folder invalid char conflict. Do not update parent folder record if it contains conflicted subfolders.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
alex-z
d240ed9d50 Bugfix. Folder case clash conflict. Do not update parent folder record if it contains conflicted subfolers. Also fix crash with local rename.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-04-23 12:18:12 +02:00
Nextcloud bot
f4acb5099f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-23 02:43:21 +00:00
Matthieu Gallien
b7dd6ff748
Merge pull request #6596 from pyromaniac2k/master
Fix tests
2024-04-22 16:08:38 +02:00
Thomas Witt
a5a31321f8 UserStatusDialog.cpp: Fix timezone
This test fails on the day before a timezone switch:
   Actual   (model.clearAtDisplayString()): "23 hours"
   Expected (tr("1 day"))                 : "1 day"

Setting the timezone to UTC remedies this problem.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
2024-04-22 09:47:49 +02:00
Thomas Witt
d0097ce25c SyncConfilctsModel test: use FakeAccountState
Using the real account state needs an internet connection.

Additionally, `example.de` is a valid existing domain, which should
probably not be used in testing. Switching to `example.com` as this is
recommended here.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
2024-04-22 09:47:49 +02:00
Thomas Witt
8a9de185a9 pushnotification testutils: Bind only to LocalHost
LocalHost is enough to complete the tests, and it enables the test to be
run under networksandboxing.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
2024-04-22 09:47:49 +02:00
Nextcloud bot
1cb798b6c7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-22 02:42:25 +00:00
Nextcloud bot
0aea31d877
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-20 02:48:12 +00:00
Nextcloud bot
0203b5423f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-19 02:43:07 +00:00
Claudio Cambra
fcb5380437
Merge pull request #6648 from nextcloud/bugfix/fp-sharing
Fix possible issues with item metadata acquisition required for macOS VFS file sharing
2024-04-18 13:13:03 +08:00
Claudio Cambra
b80afca177
Wrap access of itemUrl in security scoping
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 04:56:31 +08:00
Claudio Cambra
59928a6c33
Explicitly set bundle name and identifiers from env vars in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 04:56:31 +08:00
Claudio Cambra
96f1ba656f
Unify FileProviderUIExt entitlements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 02:26:49 +08:00
Claudio Cambra
19cf69ccd3
Make sure network error is shown in UI instead of generic error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 02:07:48 +08:00
Claudio Cambra
ac1b11708f
Improve logging across file provider sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-18 01:58:38 +08:00
Claudio Cambra
a899fe19fa
Merge pull request #6632 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.11.0
Build(deps): Bump cpp-linter/cpp-linter-action from 2.10.2 to 2.11.0
2024-04-17 17:22:26 +08:00
dependabot[bot]
75020c03ce Build(deps): Bump cpp-linter/cpp-linter-action from 2.10.2 to 2.11.0
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.10.2 to 2.11.0.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.10.2...v2.11.0)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-17 17:06:43 +08:00
Claudio Cambra
aeca31af97
Merge pull request #6642 from nextcloud/bugfix/file-provider-testing
Make use of NextcloudFileProviderKit in File Provider Module
2024-04-17 16:21:16 +08:00
Claudio Cambra
f0f995c260
Pin NextcloudFileProviderKit version to 0.9.0 (up to next major version)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:18:17 +08:00
Claudio Cambra
dff6428a75
Remove now-unneeded Realm dependency from FileProviderExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:17:42 +08:00
Claudio Cambra
77f9096538
Set changeobserver as delegate for nkcommon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:15:05 +08:00
Claudio Cambra
5977a7c92d
Remove client-side push notification handling for file provider extension in favour of simply using NCFPK remote change observer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-04-17 16:15:05 +08:00