Commit graph

2533 commits

Author SHA1 Message Date
Claudio Cambra
719a8f38bf Use material icons for lock and state-info
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
ef97200ac0 Show tick icon when encryption is enabled for account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Matthieu Gallien
60566eec00 fix regressions on pinState management when doing renames
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-24 15:26:15 +01:00
Matthieu Gallien
361db77d3c fix many errors when querying/setting pin state of virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-22 15:44:43 +01:00
Matthieu Gallien
a00ec1aaa5 when renaming a virtual file, manage pin state for the target name
will avoid trying to set a pin state for a file that has just been
renamed by us

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-22 15:08:46 +01:00
Matthieu Gallien
1af2467e45 update mtime on modified metdata of non virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-22 15:08:46 +01:00
allexzander
6affc6e6ab Implement 'Leave this share' context menu entry. Fix incorrect sharing state for incoming and my shares in custom state icons and local database.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-22 12:14:20 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
Matthieu Gallien
ad32bc7ce5
remove a few warnings reported by sonarcloud to tidy the code
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 09:19:03 +01:00
Matthieu Gallien
37c867bf30
tidy code to fix review comments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 09:11:41 +01:00
Matthieu Gallien
2742c6a5a1
tidy code by fixing one clazy reported warning
use QString::arg with multiple parameters because that is faster

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:48:51 +01:00
Matthieu Gallien
9a2f07d53b
fix behavior of folder rename with deep hierarchy inside it
propagate renaming of parent folders to child recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:01 +01:00
Matthieu Gallien
d36b2ee793
improve logging of discovery policy decisions when scanning folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:00 +01:00
Matthieu Gallien
686f78bebc
improve logging of the discovery policy when scanning a folder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:00 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 09:57:54 +01:00
Matthieu Gallien
402d959cae do not skip folder deletion if BlacklistedError during propagation
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)

let's not skip them but rather keep track of the error status and
properly report them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
f8fc720fbb improve logs of E2EE API to not pollute logs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
7fe6a3df78 logs from discovery are now namespaced by nextcloud to show debug logs
use nextcloud namespace for discovery logs as it does not show correcly
without that

this is because we have central rules for all logs from nextcloud
namespace

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
9a06128eec remove dead code related to item renaming
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
alex-z
ba9d3269e3 Use separate variable for cfg file name in CMAKE.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-07 11:05:27 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-01 09:18:28 +01:00
Claudio Cambra
48359408ea Remove unneeded parameter from CleanupPollsJob constructor
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 16:00:03 +02:00
Claudio Cambra
421f5e723a Clean up methods in sync engine
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 11:05:46 +02:00
Matthieu Gallien
b9d4e7045e fix review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
7ffbd95636 fix more sonarcloud issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
5e81ab821e fix more issues reported by sonarcloud
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
b19b69df02 remove useless lines: fix review comment
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
cd30d3645e fix review comments from sonarcloud static analyzis
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
8ea75f4967 address review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
1ec7774e2f validate certificate for E2EE against private key
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Claudio Cambra
359627007b
Display the user's 'pretty' name in the webflow credentials
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:44 +02:00
Matthieu Gallien
615c02e3d3
makes JsonApiJob share common code with SimpleApiJob
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:01:36 +02:00
Matthieu Gallien
580f512c94
introduce a very simple network job to do API requests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:01:36 +02:00
Matthieu Gallien
74f35191e0 do not ignore return value
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 21:54:38 +02:00
Matthieu Gallien
a096bbd1ff ensure we do not loose data when syncing locked files
fixes #5014

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 16:01:58 +02:00
allexzander
4930531949 Command-line client. Do not trust SSL certificates by default, unlss '--trust' option is set.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-11 09:43:31 +03:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-04 18:32:51 +02:00
Claudio Cambra
2f571337f1 Ensure we are checking lock state without affecting sync behaviour
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
80d0245acb Unschedule previously scheduled sync runs for locked files if it is found the sync run is no longer needed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
bbbfe3f1c4 More efficiently schedule sync runs for files that need delayed sync runs
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
fd332a52e2 Fix files not unlocking after lock time expired
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 10:23:24 +02:00
Matthieu Gallien
9f1b6c261d alway use constexpr for all text constants
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:42:01 +02:00
Claudio Cambra
9781e896a1 Improve the error box QML component
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 12:14:37 +02:00
alex-z
225c2dda4c Bring back .lnk files on Windows and always treat them as non-virtual files.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-27 10:12:03 +03:00
Claudio Cambra
f71ddc4d43 Add a sortedactivitylistmodel that automatically handles sorting of activities
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 18:18:28 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 12:10:38 +02:00
allexzander
b40c2dfe01 Revert "Remove behavior changes."
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00