mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-22 13:44:34 +03:00
Code Issues Projects Releases Packages Wiki Activity
18950 commits 486 branches 258 tags 464 MiB
Commit graph

3803 commits

Author SHA1 Message Date
Claudio Cambra
e723b75919 Make 'Add another link' button less prominent 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
5e0a2672fb Make unshare button less prominent, move out of bottom button box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
4d837bd027 Set main file details page as initial item of stack view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
79ec0e9748 Match design of expire date spinbox to other text fields 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
cfccd02a26 Improve layout of share details page 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
046f8ea910 Convert share details menu into a page pushed onto stackview 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
e42188274c Add stackview to file details view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
31876926ac Only request mnemonic when user explicitly wants to enable E2EE 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:12:37 +01:00
Claudio Cambra
cc159e0117 Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-08 13:07:55 +01:00
Claudio Cambra
1cf2b59be2
Fix BasicComboBox internal layout, take proper account of insets 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-08 12:21:28 +01:00
Matthieu Gallien
2c94490b9c
do not create GUI from a random thread and show error on real error 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-08 10:58:58 +01:00
Claudio Cambra
135cab152b Format some QLabels as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 17:18:57 +01:00
Claudio Cambra
58f91072a5
Remove redundant openUrl variable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:48:51 +01:00
Claudio Cambra
7eb31c31e5
Fix loss of integer precision in parameters for fileLockTimeRemainingMinutes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:47:48 +01:00
Claudio Cambra
1b5b30d222
Make fileLockTimeRemainingMinutes a static method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:46:21 +01:00
Claudio Cambra
4e508d0276
Run locking procedure on main thread, open file after file has been locked remotely 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:32 +01:00
Claudio Cambra
d3fa0066d0
Ensure we are using up-to-date item ptr instead of potentially un-update file record when checking lock state in fileLockSuccess, separate case with lock already pre-existing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:32 +01:00
Claudio Cambra
6dbdcccb0f
Ensure we are using folder relative paths for synced folders that are not root to work correctly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
3f20f192e9
Ensure we are checking lock state once file has been synced after setting lock 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
10746d8441
Notify user when file is locked when local editing begins 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
ff6ab38826
Lock file when editing locally 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
alex-z
838817239a Fix CI errors for Edit Locally. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 15:31:24 +01:00
alex-z
b673ab996e Edit locally job will only sync a specific file by modifying the state of the Sync Engine. All other running syncs will get terminated. Syncing is now optimized to run faster and it checks if the file has changed on the server before syncing it. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 09:37:03 +01:00
Claudio Cambra
2ec1da22ed Remove now redundant use of textFormat 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Claudio Cambra
6c4070e786 Introduce EnforcedPlainTextLabel, convert all Label or Text labels to use this 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Valdnet
e2ff8715f4 l10n: Correct spelling 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-12-01 15:33:15 +01:00
Claudio Cambra
00fcb6e01d Ensure more QML text components are rendering things as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 14:20:15 +01:00
Claudio Cambra
83fd752981 Address capitalisation of End-to-end 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 11:50:18 +01:00
Claudio Cambra
70468be5e5 Differentiate between E2EE not being enabled at all vs. E2EE being enabled already through another device in account settings message 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 11:50:18 +01:00
Claudio Cambra
0262c77d27 Remove close/dismiss button from encryption message 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-28 18:24:40 +01:00
Claudio Cambra
a243f7c4d1 Prevent bad encrypting of folder if E2EE has not been correctly set up 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-28 17:48:53 +01:00
rakekniven
5353f4f92d l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-11-28 14:37:24 +01:00
Claudio Cambra
2459a3a9f3 Rename 'Enable encryption' button to 'Setup encryption' 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
5a0d253187 Fix capitalisation of End-to-end 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
719a8f38bf Use material icons for lock and state-info 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
f6687c491d Change the colour of the encryption message box when encryption enabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
c1d6482c69 Add info icon when encryption not yet enabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
ef97200ac0 Show tick icon when encryption is enabled for account 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
89a66a98d8 Clearly tell user that E2EE has been enabled for an account 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
d24a40012e Fix bad custom button alignments, sizings, etc. 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 17:46:20 +01:00
Claudio Cambra
9a01480fcc Fix tray window margins, stop cutting into window border 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 15:02:37 +01:00
Claudio Cambra
53abfb4785 Add an end to end test utils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-23 08:40:46 +01:00
allexzander
6affc6e6ab Implement 'Leave this share' context menu entry. Fix incorrect sharing state for incoming and my shares in custom state icons and local database. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-22 12:14:20 +01:00
Matthieu Gallien
26fd4d2226 tidy some loop related code: avoid one letter variable names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings 
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Claudio Cambra
58660b82f8 Ensure forcing a folder to be synced unpauses syncing on said folder 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 12:32:13 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings· 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:51:39 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:48:24 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
hefee
14292ec867 Fix typo of connector 
Signed-off-by: hefee <hefee@debian.org>
 2022-11-14 09:43:36 +01:00
tnixeu
d0d666d084 exclude kmessagewidget.cpp and wheelhandler.cpp from unity build 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
e3adb90d60 skip unity build for files which fail to compile 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 17:39:28 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 16:29:21 +01:00
alex-z
4b6ce9f951 Do not use copy-assignment of QDialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-09 16:01:17 +01:00
Claudio Cambra
31a89c68d7 Fix share delegate button icon colors in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 17:33:25 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 16:32:04 +01:00
Claudio Cambra
161ed1ec9b Remove unused app pointer in CocoaInitializer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 15:43:25 +01:00
Claudio Cambra
e45a023961 Remove unused internal link widget from old share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-03 14:03:38 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-01 09:18:28 +01:00
Claudio Cambra
d79312b2f7
Change liveDialog to nullDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:13 +01:00
Claudio Cambra
7ba6969e65
Moved all server mocking code for share model test to independent ShareTestUtils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:10 +01:00
Claudio Cambra
e021f25634
Add a suite of tests for ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
f97f39375b
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
de0831c297
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
ec3c361c89
Show password set errors in the popup where passwords are set rather than in the main dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
d92bc91bdf
Improve share view tab buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
eda0328e9c
Change 'Link share' to 'Share link', matching server 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
6adefb572a
Improve flat buttons in share delegates 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
7971789112
Add a file details window/page, QMLify file sharing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:03 +01:00
Matthieu Gallien
1dbdd8853f
add mising namespace 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-31 12:23:52 +01:00
Matthieu Gallien
521054dbf0
use new public API to open an edit locally URL 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-31 10:28:47 +01:00
Claudio Cambra
09997b189f Only show Sync Now button if account is connected 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 15:54:19 +02:00
Claudio Cambra
ff3eab1275 Modernise QString-related construction 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
b4be56c267 Add braces to all if statements missing them 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
7d05d8471b Expand use of const and auto, improve readability of accountsettings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
72e154def1 Rename EditLocallyHandler to EditLocallyJob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
ee8b12009a Ensure the checkTokenJob object gets deallocated 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
ae12519dd5 Show edit locally loading dialog sooner, improve feedback for user 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9f7a699ad9 Refactor edit locally handler management away from application and into own class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
4b6fdcc550 Don't show the user any potenitally questionable remote data 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9438d3f1c7 Verify token before checking disk or modifying state 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9a00aa6e66 Refactor edit locally into its own class, rather than bolting onto FolderMan 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
224621bb85 Refactor large editFileLocally FolderMan method into smaller, clearer separate methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
734c986cd1
Use addQueryParams for checkTokenForEditLocally SimpleApiJob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:46 +02:00
Claudio Cambra
0b33ce2b40
Make sure to check relPath and compare to canonical cleaned path 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:18 +02:00
Claudio Cambra
0c6127de44
Make sure to encode the relPath 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:14 +02:00
Claudio Cambra
8683ee08e7
Validate edit locally token before sending to server 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:37:26 +02:00
Claudio Cambra
16532375da Fix macOS autoupdater settings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-27 14:30:33 +02:00
Claudio Cambra
a537df296b
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-26 13:28:24 +02:00
Claudio Cambra
c0baf5c93c Add a 'Sync now' button to the sync status header in the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
94b45d6d68 Add forcefoldersync method to folder manager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
1a6326ed97 Create commonly accessible properties for current user colours in Style.qml 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
57f8de9fb6 Make Systray's void methods slots 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-25 12:19:17 +02:00
Matthieu Gallien
81f33ef94c emit missing signal to update folder sync status icon 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-24 16:53:06 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-20 14:11:10 +02:00
Claudio Cambra
0bce17425b
Change unchanging settings strings into constexpr auto in accountmanager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:50 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:48 +02:00
Claudio Cambra
359627007b
Display the user's 'pretty' name in the webflow credentials 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:44 +02:00
Claudio Cambra
29afd9d5f3
Save account's display name in config 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:41 +02:00
Claudio Cambra
25ca698ad5
Improve user-related strings in webflow credentials 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:34 +02:00
alex-z
4e2ea9c00c Fix account not found when doing local file editing. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-17 14:56:30 +03:00
Camila
b55d71dffe The dismiss button is now a CustomButton component. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Camila
0624bec007 Fix the dismiss button: display it whenever possible. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Matthieu Gallien
f9949ee0de
edit locally requires a valid token 
check on server that the token received during a request to open a local
file is indeed a valid one

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-17 09:02:26 +02:00
Matthieu Gallien
a36672c1a4 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
146bd44b09 use correct version copmparison on NSIS updater: fix update from rc 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
ad10d4bb9c remove support for skipping an update: hard to understand for users 
skiping an update is probably there for historical reasons to work
around broken updates in the past

this can lead to users not getting an update they should be getting

this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Claudio Cambra
924d5df3c4 Fix invisible user status selector button not being checked when user is in Offline mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-12 11:50:54 +02:00
Matthieu Gallien
ec1fb6209a improve logs when adding sync errors in activity list of main dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 08:25:45 +02:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.' 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-10 17:13:06 +03:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-10-04 18:32:51 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
Claudio Cambra
c67141430b Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-03 22:27:18 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
Matthieu Gallien
3193937e50
use auto 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-02 14:56:37 +02:00
Claudio Cambra
7a1dbcf2fe Don't set up tray context menu on macOS, even if not building app bundle 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-30 21:45:30 +02:00
Claudio Cambra
652c0dcff7 Fix predefined status text formatting 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-30 16:24:36 +02:00
Claudio Cambra
6137fe246e Fix sync progress bar colours in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-29 21:55:44 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property. 
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:20:56 +02:00
Camila
cbe22d8c1e
Remove unused property. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:17:10 +02:00
Claudio Cambra
9781e896a1 Improve the error box QML component 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-29 12:14:37 +02:00
Claudio Cambra
db861e1ade Make activity action button an actual button, clean up contents 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-28 13:07:08 +02:00
Claudio Cambra
be2c0ddbc8 Ensure placeholder message in emoji picker wraps correctly 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-28 12:33:09 +02:00
Camila
348c9ea915 Fix persistent two factor auth notification. 
The server app returns a 202 code when the request succeeded, which was
not taken into account.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Camila
f3513aaafe Fix two factor auth notification: 'Approve' link is a primary action. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Claudio Cambra
e721b03106 Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:34 +02:00
Claudio Cambra
f71ddc4d43 Add a sortedactivitylistmodel that automatically handles sorting of activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:28 +02:00
Claudio Cambra
664a80cbb5 Clicking on file name clash activities now opens file in web UI were the clash can be resolved 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
80fcb6d95f Ensure strings in main window QML are presented as plain text and not HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 10:57:18 +02:00
Claudio Cambra
bc08559655 Add a placeholder item for empty activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-22 12:17:21 +02:00
Camila
7db68ad2c5
Fix two factor auth notification: activity item was disabled. 
User couldn't click on the links.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-20 18:56:31 +02:00
Claudio Cambra
547e5a4675 Do not format text in QML components as HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-17 15:05:22 +02:00
allexzander
b40c2dfe01 Revert "Remove behavior changes." 
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
ffb7fcad7d Fix deprecation warnings. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
65cd8d06bc Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
0cb448cf8e Do not ignore return values for SyncJournalDB in folder, encryptfolderjob, hydrationjob, and vfs_suffix. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
alex-z
f34fb9ea97 Do not ignore return value of SyncJournalDB in socket API. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
Claudio Cambra
5a56584fba Deallocate call notification dialog objects when closed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-14 12:34:47 +02:00
Claudio Cambra
14303d0eb6 Make account setup wizard's adjustWizardSize resize to current page size instead of largest wizard page 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 23:00:05 +02:00
Claudio Cambra
1a5fa50fbb Refactor ActivityListModel population mechanisms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 19:34:41 +02:00
Claudio Cambra
4c9e0873a3 Fix low-resolution file changed overlay icons in activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 18:55:47 +02:00
Claudio Cambra
66198055d3 Fix add account text clipping, enlarge text 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 20:16:17 +02:00
Claudio Cambra
871ad24e28 Fix ActivityItem activityHover error 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 12:11:23 +02:00
Claudio Cambra
b1caa45929 Fix menu bar height calculation on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 11:52:29 +02:00
Claudio Cambra
b3ccbe2808 Fix fileactivitylistmodel QML registration 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 11:17:10 +02:00
alex-z
2a529eef3c Make sure Folder is deleted from the list and the SyncJournalDB is closed for every folder of the account that has been removed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
alex-z
f0b9ecd747 Check folder invalidity reson when deciding to enable or disable the 'Finish' button in a Wizard page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
Claudio Cambra
9a0753dabb Replace private API QZipWriter with KArchive 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 19:10:03 +02:00
Claudio Cambra
b7b374c442 Fix rebase issue with activity list keyboard navigation PR 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:45:58 +02:00
Claudio Cambra
b820df90b9 Improve activity list highlighting/keyboard item selection 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:27:14 +02:00
Claudio Cambra
85c5002d34 Simplify activity list delegates by making them ItemDelegates, clean up 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:19:49 +02:00
Claudio Cambra
e79ced22ae Clean up QML registration 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 17:00:44 +02:00
Claudio Cambra
7882e224fd Set UnifiedSearchResultNothingFound visibility less messily 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 15:01:07 +02:00
alex-z
1b98733b1a Start sync immediately after modifying the selective sync settings. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 13:38:09 +03:00
alex-z
7ba681544c Fix wrong estimated time when doing sync. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 09:31:05 +03:00
Claudio Cambra
316f3981ab Align, resize, and layout everything uniformly in the unified search view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 09:02:17 +02:00
Claudio Cambra
5acb0b272a Use same tooltip component everywhere 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 08:40:03 +02:00
Claudio Cambra
2fe4bc5403 Add a ScrollView to the predefined statuses area of the UserStatusSelector 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-05 12:33:19 +02:00
Matthieu Gallien
d1408df7ba let Qt use OpenGLES instead of desktop OpenGL to workaround bugs 
should help picking a working rendering pipeline on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-09-04 22:20:38 +02:00
Matthieu Gallien
0092ad15c7 sets special configuration to webengine to work around bugs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-09-04 22:20:38 +02:00
alex-z
ba9a39856b Change Activities dialog show and Systray.forceWindowInit call sequence to fix the issue of Activities dialog not being shown. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
alex-z
22a3b6cc16 Fix File Activities dialog not showing up. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
Claudio Cambra
27f28d781e Prevent the 'Cancel' button of the user status selector getting squashed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 21:08:25 +02:00
Claudio Cambra
ecab3d76ee Ensure that clear status message combo box is at least implicit width 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 20:34:17 +02:00
Claudio Cambra
bedcfbd14c Fix alignment of predefined status contents regardless of emoji fonts 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 20:01:12 +02:00
Claudio Cambra
fc5e9db839 Prevent crashing when trying to create error-ing QML component in systray.cpp, output error to log 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 15:31:04 +02:00
Claudio Cambra
2ab95a30f9 Ensure file activity dialog is centered on screen and appears at top of window stack 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 14:01:32 +02:00
Claudio Cambra
7d41530284 Fix account switching and hover issues with UserLine component 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 18:07:02 +03:00
Claudio Cambra
37bd55b232 Fix unified seach item placeholder image source 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 13:31:45 +02:00
Claudio Cambra
387dfa96a1 Refactor user line 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 12:10:20 +02:00
Claudio Cambra
d86f25d215 Make UserStatusSelector a dismissible page pushed onto the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 09:22:33 +00:00
Claudio Cambra
0a89bf2335 Fix QML warnings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-09 14:45:18 +03:00
Claudio Cambra
81bb290e4c Eliminate padding around the menu separator in the account menu 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-08 16:14:32 +02:00
Matthieu Gallien
8551a14c48 ensure SyncEngine use an initialized instance of SyncOptions 
will prevent nextcloudcmd command line client from ignoring the settings
handled by SyncOptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-08-08 12:36:37 +03:00
Claudio Cambra
e9e482b174 Restyle unified search skeleton items animation and simplify their code 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-05 18:40:13 +02:00
allexzander
ff0a058f66 Fix crash: 'Failed to create OpenGL context'. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-08-05 16:29:21 +03:00
Valdnet
443ec4bfac
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 12:04:36 +02:00
Valdnet
0e703c57c2
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 12:03:03 +02:00
Valdnet
ee950435c9
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 11:26:03 +02:00
Valdnet
42854355ad
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 11:23:31 +02:00