Commit graph

2067 commits

Author SHA1 Message Date
Klaas Freitag
f552637ffd owncloud: Fix a possible null pointer dereference.
CID: #996827

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-22 15:38:55 +02:00
Klaas Freitag
4be88b68cc csync: Fix possible null pointer dereferences in tree walkers.
CID: 1032801
CID: 1032804

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-22 15:38:55 +02:00
Klaas Freitag
0876c18ec9 std: Fix a memleak on error in c_iconv().
CID: #1032806

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-22 15:38:39 +02:00
Klaas Freitag
7c4c7f1b04 std: Fix memleak on error in c_rename().
CID: #1032807

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-22 15:11:57 +02:00
Klaas Freitag
047cf69f1e std: Fix file descriptor checks.
CID: #1032809
CID: #1032808

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-22 15:11:51 +02:00
Klaas Freitag
917cc7faab Base overall progress data on both trees not just one 2013-07-22 12:55:24 +02:00
Klaas Freitag
a12782dccf Add callback parameter and call overall progress bar for initialization. 2013-07-19 17:04:31 +02:00
Klaas Freitag
59ed14698c Fix header 2013-07-19 17:04:13 +02:00
Klaas Freitag
45cdcb7502 Add a progress callback for overall and individual file up and download
progress.
2013-07-19 12:26:48 +02:00
Olivier Goffart
fdd1f885a1 Fixup previous commit.
We should not overwrite the error
2013-07-16 13:34:59 +02:00
Olivier Goffart
db7e8560cf Mark parent directory as error if a file fails to download
The result is that we do not save the parent directory in the db
(recursively) so on the next sync, we don't read this directory from the
db as there might be missing entries since download error are not saved
in the db.
2013-07-16 13:34:47 +02:00
Olivier Goffart
6beb96293f Do not save for resume if there is an error from the server
errors (such as 500) may mean the the server do not suport
resuming
2013-07-16 13:34:22 +02:00
Markus Goetz
1263ca990d Fix download resuming on OS X 2013-07-16 13:33:55 +02:00
Klaas Freitag
e12adbcc7e Rather use _fstat64 on win32 for proper size types. 2013-07-16 13:32:40 +02:00
Klaas Freitag
32559175c9 Use correct stat struct on all platforms. 2013-07-16 12:22:52 +02:00
Daniel Molkentin
6882880ba7 Add csync_clear_exclude_list
This requires the introduction of c_strlist_clear(),
which does not destroy, but only clear a string list.
2013-07-15 14:37:18 +02:00
Andreas Schneider
866af5bf24 std: Add missing includes for memset and uintptr_t. 2013-07-15 08:05:19 +02:00
Andreas Schneider
73fa5f2224 std: Fix const handling on Linux and BSD. 2013-07-14 16:01:51 +02:00
Andreas Schneider
7c9de0230f cmake: Fix names of the include dirs. 2013-07-14 15:57:30 +02:00
Andreas Schneider
341e0e8967 cmake: Fix iconv detection on FreeBSD. 2013-07-14 15:51:09 +02:00
Andreas Schneider
bdb3772e8f cmake: Fix argument order of get_filename_component(). 2013-07-14 15:39:40 +02:00
Andreas Schneider
5599573e2f cmake: Fix getting filename components. 2013-07-14 15:38:10 +02:00
Andreas Schneider
6b189316ab cmake: Require at least version 3.3.9 for sqlite3_prepare_v2(). 2013-07-13 09:17:40 +02:00
Andreas Schneider
1bae4f4dd4 Revert "CID 1033194: Fix resource leak in stateedb test."
This reverts commit c40a3844e0.

There is no leak and we expect it to be NULL. Since we fork here, it
doesn't matter if we leak memory in this case.
2013-07-13 08:57:56 +02:00
Klaas Freitag
207ee9955f Dealloc the query cache in statedb_close 2013-07-12 16:37:33 +02:00
Klaas Freitag
365fb2a5fe Optimize the get_stat_by_hash function. 2013-07-12 16:22:58 +02:00
Klaas Freitag
9046df8985 CID 1032811: Fix resource leaks on error.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:09:49 +02:00
Klaas Freitag
4c1106066a CID 1032813: Add missing break statement.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:09:01 +02:00
Klaas Freitag
38f19a6ada CID 1032814: Don't deref a NULL pointer in _csync_walk_tree().
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:08:03 +02:00
Klaas Freitag
be58f3a64e CID 1032816: Leave the ownership of the buffer to the calling function.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:06:30 +02:00
Klaas Freitag
5d731f7530 CID 1033193: Fix resource leaks in statedb test.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:05:38 +02:00
Klaas Freitag
c40a3844e0 CID 1033194: Fix resource leak in stateedb test.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-07-12 12:03:51 +02:00
Andreas Schneider
9382a047ae cmake: Update FindNeon and add support for version checking. 2013-07-12 11:57:07 +02:00
Klaas Freitag
4aa0c58bb0 Remove duplicate close, coverity found. 2013-07-12 11:41:51 +02:00
Klaas Freitag
c082a3f763 Preinitialize buf with zero, coverity found. 2013-07-12 11:41:51 +02:00
Klaas Freitag
ebc98f07c3 Cleaned code a bit, covertiy found. 2013-07-12 11:41:51 +02:00
Klaas Freitag
90873a9ae8 Release memory properly in error case, Coverity found. 2013-07-12 11:41:51 +02:00
Klaas Freitag
566f5ce614 Close fd even if its zero. Coverity Found. 2013-07-12 11:41:50 +02:00
Andreas Schneider
c1e02db882 BUG 16: Correctly include iconv headers. 2013-07-12 11:32:15 +02:00
Andreas Schneider
81df0406eb cmake: Rewrite FindIconv from scratch.
This version supports BSD correctly.
2013-07-12 11:31:46 +02:00
Klaas Freitag
d0edcd1fba Better do not use the var name abort as it confuses syntax highlighter. 2013-07-11 17:01:49 +02:00
Olivier Goffart
52c7ff415e Fix the test
After commit a25fbb6160, we re compute the
hash before insterint into the db.  Which means that the test need to
have different paths in order to succeed
2013-07-10 12:15:53 +02:00
Olivier Goffart
c20a2bf16b Add a way to configure the block size for httpbf 2013-07-10 12:15:11 +02:00
Daniel Molkentin
d22eb0ceef win32: Read inode values even though file is open
According to MSDN, CreateFile can be passed 0 if only
stat-like info is required.

This allows to upload locked files.
2013-07-10 11:19:07 +02:00
Klaas Freitag
4489eb6cc0 Allow newly created database in test. 2013-07-09 17:31:06 +02:00
Klaas Freitag
b7d549e5a0 Check for zero size database file. 2013-07-09 17:30:40 +02:00
Olivier Goffart
a25fbb6160 Save the right filename in the DB when there are new files on a renamed folder 2013-07-09 16:30:09 +02:00
Olivier Goffart
68a427d7e4 Make sure the directory after a rename has a md5
If not when we do a read from db later, the updater will beleive the
directory is no longer on the server
2013-07-09 16:29:21 +02:00
Olivier Goffart
73ef2c1b6f Do RENAMES before any PUT
In order to fix mirall issue #731
where one rename a file then re-create the original
2013-07-09 16:29:03 +02:00
Klaas Freitag
5f0f49b5bd Use new c_rename function. 2013-07-09 11:13:58 +02:00