Commit graph

22246 commits

Author SHA1 Message Date
Claudio Cambra
56fbc43e0e Add ability to make share sharee displayname more verbose
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00
Matthieu Gallien
d228d85972
Merge pull request #6752 from nextcloud/bugfix/locally-available-folders-open-in-browser-tray-header
Fix opening of locally available groupfolders in web browser from tray drop-down
2024-10-18 10:59:32 +02:00
Claudio Cambra
985d2d9a7a Take reference to folder in folder map within User::getFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 10:59:22 +02:00
Claudio Cambra
e2467baf0c Prevent double slashes in group folder path parsing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 10:59:22 +02:00
Claudio Cambra
e113118e1e Use for : loop in getFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 10:59:22 +02:00
Claudio Cambra
5611f876b0 Constify openLocalFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 10:59:22 +02:00
Claudio Cambra
e60bbf97d8
Merge pull request #7360 from nextcloud/bugfix/mac-vfs-storage-use-elide
Make sure storage headers do not collide with each other in macOS VFS settings
2024-10-18 16:18:13 +08:00
Claudio Cambra
88dd0e19ed Make sure storage headers do not collide with each other in macOS VFS settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 16:17:27 +08:00
Claudio Cambra
09e10b99d7
Merge pull request #7323 from nextcloud/bugfix/mac-vfs-ci-swift6
Fix Swift 6-related CI errors with macOS VFS module
2024-10-18 14:20:42 +08:00
Claudio Cambra
46ac0f94da
Run post-auth state check with main actor task
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 14:16:25 +08:00
Claudio Cambra
3d1a5e34bd
Fix swift 6 concurrency error regarding use of authAttemptState
Cannot pass a local variable into a concurrently executing Task. It's
not a real issue as we are using a semaphore to wait before using this
variable for anything outside of the Task block, but still.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 14:16:25 +08:00
Claudio Cambra
544ae0b33e
Merge pull request #7328 from nextcloud/bugfix/global-progress-vfs-bigsur
Check for availability of Big Sur (under 11.3) before using VFS progress tracking method
2024-10-18 14:00:29 +08:00
Claudio Cambra
d1e26b27f9 Wrap use of NSFileProviderManager globalProgress in availability check
This selector was only made available on macOS 11.3
Just to be safe we should check for the availability

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 14:00:21 +08:00
Claudio Cambra
18fb6dc456
Merge pull request #6123 from nextcloud/bugfix/docs-format
Fix issues on manpages
2024-10-18 13:34:09 +08:00
Claudio Cambra
34e4f40408 Incorporate doc fixes from pull request #6122
Fix issues on manpages

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 13:33:59 +08:00
Nextcloud bot
5412fd2498
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-18 02:52:09 +00:00
Claudio Cambra
2d300240c0
Merge pull request #7351 from nextcloud/bugfix/alwaysRecordMovedItemsAfterServerReplied
on receiving reply of a remote MOVE: always record it
2024-10-18 10:22:09 +08:00
Matthieu Gallien
0eb5ddd442 on receiving reply of a remote MOVE: always record it
even if local item has disappeared, record the result of a remote MOVE
when receiving the reply

enable better state tracking when syncing rename or move operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-18 10:09:08 +08:00
Claudio Cambra
471ed2f4e9
Merge pull request #7346 from nextcloud/Rello-patch-1
remove ownCloud wording in logging
2024-10-18 10:07:58 +08:00
Rello
2695590f70 remove ownCloud wording in logging
remove ownCloud wording in logging

Signed-off-by: Rello <Rello@users.noreply.github.com>
2024-10-18 10:07:47 +08:00
Claudio Cambra
1b78915961
Merge pull request #3014 from nextcloud/foreground-background
Show/Hide Menubar and Dock Icon on macOS
2024-10-17 16:45:17 +08:00
Elsie Hupp
0ad55e82c7
Show/Hide Menubar and Dock Icon
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
2024-10-17 16:26:28 +08:00
Claudio Cambra
32b035b1e6
Merge pull request #4367 from nextcloud/finder-sidebar-icon-fix
Fix Finder sidebar icon to work as a "template" image
2024-10-17 15:55:13 +08:00
Elsie Hupp
b04edf1b62 Fix Finder sidebar icon to work as a "template" image and change to SF Symbols lineweights
Signed-off-by: Elsie Hupp <github@elsiehupp.com>
2024-10-17 15:54:45 +08:00
Matthieu Gallien
809c699e71
Merge pull request #7321 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.2
Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2
2024-10-17 09:53:13 +02:00
dependabot[bot]
be018efb0b Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-17 09:53:06 +02:00
Matthieu Gallien
b59c7b4aa0
Merge pull request #7334 from nextcloud/bugfix/useFileIdToTrackRenamedItems
Bugfix/use file id to track renamed items
2024-10-17 09:46:17 +02:00
Matthieu Gallien
05b6db55c3 remove the enforcement of identical etag for a server side item MOVE
orignally added by https://github.com/owncloud/client/pull/6632

most probably a too strong assumption on the behavior of the Nextcloud
server

better check real item metadata like fileid, size or modification time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
f0908dbbfc handle NEW/NEW conflicts by being real conflicts
NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions

we stop doing this and handle them like any other conflicts

that would cause more download from the server

those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata

will enable more changes to improve MOVE detection from server side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
7301ad3356 in automated tests, update modtime when modifying the content of a file
why one would not update the modification time when modifying a remote
file during automated tests

there is no reason to not update the modification time as this is what
is done by the server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
fe47ca01ce
Merge pull request #7291 from nextcloud/bugfix/improveLocalDiscoveryLogs
better logs to understand when a folder is locally discovered
2024-10-17 08:52:36 +02:00
Matthieu Gallien
8abe8e6f52 better logs tounderstand when a folder is local scanned
should hopefully allows to understand when local file system discovery
is done or omitted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 08:52:27 +02:00
Matthieu Gallien
647f5b26a2
Merge pull request #7285 from nextcloud/bugfix/catchFilesystemExceptions
test syncing of read-only .lnk windows shorcuts
2024-10-17 08:51:47 +02:00
Matthieu Gallien
8a791713cd test syncing of read-only .lnk windows shorcuts
related to https://github.com/nextcloud/desktop/pull/7282

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 08:51:37 +02:00
Nextcloud bot
88f3ef3944
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-17 02:52:33 +00:00
Matthieu Gallien
97539218e6
Merge pull request #7333 from nextcloud/bugfix/signature
Bugfix/signature
2024-10-16 15:22:21 +02:00
Camila Ayres
ddaaf2c344 Fail with error before calling folder metada setup when received empty signature.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
ef811ff220 Report client status error when signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
0e218bc549 Add test testFolderMetadataWithEmptySignatureDecryptFails.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
8cce183ba4 Check if signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Claudio Cambra
e02cf85201
Merge pull request #7322 from nextcloud/bugfix/vfs-crash-socketcontroller
Fix crash caused due to null accountstate in FileProviderSocketController
2024-10-16 16:09:05 +08:00
Claudio Cambra
14a9382772 Fix crash caused by null accountstate due to bad domain identifier parsed from FPExt
Turns out since we are forced to replace colons with hyphens we need to
replace them back to colons when we receive the domain identifier from
the file provider extension. If we do not then we get a null
accountState pointer in the socket controller and this causes a crash

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-16 15:49:59 +08:00
Matthieu Gallien
ace0278bf1
Merge pull request #7319 from nextcloud/bugfix/betterMessageForFilesDeletionDetection
improve wordings of confirmation dialog when many files are deleted
2024-10-16 09:45:11 +02:00
Matthieu Gallien
08abceda73 improve wordings of confirmation dialog when many files are deleted
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-16 09:11:13 +02:00
Nextcloud bot
e16400f191
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-16 02:57:54 +00:00
Matthieu Gallien
88ba1816e4
Merge pull request #7320 from nextcloud/bugfix/text
Make string more readable for translators.
2024-10-15 08:55:55 +02:00
Camila Ayres
eeb1ed8ac3 Make string more readable for translators.
Fix #7309.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-15 08:55:47 +02:00
Claudio Cambra
e5f4264d7c
Merge pull request #7316 from nextcloud/bugfix/blacklist-string-tr
Fix poor translation strings for blacklisted error reason strings
2024-10-15 10:59:53 +08:00
Claudio Cambra
498da851d0 Fix poor translation strings for blacklisted error reason strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-15 10:59:44 +08:00
Nextcloud bot
46de639de5
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-15 02:45:28 +00:00