Kevin Ottens
17b913c3a7
[dolphin] Don't rely on QByteArray -> const char * implicit conversion
...
Signed-off-by: Kevin Ottens <ervin@kde.org>
2024-03-06 14:52:36 +01:00
Kevin Ottens
ea101adbf4
[dolphin] Clean up includes
...
We remove one unused include which will disappear in KF6. Also we switch
to camel case includes without the module prefix.
Signed-off-by: Kevin Ottens <ervin@kde.org>
2024-03-06 14:52:36 +01:00
Claudio Cambra
6845e24e91
Merge pull request #6461 from nextcloud/feature/file-provider-fast-init-sync
...
Add option to perform fast synchronisation runs in File Provider sync engine
2024-03-06 18:47:42 +08:00
Claudio Cambra
d64d959b51
Add explainer about fast sync to file provider settings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
1a576a15d6
Log setting change for fast enumeration in ClientCommunicationService
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
6e55c84d18
Instantiate and hook up FileProviderFastEnumerationSettings within FileProviderSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
23ef72c472
Add starter FileProviderFastEnumerationSettings QML component
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
1441a5e3a2
Make default of fast enumeration enabled method in file provider settings controller to be true
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
23c1e554d0
Add method to check if fast enumeration setting has been set in settings controller
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
5eb333cb8d
Add method to set fast enumeration enabled in file provider settings controller
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
6db990183e
Add method to acquire fast enumeration enabled status in file provider settings controller
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
a02efd65f8
Add method in file provider xpc to set fast enumeration enabled state
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
db9b9a64b4
Add method to get fast enumeration state (if possible) in FileProviderXPC
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
913dcd70ae
Remove wrapper method for creating debug archive, directly use FileProviderXPC
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
90c26c3eff
Make XPC pointer publicly available
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
ae524c0346
Mark fileProviderAvailable as nodiscard
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
bbe48954be
Add method to set fast enumeration in client communication service
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
8d3b676558
Add method to get state of fast enumeration setting
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
9a8af68ddc
Add lazy var for whether the fastEnumeration value has actually been set in settings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
a3e1d66707
Use value from config for fastEnumeration when creating enumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
534b3a60d7
Add fastEnumerationEnabled property to config
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
f987bcd97a
Add computed property to FileProviderConfig to get and set internal config
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
1fc6014230
Add a starter FileProviderConfig
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
cac263f174
Clean up properties and init/invalidate in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Claudio Cambra
179a368f9f
Add option to do a fast enumeration of changes which ignores new, unexplored folders
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-06 18:46:41 +08:00
Nextcloud bot
eb86b9141b
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-06 06:54:44 +00:00
Matthieu Gallien
903e313707
Merge pull request #6463 from nextcloud/bugfix/multipleMovesOfASingleFileid
...
when moving a file, checks that it exists at origin or destination
2024-03-05 17:19:50 +01:00
Matthieu Gallien
b7c1a95d1c
fix missing tracking for some item rename operations
...
will fix mishandling of rename of a single file to multiple places
during discovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-03-05 16:43:05 +01:00
Matthieu Gallien
b35a26091b
add new test to simulate the data loss scenario
...
this new test trigger the assert that a file is either in the old place
or the new place when we execute a MOVE instruction for a local file
in the test one file is discovered as in need of a local MOVE but will
be missing from the old and new places when running the propagation due
to a bug
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-03-05 14:43:42 +01:00
Matthieu Gallien
976dbd6df6
when moving a file, checks that it exists at origin or destination
...
current automated tests are never breaking the rule that a file that
should be moved on client side (after a move was done server side)
exists either at teh original path or the destination path.
in practice it may happen (and I manually tested it) thet the sync
engine decides to move a single file in two distinct places
that decision will violate this rule and a debug build would then run
into the assert
Close #6462
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-03-05 14:43:42 +01:00
Matthieu Gallien
7a0b03aabc
Merge pull request #6491 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.9.1
...
Bump cpp-linter/cpp-linter-action from 2.8.0 to 2.9.1
2024-03-05 14:43:17 +01:00
dependabot[bot]
07d415f348
Bump cpp-linter/cpp-linter-action from 2.8.0 to 2.9.1
...
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action ) from 2.8.0 to 2.9.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases )
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.8.0...v2.9.1 )
---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-05 14:43:06 +01:00
Matthieu Gallien
6bd4539e56
Merge pull request #6503 from nextcloud/bugfix/ignorelist-exclude-status-stuck
...
Bugfix. Exclude list. Fix stuck 'excluded' status in Windows Explorer after removing the exclude pattern.
2024-03-05 12:17:12 +01:00
alex-z
d29e5bee7a
Unit tests for ignorelist exclude status stuck.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-03-05 10:40:09 +01:00
alex-z
837f9a4913
Bugfix. Exclude list. Fix stuck 'excluded' status in Windows Explorer after removing the exclude pattern.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-03-05 10:40:09 +01:00
Matthieu Gallien
b88dfb1dbd
Merge pull request #6502 from nextcloud/bugfix/federated-share-activity-actions
...
Bugfix. Federated share activity show 'Decline' action button.
2024-03-05 10:29:25 +01:00
alex-z
17b0dda300
Unit tests for federated share activity actions
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-03-05 09:13:12 +01:00
alex-z
0a4452ef3d
Bugfix. Federated share activity show 'Decline' action button.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-03-05 09:13:12 +01:00
Claudio Cambra
0826df7916
Merge pull request #6490 from nextcloud/bugfix/expandable-folder-status-model
...
Bugfix/expandable folder status model
2024-03-05 11:50:17 +08:00
Claudio Cambra
e15252a88c
Ensure there is a return in case FolderPathRole of FolderStatusModel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
c7c34b9f14
Check parent variable nullness in folderstatusmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
0daec2071e
Remove unneeded error variable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
1a2afd4576
Clean up and add braces for if statements in folderstatusmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
2556681997
Clarify role of idx in slotUpdateDirectories
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
93a6da6c19
Automatically fetch first level of subfolders for root nodes in folder status model
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
e7a99a8e9a
Use braced initialiser where possible for folderstatusmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
c070ed2b6d
Const autofy where possible in folderstatusmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
d66827c91f
Avoid excessive single letter variables in FolderStatusModel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
c8c7bdbf40
Fix undecided lists in fodlerstatusmodel comment
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00
Claudio Cambra
4b1f502be7
Modernise and replace foreach loops with for in loops in folderstatusmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-03-05 11:48:05 +08:00