Commit graph

113 commits

Author SHA1 Message Date
Camila Ayres
0ae7695d5c
Fix: remove failure to import legacy account notification.
- It was being displayed even on a fresh install.
- We are already displaying a notification when there are accounts to be
imported and we ask the user on what to do.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-01-25 12:23:37 +01:00
Camila
44e8e4b2e9 Fix crash when clicking on import legacy account dialog 'Skip' button.
- mac OS only: With Qt::WA_DeleteOnClose the dialog was being deleted twice.

Signed-off-by: Camila <hello@camila.codes>
2023-11-07 14:33:48 -03:00
Matthieu Gallien
fcd5a86349 signals/slots need to have fully qualified arguments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-10-17 09:32:34 +02:00
Matthieu Gallien
d517cbfd68 fix build by making unique_ptr not const if we std::move it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-09-26 15:40:38 +02:00
Camila
d6eb5c5c7c Address PR comments.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
a23b9f1280 User "1" instead of "one" in thelegacy import dialogs.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
b9fd13695c Fix QMessageBox 'skip' button functionality for importing legacy account.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
0db5e78d6f Improve text and buttons of notification dialogs used during legacy import.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
6f1e1612b1 Only show message with migration status in the end of the process.
Signed-off-by: Camila <hello@camila.codes>
2023-09-26 14:03:37 +02:00
Camila
5e1d2a7dac Migrates all legacy accounts.
Signed-off-by: Camila <hello@camila.codes>
2023-09-13 07:18:17 -03:00
Camila
f69dea0a94
Migrate http_user to webflow_user and dav_user.
- Add {} for single line condition, const auto and fix comments.
- Save the legacy account data first in _settingsMap, so the legacy config file
does not get changed in the migration process.
- Legacy dav_user should stay only as dav_user in the new config.
- Compare davUser and prettyName only when new user id needs to be retrieved.

Signed-off-by: Camila <hello@camila.codes>
2023-09-01 15:09:28 +02:00
Claudio Cambra
f260bbf9f4 Remember server colors across restarts, enabling correct color before capabilities fetched
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2023-08-24 08:34:41 +08:00
Claudio Cambra
c8f8c9cd2c Don't ask user whether to import legacy account configs if forcing legacy import
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
e43f627c9f Add forceLegacyImport property to accountmanager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
6eb2fd1cc0 Notify result of attempted account import with messagebox
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
fba808103c Ask before attempting to import legacy accounts
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 21:23:43 +08:00
Claudio Cambra
0ee850009b Correctly migrate accounts that have possible webflow but not correct authtype in settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
081871d792 Set discovered legacy config file path during account migration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
bdc0ebd527 Restore a specific enum from AccountsManager::restore rather than vague boolean
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 22:56:33 +08:00
Claudio Cambra
4da074e4cb Attempt sign in when an account state is added in AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-08 21:35:48 +08:00
alex-z
90e3a37a20 E2EE. Fix freeze on metadata checksum validation.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-05-08 11:29:16 +02:00
Claudio Cambra
7084310a9f Remove unused AccountState::writeToSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
c496e73200 Correctly parse account server url when migration from legacy config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428 Stop checking config to migrate at current path if could not read file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166 More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
14bd744df6 Use std::make_unique rather than manually build unique_ptr for oCSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
f4bca991e1 Make checks for config file more concise, warn when file not readable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
d8e8a43cff Constify config file QFileInfo, create directly in if statement
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
0f9ddcddcb Fix includes in accountmanager.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
5548a4181b Replace QDesktopServices datalocation with emulated version of it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
98be5fdd18 Add full list of possible legacy config locations
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Matthieu Gallien
39f85219b9 fix migration from old settings configuration files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-15 16:58:00 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-01 09:18:28 +01:00
Claudio Cambra
224621bb85 Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
a537df296b
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-26 13:28:24 +02:00
Claudio Cambra
0bce17425b
Change unchanging settings strings into constexpr auto in accountmanager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:50 +02:00
Claudio Cambra
29afd9d5f3
Save account's display name in config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:41 +02:00
Valdnet
ee950435c9
i18n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-08-05 11:26:03 +02:00
Valdnet
2fb1aab655 i18n: Fix for "end-to-end"
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-28 08:55:54 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Felix Weilbach
f9daa27a5d Enforce fetching of user id
With the change of commit 3e61bdc431 and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 16:16:12 +00:00
allexzander
c930d8e30f Delete apptoken after account removal.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-04 09:37:40 +00:00
allexzander
193e50311b Refresh Windows download dialog progress when hydrating a placeholder
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-03-24 14:09:06 +02:00
Kevin Ottens
4168c0d082 Avoid keeping Account alive via a shared ptr in ClientSideEncryption
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2021-01-26 11:20:13 +00:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode
Don't log that there was no error...
2020-12-15 10:59:15 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts
This allows us to decide on the presentation of the account
2020-12-15 10:59:14 +01:00
Hannah von Reth
ba87fc9e78
[SSL] Properly restore user accepted certificats 2020-12-15 10:59:06 +01:00
Hannah von Reth
9564e5e92e
Fix saving of cookies
Fixes: #7700
2020-12-15 10:59:06 +01:00