Matthieu Gallien
0c3f5cde12
fix name of one clang-tidy check
...
allow modernize-use-override to work fine
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Kevin Ottens
63c3580755
Disable bugprone-forward-declaration-namespace check
...
Turns out this clang-tidy check can give false positives coming from
headers outside the project while it shouldn't.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 12:04:32 +00:00
Kevin Ottens
310693be2c
Enable all the other bugprone clang-tidy checks
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
aa63889e5b
Enable bugprone-terminating-continue clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
0909f00a8b
Enable bugprone-too-small-loop-variable clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
80cc196f6f
Enable bugprone-narrowing-conversions clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
5cec1373ad
Enable bugprone-macro-parentheses clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
608bf025e6
Enable bugprone-forward-declaration-namespace clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
c8ea848596
Enable the bugprone-branch-clone clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
4cb9bec23a
Enable the bugprone-argument-comment clang-tidy check
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
1a0945a973
Enable all the misc clang-tidy check except one
...
This flagged mostly unused parameters. Didn't enable the
misc-non-private-member-variables-in-classes check as we got a lot of
those. Hopefully we'll get to fix them at some point but that feels too
early and too much work for now.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-31 09:14:09 +02:00
Kevin Ottens
866ffc2a6b
Enable the modernize-loop-convert check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-13 12:55:14 +00:00
Kevin Ottens
0e2af4b502
Enable the modernize-deprecated-headers check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-13 14:53:52 +02:00
Kevin Ottens
2f8c29082a
Enable the modernize-use-equals-default check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-13 14:19:42 +02:00
Kevin Ottens
cdf6e7d72b
Enable the modernize-user-nullptr check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 19:45:25 +02:00
Kevin Ottens
d58ec4bf70
Enable the modernize-use-using check on clang-tidy
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 18:18:57 +02:00
Kevin Ottens
07b7753216
Enable "trivial" modernize clang-tidy checks
...
This is a bunch of modernize checks which we don't hit at all. This is
an easy win and also make sure those old constructs won't creep up
behind our back.
Note that some of them won't trigger until we bump our C++ baseline
standard to C++17. But I'd say that's OK, that'll force our hand to do
those C++17 related cleanups when the time comes.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 13:13:08 +00:00
Kevin Ottens
c50a968a1e
Add more raw string literals missed previously
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-12 09:48:29 +02:00
Kevin Ottens
00d20b03ac
Add some more make_unique calls
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-06-04 08:44:05 +02:00
Kevin Ottens
0503be65ae
Cleanup the missing braced init list returns
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-06-03 16:14:18 +02:00
Kevin Ottens
e3e262e42e
Use default member init when applicable
...
This also fixes a couple of warnings at places (out of order init for
instance) and a potential bug in the webflow credentials / qtkeychain
integration.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-06-03 16:10:39 +02:00
Kevin Ottens
965909f7fa
Add missing auto opportunities
...
Somehow forgot to run it on the updater code
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-06-03 16:02:43 +02:00
Camila San
3bae570f29
Do not declare local variables without an initial value.
...
Signed-off-by: Camila San <hello@camila.codes>
2020-06-03 07:50:40 +00:00
Kevin Ottens
08cc4e1967
Remove the last redundant void arg I left behind
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-28 18:57:20 +02:00
Kevin Ottens
2b4ea340e2
Run clang-tidy from the 5.12-clang pipeline
...
This should pass, with the minimal .clang-tidy which was provided. Other
PRs should be done to enable further checks.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-27 18:44:25 +02:00
