Commit graph

18670 commits

Author SHA1 Message Date
Claudio Cambra
4c1a9f787a
Ensure blacklists get updated when removing folder sync
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
d93fc8eb3d
Don't use foreach in Folder::removeLocalE2eFiles
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
8c556287b8
Split if statement conditions in enqueueDirectoryToDelete into separate lines
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
alex-z
ad258473c4
Fix issue of e2ee folders not disappearing when disabling the e2e. Properly process blacklisted e2ee folders instead of ignoring them.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
efcd23eb06
Ensure blacklisted e2ee files get deleted
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
b333310ffe
Clean up sync termination and restart procedure after file blacklisting done
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
fdaedc4914
Only add root-most encrypted folder to the blacklist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
7d208ec06e
Make sure to add e2ee files to normal blacklist too
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
093810f6b9
Only shedule affected paths for remote discovery after disabling e2ee
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
1fc1e95161
Use e2ee folder blacklist instead of deleting folders directly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
12b2673ac2
Add test for deleting encrypted files
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
c59ab85e22
Make accountstate fakeable for tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
b57b35e7a4
Delete E2EE files/folders for accounts that have had E2EE disabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
cc6bdc9bd5
Add ability to remove local encryption keys through settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
689dee6a16
Properly handle sensitive data deletion in ClientSideEncryption
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
f9fb03bdc9
Clean up declarations in AccountSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
2c4dc7e231
Clean up declarations in ClientSideEncryption
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
bca3d9469a
Merge pull request #5266 from nextcloud/bugfix/fetch-more-fix
Fix fetch more unified search result item not being clickable
2023-01-24 12:24:38 +01:00
Claudio Cambra
96cd78264d Fix fetch more unified search result item not being clickable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 12:24:01 +01:00
Claudio Cambra
d69583ba12
Merge pull request #5317 from nextcloud/bugfix/edit-locally-folder-lock
Don't try to lock folders when editing locally
2023-01-23 18:41:46 +01:00
Claudio Cambra
0ab2bd849b Don't try to lock folders when editing locally
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 17:46:43 +01:00
Claudio Cambra
c5c2e95cfb
Merge pull request #5322 from nextcloud/bugfix/old-migration-fix
Fix migration from legacy client when override server url is set
2023-01-23 17:46:16 +01:00
Claudio Cambra
c496e73200 Correctly parse account server url when migration from legacy config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428 Stop checking config to migrate at current path if could not read file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166 More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
57a674c2b6
Merge pull request #5361 from nextcloud/bugfix/update-copyright-years
Update legal notice to 2023
2023-01-23 16:28:39 +01:00
Claudio Cambra
dd4b7b6c26
Update legal notice text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 15:37:56 +01:00
Claudio Cambra
706b1bd3a1
Update Windows shell integration rc copyright strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 15:37:56 +01:00
allexzander
636027a9b3
Merge pull request #5358 from nextcloud/bugfix/fix-bad-string-for-tr
Fix bad string for translation.
2023-01-23 14:24:35 +01:00
alex-z
d8980a8567 Fix bad string for translation.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-23 13:07:41 +01:00
allexzander
593377a4cb
Merge pull request #5324 from nextcloud/bugfix/e2ee-vulnerability-random-initializationvectoor
Always generate random initialization vector when uploading encrypted file
2023-01-18 12:21:18 +01:00
alex-z
75fd1d21be Always generate random initialization vector when uploading encrypted file.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-18 11:54:13 +01:00
allexzander
14072703c4
Merge pull request #5323 from nextcloud/bugfix/e2ee-vulnerability-empty-metadatakeys
Bugfix/e2ee vulnerability empty metadatakeys
2023-01-18 11:54:02 +01:00
alex-z
cdbdf8620d remove unrelated changes
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-18 11:41:55 +01:00
alex-z
4644581af9 remove unrelated changes
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-18 11:41:55 +01:00
alex-z
286a43e9fb Fix memory leak.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-18 11:41:55 +01:00
alex-z
260ba0be46 Fix security vulnerability when receiving empty metadataKeys from the server.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-18 11:41:55 +01:00
allexzander
4ee22a91cc
Merge pull request #5329 from nextcloud/feature/allow-forceoverrideurl-via-command-line
Feature/allow forceoverrideurl via command line
2023-01-17 18:18:13 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
382b322cb7
Merge pull request #5279 from nextcloud/bugfix/fix-full-text-search-items
Fix full-text search results not being opened in browser
2023-01-06 20:09:33 +01:00
Claudio Cambra
481298997c Extract makeResourceUrl lambda into separate static openableUrl method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
37830c4bc4 Simplify makeResourceUrl
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
92667560ab Fix existing check and completion for relative resource URLs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
34240e11ed
Merge pull request #5309 from Flowdalic/drop-qtquickcontrols1
Drop dependency on Qt Quick Controls 1
2023-01-06 18:43:08 +01:00
Florian Schmaus
14cbd836ab Drop dependency on Qt Quick Controls 1
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.

This helps distribution to deprecate and remove Quick Controls 1 [2].

1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
2023-01-06 17:22:56 +01:00
Claudio Cambra
034324d63f
Merge pull request #5299 from nextcloud/bugfix/macos-shellintegration-class-inits
Fix macOS shell integration class inits
2023-01-06 17:16:41 +01:00
Claudio Cambra
f7239ebdca Don't bother doing init procedure on FinderSync in macosx shell integration of invalid self
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 16:24:35 +01:00
Claudio Cambra
521a026e03 Correctly init LineProcessor in macosx shell integration
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 16:24:35 +01:00
Nextcloud bot
09c3680752
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-06 14:28:04 +00:00
Claudio Cambra
2e0680e924
Merge pull request #5272 from nextcloud/bugfix/fseventstreamscehdulerunloop-deprecation-fix
Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue
2023-01-02 19:34:39 +01:00