mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-21 13:14:30 +03:00
Code Issues Projects Releases Packages Wiki Activity
19911 commits 486 branches 258 tags 464 MiB
Commit graph

330 commits

Author SHA1 Message Date
Claudio Cambra
21656cce17
Replace all manual isntancesof adding trailing slash with use of utility method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-08-04 17:40:42 +08:00
Dimitri Papadopoulos
9d830e94f9 Fix typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
Camila San
3bdbed6294 Use addLayout to insert the VFS option when setting account. 
- Maintains the space between the layout items when resizing
the window.
- Also remove qobject_cast.

Signed-off-by: Camila San <hello@camila.codes>
 2023-05-09 15:27:24 +00:00
Camila
6a4d6b9c97 Alway add the item at the end of the layout. 
Signed-off-by: Camila <hello@camila.codes>
 2023-04-12 10:16:47 +02:00
Matthieu Gallien
20422f0247 when local sync folder is overriden, respect this choice 
may lead to inadvertant data loss, not sure if that could be an issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 09:21:48 +02:00
Axel Lender
664e0c18ec Resize WebView widget once the loginpage rendered 
When the login dialogue displays the login page itself
the WebView widget did not resize according to
the dimensions of the login page.

Signed-off-by: Axel Lender <lender@b1-systems.de>
 2023-03-07 09:55:04 +01:00
Matthieu Gallien
01ecb639ab use new connect syntax 
mainly done using clazy and old-style-connect check

close #5426

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-28 09:36:27 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration 
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value 
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:04 +01:00
Camila
9101e0a7f8 Only accept folder setup page if overrideLocalDir is set. 
Fix for #5383.

Signed-off-by: Camila <hello@camila.codes>
 2023-02-02 08:43:51 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-17 17:27:19 +01:00
Claudio Cambra
0495c6567a Fix interval QPROPERTY missing NOTIFY in slideshow class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-02 17:04:30 +01:00
Claudio Cambra
135cab152b Format some QLabels as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 17:18:57 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
Matthieu Gallien
3193937e50
use auto 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-02 14:56:37 +02:00
Claudio Cambra
14303d0eb6 Make account setup wizard's adjustWizardSize resize to current page size instead of largest wizard page 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 23:00:05 +02:00
Claudio Cambra
66198055d3 Fix add account text clipping, enlarge text 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 20:16:17 +02:00
alex-z
2a529eef3c Make sure Folder is deleted from the list and the SyncJournalDB is closed for every folder of the account that has been removed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
alex-z
f0b9ecd747 Check folder invalidity reson when deciding to enable or disable the 'Finish' button in a Wizard page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
Claudio Cambra
5e67405b45 Add a custom back button to the account wizard's advanced setup page 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-06 09:57:30 +02:00
Claudio Cambra
b7c2e16aa9 Make client language gender-neutral and more clear 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 14:36:36 +02:00
Claudio Cambra
d8d72e81bb Redesign local folder information in the account adding wizard 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 10:19:47 +02:00
Claudio Cambra
8267136013 Rephrase button text to be in line with clients on other platforms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-15 12:52:12 +02:00
alex-z
be23e747de Stretch WebView to fit dialog's height. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-18 10:57:10 +03:00
Matthieu Gallien
553d324d3d only add OCS-APIREQUEST header for 1st request of webflow v1 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-10 09:39:35 +02:00
Matthieu Gallien
684d70985e fix button that should be disabled when force VFS 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 14:22:59 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
Felix Weilbach
8370c9c1ca Accept nc scheme in provider page 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 09:01:18 +00:00
Hannah von Reth
02bb5db544 Remove wizard page that has been dead for 4 years 2021-09-03 16:08:37 +02:00
Felix Weilbach
ba2d8e8201 Only set dav user after login. 
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.

It should be enough to set the dav user only after login because the
dav user will never change.

See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839

Fixes #3677

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-03 08:32:15 +00:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
Felix Weilbach
44df9283fe Handle every enum value in switch statement 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-26 15:52:25 +00:00
Felix Weilbach
d706125b15 Return the login name instead of user id 
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-12 14:32:07 +02:00
Felix Weilbach
5195264a20 Ensure that the users id is used for accessing webdav 
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 15:26:39 +02:00
allexzander
fc75b94524 Fix clang-tidy errors. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-30 06:21:05 +00:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-30 06:21:05 +00:00
Felix Weilbach
302651620b Use Q_UNUSED instead of commenting out arg names 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929 Use QStringLiteral instead of plain strings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52 Fix review comments 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1 Enforce https in flow1 and flow2 for https connections 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
991f79c123 Open provider page in browser when compiling without webengine 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5 Allow to compile without QWebEngine 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e Remove dead code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
allexzander
bbf11d7e7a Temporary! Windows. VFS. Block Virtual Files for partition root sync folders. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-11 18:53:35 +03:00
Felix Weilbach
aadee15008 Fallback to primary screen if screen under pointer not found 
Fixes #3252

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-05 11:56:46 +02:00
Felix Weilbach
ff7932bb54 Display the content of the login dialog correct 
This adjustment is necessary because of the changes of the new account
wizard that were introduced with:
e0b7ef15b2

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-16 13:34:34 +00:00
Kevin Ottens
7ad0208800 Finish cleaning up shibboleth 
There were a couple of shibboleth related enums left, since that auth
method isn't supported anymore remove the code tied to those enums. It
was dead code anyway.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
 2021-03-15 09:38:15 +00:00
Felix Weilbach
e0b7ef15b2 Restyle wizard pages 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-10 09:55:40 +01:00