Claudio Cambra
2d3cdb3d03
Merge pull request #5391 from nextcloud/bugfix/sharemodel-crash
...
Prevent ShareModel crash from accessing bad pointers
2023-02-06 15:05:12 +01:00
Claudio Cambra
1d525911f1
Make ShareModel's accountState and folder pointers QPointers to guard against crashes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:30:50 +01:00
Claudio Cambra
bf8cb8305e
Create common validCapabilities used by several ShareModel methods checking account capabilities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:29:35 +01:00
Matthieu Gallien
269f8c4202
Merge pull request #5393 from nextcloud/bugfix/initValueForPointers
...
Bugfix/init value for pointers
2023-02-06 11:54:22 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration
...
done via clang-tidy and manual tuning
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
76e88572d6
more fixes for attributes without init value
...
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
ca932fe093
init attributes
...
discovered at runtime using valgrind
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
b4a8981c03
initialize all variables
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
82b062d2e9
prefer initialization of attribute inline
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d21da0d3af
prefer member init
...
done via clang-tidy and use of modernize-use-default-member-init
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Nextcloud bot
7e2de596e9
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-05 03:35:34 +00:00
Nextcloud bot
3f627c55c8
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-04 03:39:10 +00:00
Nextcloud bot
0f4a0defb2
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-03 03:40:25 +00:00
Matthieu Gallien
69275bb447
Merge pull request #5385 from nextcloud/bugfix/issue-5383
...
Only accept folder setup page if overrideLocalDir is set
2023-02-02 08:44:02 +01:00
Camila
e533c6047c
Update code style.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
e0c1c67306
Fix: if the config did not exist, overrideserverurl had no effect.
...
When the client runs for the first time, setting the value was done before
the config file was created. It had no effect.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
3596562101
Do not exit application when overrideserverurl param is a valid url.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
9101e0a7f8
Only accept folder setup page if overrideLocalDir is set.
...
Fix for #5383 .
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Nextcloud bot
e5eac81950
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-02 03:40:25 +00:00
Camila
efa266fc76
Merge pull request #5384 from nextcloud/bugfix/improveConfigUpgradeWarningDialog
...
Improve config upgrade warning dialog
2023-02-01 22:02:27 +01:00
Camila
72fe5f643c
By default do not display warning about backups made of the config file.
...
Use the setting showConfigBackupWarning to change the default value.
Signed-off-by: Camila <hello@camila.codes>
2023-02-01 19:00:40 +01:00
Camila
9ead33ab93
Improve warning message code readability.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-01 16:21:25 +01:00
Matthieu Gallien
76af889937
use QVersionNumber to compare versions and improve upgrade warning
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00
Matthieu Gallien
fb062f2dd7
fix wrong detectiion of current config file as a config migration
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00
Nextcloud bot
fa90a876b4
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-01 03:43:17 +00:00
allexzander
810fced476
Merge pull request #5378 from nextcloud/Valdnet-patch-4
...
l10n: Correct word
2023-01-31 17:06:48 +01:00
Claudio Cambra
306c01bfce
Merge pull request #5379 from nextcloud/bugfix/file-details-for-all-valid-files
...
Fix displaying of file details button for local syncfileitem activities
2023-01-31 15:08:55 +01:00
Claudio Cambra
dfdc23e240
Fix displaying of file details button for local syncfileitem activities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-31 13:03:52 +01:00
Valdnet
bca915a230
l10n: Correct word
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-01-31 12:59:01 +01:00
Nextcloud bot
a40225eac2
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-31 03:47:34 +00:00
Matthieu Gallien
72595cf88b
prepare 3.8.0 release
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-01-30 16:49:12 +01:00
Matthieu Gallien
bfc80d2cb9
Merge pull request #5370 from nextcloud/feature/e2ee-folders-unlock-always
...
Always unlock E2EE folders, even when network failure or crash.
2023-01-30 16:46:50 +01:00
alex-z
bd9eb0c89f
Always unlock E2EE folders, even when network failure or crash.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-30 16:01:19 +01:00
Nextcloud bot
2a64fc782b
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-30 10:24:32 +00:00
Matthieu Gallien
a7013c51e6
Merge pull request #5362 from nextcloud/bugfix/migrate
...
Migrate old configs
2023-01-30 10:01:01 +01:00
Camila
a3e08aae3b
Address PR comments.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
9a3f2efa58
Fix rename.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
ea903b1316
Backup all config files in the config folder if there was a version change of the client.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
85b4c19b7b
Extend config backup method to make a copy of any given config file.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
dbce267feb
Look for a previous config file with a different name.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
bf258542cd
Update code style.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
e68b4595e7
Remove obsolete QDesktopServices::storageLocation.
...
Use QStandardPaths::writableLocation instead.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Matthieu Gallien
908fe5cba4
Merge pull request #4684 from nextcloud/bugfix/issue-519
...
Open calendar notifications in the browser.
2023-01-30 09:43:41 +01:00
Camila
b4882ae5c7
Update tests for ActivityData.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-27 12:30:01 +00:00
Camila
b525de8a97
Open calendar notifications in the browser.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-27 12:30:01 +00:00
Claudio Cambra
9cb1609896
Merge pull request #5372 from nextcloud/bugfix/revert-mono-config-delete
...
Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"
2023-01-27 13:16:22 +01:00
Claudio Cambra
68c785e25c
Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"
...
This reverts commit 5c42da4de5e4b2449030
2023-01-27 12:23:11 +01:00
allexzander
e332929ffe
Merge pull request #5371 from nextcloud/bugfix/do-not-lock-if-lock-is-not-available
...
Edit locally. Do not lock if locking is disabled on the server.
2023-01-26 18:35:51 +01:00
alex-z
bb8bdab19c
Edit locally. Do not lock if locking is disabled on the server.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-26 17:00:14 +01:00
