Christian Kamm
aeeb408c74
Merge branch '2.3'
2017-06-08 13:02:34 +02:00
Olivier Goffart
c17a678385
FolderStatusModel: fix assert in Qt when the list of subfolder is empty
...
Fix an assert that happens in beginInsertRows when opening a folder
and that folder is empty.
This can only be reproduced with a debug build of Qt.
2017-06-06 14:49:03 +02:00
Olivier Goffart
3d93527a8e
Authentication with OAuth2
...
When the OAuth2 app (https://github.com/owncloud/oauth2 ) is enabled,
We will open a browser and perform the OAuth2 authentication
Issue: #4798 and https://github.com/owncloud/platform/issues/17
2017-06-01 10:39:33 +02:00
Julius Härtl
b7fa50be4c
Set proper application name, icon name for freedesktop notifications
...
Use application name defined in OEM build configuration
2017-06-01 10:01:05 +02:00
Markus Goetz
42751f87d9
Application: debug implies logdebug
2017-05-29 22:05:26 +02:00
Olivier Goffart
f88431adbf
Don't call QElapsedTimer::restart on uninitialized timer
...
That's an undefined behavior.
Since we don't use the return value anyway, we should just use start()
2017-05-29 10:51:05 +02:00
Christian Kamm
03aa7e3044
Sharing: Disable 'set password' button when password is empty #5788
2017-05-22 14:41:06 +02:00
Christian Kamm
91f6cae168
Share dialog: Use default icon if available #5781
2017-05-22 14:15:53 +02:00
Christian Kamm
ddd584077c
Share link: Fix disabled API/sharing #5778
...
* Don't hide the displayed error directly after showing it
* Don't try to fetch shares when sharing isn't possible
2017-05-22 10:59:57 +02:00
Christian Kamm
8201f0b6ea
Share Dialog: Remove unused hline
2017-05-22 10:59:57 +02:00
Christian Kamm
f2b5fcd706
Share link: Fix parsing integer ids #5777
...
Older ownCloud servers like 8.2.0 used to use integer ids.
This broke when switching to QJson because toString() on JSON
values is strict and returns "" for integers.
2017-05-22 10:54:30 +02:00
Christian Kamm
950439e5b8
Sharing dialog: Ensure error labels are expanding #5774
2017-05-22 10:52:52 +02:00
Christian Kamm
f24cdf5a05
Share dialog: Hide the icon when unused
...
Previously this used up some space when there was no icon, leading
to an oddly indented header.
2017-05-22 10:52:52 +02:00
Christian Kamm
d3b00532b1
Credentials: Simplify credential flow #5728
...
And as a side effect: don't ask for user password when we can't
connect to the server in the first place.
2017-05-22 10:52:18 +02:00
Christian Kamm
b7ed0fce2a
Account: forget credentials on delete #5752
2017-05-22 10:49:11 +02:00
Christian Kamm
c1d2a9ab92
Sharing: Show warning that link shares are public #5785 #5747
...
Backport of 3872e060ba33913e43714776a1afce787e772351
2017-05-22 10:28:16 +02:00
Christian Kamm
87a7642381
Settings: Ensure the 'about' label isn't cut off #5760
2017-05-22 10:11:09 +02:00
Jocelyn Turcotte
c50136d675
Add the account name and folder when starting the sync
...
This should help clearly delimiting them in the log for multi-account setups.
This information is already available elsewhere in the log in any case.
Issue #5672
2017-05-17 12:39:59 +02:00
Christian Kamm
c8d0f788e0
Apply clang-format
2017-05-17 12:26:27 +02:00
Christian Kamm
ae263d60bd
Reformatting: Reformat some lines that would become really long
2017-05-17 12:26:27 +02:00
Christian Kamm
df3fe25702
Reformatting: Adjust trailing comments
...
These would otherwise be line-wrapped by clang-format,
and then consecutive reformattings remove the aligned
comment indentation
Example:
int a; // too long comment
->
int a; // too long
// comment
->
int a; // too long
// comment
2017-05-17 12:26:27 +02:00
Christian Kamm
ee4892e345
Wizard: Skip result page with acceptance instead of closing #5764
2017-05-12 10:21:07 +02:00
Jocelyn Turcotte
7fd2f292e7
Promote a few more logs to info/warning
2017-05-11 17:22:59 +02:00
Markus Goetz
b68d982619
macOS: Fix usage of qCDebug in .mm file
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
cf058bc537
Add the possiblility to enable debug logging categories
...
Add a checkbox in the log window as well as a --logdebug command-line
option that should have the same effect.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
b7553d5bdf
Upgrade some qCDebug to qCInfo or qCWarning
...
Use qCInfo for anything that has general value for support and
development. Use qCWarning for any recoverable error and qCCritical
for anything that could result in data loss or would identify a serious
issue with the code.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
4ad190a558
Use Qt logging categories for logging
...
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
2017-05-11 17:22:59 +02:00
Jocelyn Turcotte
e10a08f64d
Remove the unused folderwatcher_qt implementation
2017-05-11 17:22:59 +02:00
Christian Kamm
4b6edaa01a
Detect maintenance mode #4485
...
When we first detect a 503 (probably from a PROPFIND) and enter the
ServiceUnavailable state, we new trigger a status.php query that will
switch the state to MaintenanceMode if necessary.
2017-05-11 11:39:49 +02:00
Markus Goetz
8da7919a43
Sharing: Fix UI glitch when sharing is disabled
2017-05-10 15:41:58 +02:00
Markus Goetz
f52d66a954
Sharing: Optionally show warning that links are public
...
For https://github.com/owncloud/enterprise/issues/1914
2017-05-10 15:41:58 +02:00
Christian Kamm
881641f0b7
Remove stray debug output
2017-05-09 10:37:40 +02:00
Christian Kamm
3da1e9a4b9
Remove 3rdparty qjson #5710
2017-05-08 11:50:33 +02:00
Christian Kamm
2598579d84
Switch JsonApiJob to Qt5's QJson #5710
2017-05-08 11:50:33 +02:00
Christian Kamm
c5b6ec209a
Sharing: Switch from QtJson to Qt5's QJson #5710
2017-05-08 11:50:33 +02:00
Markus Goetz
fbe812b9bc
Selective Sync: Open sub folder context menu #5596
2017-05-08 11:24:02 +02:00
Markus Goetz
4ed9edb104
Wizard: Don't show not-so-useful result page #5726
...
Better immediately show the settings dialog where people can see what's going on.
They can go to sync folder or webinterface from there.
2017-05-03 19:21:46 +02:00
Christian Kamm
d709a47b93
Share dialog: Add option to copy/email direct links #5627
2017-05-03 10:26:27 +02:00
Tommy Sparber
72a3e08907
Move check for mono icons into separate function
2017-04-26 17:39:01 +02:00
Christian Kamm
cd4e647816
Merge remote-tracking branch 'origin/2.3'
2017-04-24 10:32:53 +02:00
Christian Kamm
05236f0a7a
Sharing multiple public links: Depend on new capability
...
See owncloud/core#27709 : files_sharing/public/multiple
2017-04-21 14:08:00 +02:00
Christian Kamm
3c1a2cde33
ShareDialog: Review fixes
...
* Allow creating nameless shares
* Display token as name for nameless shares
(both to be consistent with server)
* Allow changing a share's name by editing it in the table
* Minor adjustments
2017-04-21 10:16:08 +02:00
Christian Kamm
a1f7168d2a
ShareDialog: Add support for multiple public link shares #5655
...
Starting from oC 10.0.0 having several public link shares with
different attributes for a path will be supported. This adds
functionality to create, edit and delete these public link shares.
The behavior is currently gated by server version, but should be
adapted to use a capability as soon as one is introduced, see
owncloud/core#27622 .
The UI reduces to a single-share version when talking to older servers.
Testing scenarios:
* Link sharing is disabled (by capability, not by theme)
* Required passwords
* Required expiry
* Forbidden 'allow upload' for folders
* New and old servers
2017-04-21 10:10:12 +02:00
Christian Kamm
1e1c2f8de2
Rename ShareWidget to ShareUserLine
...
There will probably be a ShareLinkLine too, due to #5655
2017-04-21 10:09:01 +02:00
Christian Kamm
76e67db04b
ShareDialog: Use a tab widget #5655
2017-04-21 10:09:01 +02:00
ckamm
543e8a224c
Fix a crash in ProxyAuthHandler ( #5711 )
...
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/243433178/activity/
https://sentry.io/owncloud/desktop-win-and-mac/issues/234182688/activity/
The problem was that an account's QNetworkAccessManager can be deleted
when reentering the event loop.
2017-04-20 09:21:33 +02:00
ckamm
ea378fe837
FolderStatusModel: Fix crash for empty relativePath ( #5713 )
...
The problem was that split("", SkipEmptyParts) is the empty list.
See
https://sentry.io/owncloud/desktop-win-and-mac/issues/251167186/
2017-04-20 09:16:55 +02:00
Markus Goetz
de9ee295be
Some Dialogs: Bring to top on tray click #5515 #5566 ( #5664 )
...
On my OS X, it might get hidden under other apps while I opened it and then want to quickly
verify something in another app.
2017-04-20 08:55:44 +02:00
Markus Goetz
5ac58d3b83
Server: Parse version from capabilities too #5691 ( #5698 )
...
Newer servers will have the option of hiding version, versionstring, edition
and productname. They will always send the full information in the capabilities.
2017-04-19 11:02:03 +02:00
Olivier Goffart
8cb3a77022
Merge remote-tracking branch 'origin/avatar_pics'
...
Also fix compilation because of 22370fdbdadd06f0cacd249a8d7a32f0d3c1374e
Pull request #5482
2017-04-13 11:54:28 +02:00