mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-22 21:50:30 +03:00
Code Issues Projects Releases Packages Wiki Activity
18393 commits 486 branches 258 tags 464 MiB
Commit graph

110 commits

Author SHA1 Message Date
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
Matthieu Gallien
74f35191e0 do not ignore return value 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-11 21:54:38 +02:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-10-04 18:32:51 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
alex-z
225c2dda4c Bring back .lnk files on Windows and always treat them as non-virtual files. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-27 10:12:03 +03:00
allexzander
b40c2dfe01 Revert "Remove behavior changes." 
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
0cb448cf8e Do not ignore return values for SyncJournalDB in folder, encryptfolderjob, hydrationjob, and vfs_suffix. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
James Horsley
1d7a2c06f6 Fix crash in cldapi.dll 
Fixes #3349

Change placeholder functions to take QStrings instead of handles

Signed-off-by: James Horsley <jbhorsley@gmail.com>
 2022-09-05 09:16:19 +02:00
alex-z
001deace2d Implement COM Dll for CfApi shell extensins. Implement Thumbnail Provider. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-07-29 19:26:53 +03:00
Camila
a97c07f148 Fix segfault when _transferDataSocket is nullptr. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-21 09:34:10 +02:00
Camila
65d012afea Remove assert, it is no longer useful. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-16 10:39:47 +02:00
alex-z
300446579c Fail build when Windows tests fail. Use GH Actions to build and run Windows tests. Create coverage and uppload it to codecov.io. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-06-10 15:18:54 +03:00
Matthieu Gallien
2a3059d779 ensure we do properly failed hydration jobs 
report status when the job is in error at end of hydration request
instead of doing the opposite

properly set status in db when a file failed to hydrate (still a virtual
file not a real one)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-04-03 16:12:42 +02:00
Matthieu Gallien
4371c0cbfe add headers in cmake files to get them properly detected 
qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-11 14:31:22 +00:00
Matthieu Gallien
20a4ed6e7e use proper API to dehydrate a placeholder file 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-01-24 14:16:40 +00:00
rakekniven
961cea92ca l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-01-12 15:55:56 +01:00
alex-z
1244e96681 Enforce VFS. Disable 'Make always available locally'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 15:03:57 +02:00
Matthieu Gallien
41c86d6459 prevent cases where desktop client would store invalid modified time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
b1977dfb18 prevent injecting invalid modified time through CfApi calls 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-12-08 07:22:24 +00:00
Matthieu Gallien
c53159cb0c fix random error when updating CfApi metadata 
initialiazing all fields in a structure is required to not have random
behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-29 18:04:00 +01:00
Matthieu Gallien
83a8058b51 improve logging for CfApi 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
072e9d44bd gracefully handle one case of invalid handles 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
a3013de6ea fix OCC::CfApiWrapper::handleForPath when path does not exist 
sometime it can be called with a path that is already deleted

ensure we always go to the correct code path

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
9eed62a854 remove too noisy log print 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-23 13:41:29 +00:00
Matthieu Gallien
43ec429fe4 improve logs when place holder info cannot be read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Matthieu Gallien
833237b2e4 use alias target for internal libraries 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Matthieu Gallien
c751fd5672 ensure DLL are generated with branded names 
cmake distinct runtime and library

on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Dmytro Korchynskyi
608fc5fb3a Fixed warnings by using static_cast 
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
 2021-09-13 13:05:41 +03:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
allexzander
ba73b6d914 VFS + E2EE. Improved data alignment and unit tests for StreamingDecryptor. Refactoring and renaming for readability. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-08-20 12:57:22 +00:00
allexzander
2c78925acb VFS + E2EE VFS implicit hydration of E2EE files. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-08-20 12:57:22 +00:00
Felix Weilbach
3d72e24bb8 Brand name of vfs plugins 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-19 10:30:24 +00:00
Nicolas Fella
43cccb0a73 Don't use variables for CMake target identifiers 
This makes the code a bit nicer to read and maybe a bit more robust.

Set the relevant OUTPUT_NAME target properties to keep the ability to
customize the names of the installed binaries.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-08-19 10:30:23 +00:00
Matthieu Gallien
2ee26bbd59 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-12 14:31:19 +02:00
Matthieu Gallien
7c68408ee1 only compile xattr virtual files backend for linux platform (not unices) 
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-12 14:10:54 +02:00
Matthieu Gallien
8ad6f89fed bring back dynamic load of VFS plugins 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-08 08:11:17 +00:00
Matthieu Gallien
c123edb173 address review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-06 14:16:43 +00:00
Matthieu Gallien
4016c2fab0 avoid error when doing hydration when data socket is closed too early 
when data is received, if we close the socket they cannot be read

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-06 14:16:43 +00:00
Hannah von Reth
e7e218d8e6 Improve the error message returned by updateMetadata 
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
 2021-07-06 14:03:53 +00:00
Matthieu Gallien
746072e95d fix all usage of _com_error(cfExecuteresult).ErrorMessage() 
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-02 11:19:04 +02:00
Valdnet
3937595eef l10n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-06-17 12:18:00 +00:00
Felix Weilbach
c799dbdd61 Cfapi: Make sure no data is transfered after cancellation 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-17 09:10:06 +00:00
Felix Weilbach
a89a84ff14 Mark placeholder in sync after updating the placeholder 
Fixes #3403 #3082 #3391

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 13:40:26 +00:00
allexzander
bb55232e8e VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-08 09:25:43 +00:00
Felix Weilbach
32b7e62359 Warn user if using e2ee and vfs together 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-18 11:50:18 +00:00
Felix Weilbach
c3a2587a91 Remove unnecessary cfapi logging statements 
For big files that can add a lot lines to the log files.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-12 08:49:13 +00:00
allexzander
ef89256d39 VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-06 06:17:36 +00:00
Matthieu Gallien
419bd93dea when files get hydrated indirectly through pinning, sets correct state 
files that get downloaded not through an hydration request need to be
converted to placeholder

sets the expected state when converting them to placeholder files

 #3082

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-26 13:54:32 +02:00
Matthieu Gallien
929ae965ce prevent progress bar to appear after a download is finished with CfApi 
when using Cloud Filter API with enabled VFS on Windows, a progress bar
stays visible for some time after hydration is completed. Not updating a
last time the progress bar prevents that.

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-26 13:54:32 +02:00