Commit graph

10367 commits

Author SHA1 Message Date
Claudio Cambra
1f4f7c7d0f Revert "remove broken system paellete detection within our custom style"
This reverts commit 2d08cdb503.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-19 14:09:05 +01:00
Claudio Cambra
43ea9b6d83 If fileProviderExtRecheable is false, try to reconfigure client communication service
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-19 13:59:04 +01:00
Claudio Cambra
96e2264baa Fix encoding used for override server url
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-19 13:40:18 +01:00
Claudio Cambra
bcc968deb1 Add small top margin to shareview
Fixes highlight of sharee search field with macOS styling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-18 09:59:19 +01:00
Claudio Cambra
0561a143af Remove background from textfields to fix errors
Fixes the following errors:

ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)).

NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)).

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-18 09:59:19 +01:00
Matthieu Gallien
519f38f92c
remove assert that is being hit always when running debug builds
makes no sense as I have to always patch it out to be able to run a
debug build

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-18 08:54:01 +01:00
Camila Ayres
d5278c58e1 Modernize Utility::removeFavLink and Utility::setupFavLink.
Exit setupFavLink function when SHGetKnownFolderPath fails.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-15 18:26:20 +01:00
Camila Ayres
38eefd4dc7 Add documentation about Utility::setupFavLink and Utility::removeFavLink.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-15 18:26:20 +01:00
Camila Ayres
a3bc54f488 Modernize NavigationPaneHelper class.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-15 18:26:20 +01:00
Camila Ayres
669754b904 f => folderToRemove.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-15 18:26:20 +01:00
Camila Ayres
cc2b5c627b Add step to remove Desktop.ini to removeFolder function.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-15 18:26:20 +01:00
Fabian Creutz
0f85a0bd10 Add null check for resultDacl after calling GetSecurityDescriptorDacl
Signed-off-by: Fabian Creutz <fabian.creutz@kaskadee.eu>
2024-11-15 09:28:05 +01:00
Claudio Cambra
fe7c121156 Clear wizard static pointer on wizardClosed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:36:17 +08:00
Claudio Cambra
6820e1a717 Also emit close signal on window hide (i.e. user close) on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:36:17 +08:00
Claudio Cambra
1ba6b61e7e Emit a signal on wizard close
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-15 13:36:17 +08:00
Claudio Cambra
fa33dd61cf Only present proxy password delete error if it is not a "does not exist" error
Prevent error on deletion when the proxy password does not exist

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-08 12:41:03 +08:00
Claudio Cambra
4f8a83b080 Start counting storage usage from 0 for macOS virtual files account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-05 14:59:53 +09:00
Claudio Cambra
c48ecf8d60 Store reachability of FileProviderExt by respective account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-05 14:59:13 +09:00
Claudio Cambra
4ecaed47df Increase reachability retry timeout
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-05 14:59:13 +09:00
Claudio Cambra
eae8e76fd9 Slash semaphore wait delta on reachability down to 1 second
Any longer does not really yield any positive result and freezes the
client for longer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-05 14:59:13 +09:00
Claudio Cambra
2214c1d3d5 Do not attempt to reach out to FileProviderExt every single time we want to check if it is reachable
Only check every 60 seconds, this way we do not freeze the client for 3
seconds every time that we want to check the reachability while the
extension is unreachable

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-05 14:59:13 +09:00
Claudio Cambra
b39f4aa68c Do not alter the user's debug and expiration settings when changing temporary log dir setting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-31 21:51:27 +08:00
Camila Ayres
9b33cb5e0d
Fix compiling when BUILD_UPDATER is set to OFF.
Only connect signal/slot for update channels listing when BUILD_UPDATER is ON.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:04 +01:00
Camila Ayres
19db552f7d
Remove check in setServerHasValidSubscription.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:04 +01:00
Camila Ayres
60e04bdb8c
Address PR feedback.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
b9b9813655
Update config value when serverHasValidSubscription when accounts are added or removed.
To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
a7144ca981
Fix logic for initial load of update channels and priority for user with subscription.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
d0f87c3496
Save serverHasValidsubcription in the account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
664a13189b
Do not override the channels list if one of the account has enterprise.
Maintain stable and enterprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
85a3658414
Do not override the subscription value if one of the account has enterprise.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
bf09295a63
Change the list of update channels when server capabilities change.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:03 +01:00
Camila Ayres
a58e64f132
Remove checks for the update channel from the getter function.
It should only return the value.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-31 13:06:02 +01:00
Camila Ayres
d080261692
Use const auto.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Camila Ayres
33cc5a2017
Validate http_user value before assigning it to user in the config file.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Camila Ayres
d038ae8482
Remove call to wantsAccountSaved when clearing the cookies.
The cookies are cleared when an account is removed, this call was
bringing back the deleted account.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-29 12:40:24 +01:00
Claudio Cambra
00c11b248a Only display server name in multiple override servers dropdown
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-28 10:13:49 +08:00
Camila Ayres
485a2b6afe On upgrade notification for mass file deletion is disabled by default.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-24 14:31:45 +02:00
Camila Ayres
104e0720a3 Set promptDeleteFiles default to false.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-24 14:31:45 +02:00
Matthieu Gallien
ba4b28cc00 improve logs when checking terms of service status
should help diagnosing a client stuck with ToS block while thinking they
had been accepted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-23 18:20:08 +02:00
Matthieu Gallien
3b0f9a5beb improve again state tracking with terms of service app
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-23 18:20:08 +02:00
Matthieu Gallien
79fa7cd04f
properly detect need to sign terms of service state
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 22:39:38 +02:00
Matthieu Gallien
0b0b80b70f notify user once when terms of service need to be signed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 17:13:31 +02:00
Matthieu Gallien
51352353e4
content access denied error during discovery: verify server access
will trigger a check of the server connectivity in case of content
access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 15:45:37 +02:00
Matthieu Gallien
968289cbf0 content access denied error during discovery: verify server access
will trigger a check of the server connectivity in case of content
access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 15:03:45 +02:00
Matthieu Gallien
8ddf11d960 detect the terms of service app is requiring the user to sign them
will query the sign state for the terms of service and automatically
pause or resume sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-22 15:03:45 +02:00
Claudio Cambra
e36604271f Ensure on removal of share that display string is updated for last (now non-)duplicate share
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00
Claudio Cambra
cd1d1f5833 Store duplicate indices as key-value pair with value storing bucket of all duplicates
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00
Claudio Cambra
37a09aad5f Clean up check for equality between sharee display names
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00
Claudio Cambra
396aeddb03 Make sure to update display of all duplicate display name shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00
Claudio Cambra
e43b7c938a Display more verbose share display names for shares that have sharees with identical display names
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 11:05:16 +02:00