Claudio Cambra
1a6326ed97
Create commonly accessible properties for current user colours in Style.qml
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 19:14:40 +02:00
Claudio Cambra
48359408ea
Remove unneeded parameter from CleanupPollsJob constructor
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 16:00:03 +02:00
Claudio Cambra
57f8de9fb6
Make Systray's void methods slots
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-25 12:19:17 +02:00
Claudio Cambra
421f5e723a
Clean up methods in sync engine
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 11:05:46 +02:00
Matthieu Gallien
81f33ef94c
emit missing signal to update folder sync status icon
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 16:53:06 +02:00
Matthieu Gallien
b9d4e7045e
fix review comments from @allexzander
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
7ffbd95636
fix more sonarcloud issues
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
5e81ab821e
fix more issues reported by sonarcloud
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
b19b69df02
remove useless lines: fix review comment
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
cd30d3645e
fix review comments from sonarcloud static analyzis
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
8ea75f4967
address review comments from @allexzander
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Matthieu Gallien
1ec7774e2f
validate certificate for E2EE against private key
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 10:25:41 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-20 14:11:10 +02:00
Claudio Cambra
0bce17425b
Change unchanging settings strings into constexpr auto in accountmanager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:50 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:48 +02:00
Claudio Cambra
359627007b
Display the user's 'pretty' name in the webflow credentials
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:44 +02:00
Claudio Cambra
29afd9d5f3
Save account's display name in config
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:41 +02:00
Claudio Cambra
25ca698ad5
Improve user-related strings in webflow credentials
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:34 +02:00
alex-z
4e2ea9c00c
Fix account not found when doing local file editing.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-17 14:56:30 +03:00
Camila
b55d71dffe
The dismiss button is now a CustomButton component.
...
Signed-off-by: Camila <hello@camila.codes>
2022-10-17 11:29:23 +00:00
Camila
0624bec007
Fix the dismiss button: display it whenever possible.
...
Signed-off-by: Camila <hello@camila.codes>
2022-10-17 11:29:23 +00:00
Matthieu Gallien
f9949ee0de
edit locally requires a valid token
...
check on server that the token received during a request to open a local
file is indeed a valid one
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:02:26 +02:00
Matthieu Gallien
615c02e3d3
makes JsonApiJob share common code with SimpleApiJob
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:01:36 +02:00
Matthieu Gallien
580f512c94
introduce a very simple network job to do API requests
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:01:36 +02:00
Matthieu Gallien
a36672c1a4
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Matthieu Gallien
146bd44b09
use correct version copmparison on NSIS updater: fix update from rc
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Matthieu Gallien
ad10d4bb9c
remove support for skipping an update: hard to understand for users
...
skiping an update is probably there for historical reasons to work
around broken updates in the past
this can lead to users not getting an update they should be getting
this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Claudio Cambra
924d5df3c4
Fix invisible user status selector button not being checked when user is in Offline mode
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-12 11:50:54 +02:00
Matthieu Gallien
ec1fb6209a
improve logs when adding sync errors in activity list of main dialog
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 08:25:45 +02:00
Matthieu Gallien
74f35191e0
do not ignore return value
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 21:54:38 +02:00
Matthieu Gallien
a096bbd1ff
ensure we do not loose data when syncing locked files
...
fixes #5014
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 16:01:58 +02:00
alex-z
564a3ad987
Fix error in logic.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-11 09:43:31 +03:00
allexzander
4930531949
Command-line client. Do not trust SSL certificates by default, unlss '--trust' option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-11 09:43:31 +03:00
alex-z
7672cb7903
Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.'
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-10 17:13:06 +03:00
allexzander
289a641d74
VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-04 18:32:51 +02:00
Claudio Cambra
2f571337f1
Ensure we are checking lock state without affecting sync behaviour
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
80d0245acb
Unschedule previously scheduled sync runs for locked files if it is found the sync run is no longer needed
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
bbbfe3f1c4
More efficiently schedule sync runs for files that need delayed sync runs
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
fd332a52e2
Fix files not unlocking after lock time expired
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Matthieu Gallien
565a5f0999
add [[nodiscard]] attribute via clang-tidy
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
9b7d1add52
apply modernize-use-using via clang-tidy
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-using' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 01:32:46 +02:00
Claudio Cambra
c67141430b
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-03 22:27:18 +02:00
Matthieu Gallien
ecc588c27a
avoid possibly crashing static_cast
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 10:23:24 +02:00
Matthieu Gallien
0b4128eede
Merge branch 'master' into cleanConfigFileConstants
2022-10-02 15:48:20 +02:00
Matthieu Gallien
3193937e50
use auto
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:56:37 +02:00
Matthieu Gallien
9f1b6c261d
alway use constexpr for all text constants
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:42:01 +02:00
Claudio Cambra
7a1dbcf2fe
Don't set up tray context menu on macOS, even if not building app bundle
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 21:45:30 +02:00
Claudio Cambra
652c0dcff7
Fix predefined status text formatting
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 16:24:36 +02:00
Claudio Cambra
6137fe246e
Fix sync progress bar colours in dark mode
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 21:55:44 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property.
...
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.
Signed-off-by: Camila <hello@camila.codes>
2022-09-29 15:20:56 +02:00