mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 20:32:03 +03:00
Code Issues Projects Releases Packages Wiki Activity
18647 commits 488 branches 258 tags 463 MiB
Commit graph

113 commits

Author SHA1 Message Date
Matthieu Gallien
a36672c1a4 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
146bd44b09 use correct version copmparison on NSIS updater: fix update from rc 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
ad10d4bb9c remove support for skipping an update: hard to understand for users 
skiping an update is probably there for historical reasons to work
around broken updates in the past

this can lead to users not getting an update they should be getting

this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
alex-z
f3c10ac3a4 Always run MSI with full UI. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-02 15:27:01 +03:00
allexzander
250faf027f Do not reboot PC when running an MSI via autoupdate. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-08-02 09:26:17 +03:00
Claudio Cambra
f2dbceaee0 Respect skipAutoUpdateCheck in nextcloud.cfg with Sparkle on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 15:49:13 +02:00
Claudio Cambra
9dd9c46493 Do not compile things that require the app bundle when building the client without the app bundle on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-10 10:43:36 +02:00
alex-z
e40142847b Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot automatically when running from the updater. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-19 12:52:40 +03:00
Claudio Cambra
c22d5959b8 Reimplement notifications for macOS and add support for actionable update notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-11 17:33:33 +02:00
Claudio Cambra
a5019f1f8e Add some logging 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 14:57:47 +02:00
alex-z
59199fc907 General Settings window. Allow opening the update URL via mouse. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-21 16:21:38 +02:00
Felix Weilbach
fb1b3481d1 Fix warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Valdnet
a441d733dc l10n: Correct two typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-10 12:25:34 +02:00
alex-z
4018f8d554 Prompt reboot when runing the auto update. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-09 07:20:19 +00:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
Valdnet
86cb56757e l10n: Remove line break 
A line break is unnecessary in this message.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-08-25 09:11:06 +00:00
allexzander
801e4ad363 Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-21 14:23:43 +03:00
Matthieu Gallien
86dda5675f send OS name and version to auto updater to allow selective upgrades 
in order to be able to suuport legacy OS, also sends the OS name and
version

will be used to detect Windows 8.1 and similar legacy versions

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 09:32:09 +00:00
Felix Weilbach
b2377ff64f Remove html tags from strings that may appear in notifications 
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.

Fixes #2200

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-31 16:23:42 +02:00
Kevin Ottens
4906353f2e Please the clang-tidy overlord 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-11-24 18:22:33 +00:00
Hannah von Reth
038644f378 Don't scare users with critical parser log messages 2020-11-24 18:22:33 +00:00
Hannah von Reth
d30cd0f0fd Include architecture in updater query 
Fixes: #8074
 2020-11-24 18:22:33 +00:00
Hannah von Reth
c76095859a Cleanup stirngs 2020-11-24 18:22:33 +00:00
Olivier Goffart
a7f010c370 Updater: Fix crash when there is an XML error 
The problem was accessing the lines with an off by one error, while printing
the log.

Other problem included the fact that QDebug added spaces, quotes, and other
things which made the error lot look right in the console.

Issue #7545
 2020-11-24 18:22:33 +00:00
Olivier Goffart
1bf895cadc Updater: Fix Version numer not shown in the user visible string 
There was one argument too many in the string.
Bug was introduced in commit 21ac396b

Issue: #7288
 2020-11-24 18:22:33 +00:00
Christian Kamm
c58f00abc7 Updater: Improved logging output #7388 2020-11-24 18:22:33 +00:00
Hannah von Reth
1df3f5b6df NSISUpdater: Improve logging for version comparison 2020-11-24 18:22:33 +00:00
Hannah von Reth
1aca005267 Updater: Log parsing issues in autoupdatLog parsing issues in autoupdatee 2020-11-24 18:22:33 +00:00
Markus Goetz
9a375211d7 Autoupdater: Log the URL #3475 2020-11-24 18:22:33 +00:00
Christian Kamm
d2991210c5 Updater: Preserve target version string 
For #7217
 2020-11-24 18:22:33 +00:00
Christian Kamm
aa7409f401 Updater: Make "Update manually" not also "skip this version" 
See #7217
 2020-11-24 18:22:33 +00:00
Christian Kamm
0b3512f49c WinUpdater: More useful options on update failure #7217 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-11-24 18:22:33 +00:00
Olivier Goffart
9596eb7f20 Updater: show the human readable version in the settings 
The xml looks like this:

   <version>2.5.0.328</version>
   <versionstring>ownCloud Client 2.5.0 alpha1 (build 238)</versionstring>

And we should show the version string

Issue #6602
 2020-11-24 18:22:33 +00:00
Olivier Goffart
f2c3ef741b Updater: remove unused function 2020-11-24 18:22:33 +00:00
Dominik Schmidt
ae38b88d1c Remove unused installers before copying new ones into the appdata dir 2020-11-24 18:22:33 +00:00
Olivier Goffart
e93972824d MSI: Fix crash in the auto updater 
'auto' here is a QStringBuilder referencing a temporary

Ammend commit 150d4f5935
(MSI: Always with logfile #6609)

Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
 2020-11-24 18:22:33 +00:00
Markus Goetz
5e518419de MSI: Always with logfile #6609 2020-11-24 18:22:33 +00:00
Dominik Schmidt
d069fda9ab Extract filename of updateFile without leading slash 2020-11-24 18:22:33 +00:00
Dominik Schmidt
dfac8c0e59 Escape msi and owncloud.exe path (who knows...) 2020-11-24 18:22:33 +00:00
Dominik Schmidt
ed0dc68db2 Run msi properly and restart client after update 2020-11-24 18:22:33 +00:00
Dominik Schmidt
08b5981fb6 Implement basic .msi support in updater 2020-11-24 18:22:33 +00:00
Markus Goetz
412e43b696 Updater: Comments 2020-11-24 18:22:33 +00:00
Christian Kamm
4b39731c27 Updater: Make sparkle updater respect release channel 2020-11-24 18:22:33 +00:00
Markus Goetz
311e3a3bd8 Auto Updater: Show UI element also on macOS 
(cherry picked from commit dfdc2e1e87f99d387a042f4983c999fbb7fcf3d9)
 2020-11-24 18:22:33 +00:00
Christian Kamm
a8ad946758 Settings: Add update channel combobox #6259 2020-11-24 18:22:33 +00:00
Markus Goetz
65035d1990 Sparkle: Delegate calls work now with 1.18.1 (maybe even before) 
We can extend on this to give UI feedback.
 2020-11-24 18:22:33 +00:00
Kevin Ottens
f39542688a
Handle redirects when downloading updates 
This is necessary for downloads coming from Github for instance. They
are systematically redirected and we'd just fail the download.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-10-05 15:48:39 +02:00
Kevin Ottens
0e2af4b502 Enable the modernize-deprecated-headers check on clang-tidy 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-13 14:53:52 +02:00
Kevin Ottens
965909f7fa Add missing auto opportunities 
Somehow forgot to run it on the updater code

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-06-03 16:02:43 +02:00