Felix Weilbach
d6e60cd8d4
Don't log encryption data in release mode
...
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-27 19:50:38 +00:00
Camila
df38e5c08b
Apply server default permissions for federated file sharing too.
...
See nextcloud/server#24729 comments.
Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
Camila
8f847906c6
Check server capabilities for file sharing default permissions.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
alex-z
dc22307a42
Fix review comments + also check against trailing bakslash.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-27 08:13:29 +00:00
alex-z
e16402a102
Fix incorrect db name for nextcloud command line client.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-27 08:13:29 +00:00
rakekniven
68e02bc62d
Fixed context
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1
Fixed grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631
Add dialog to resolve invalid filenames
...
Fixes #3751
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5
set default format for QSurface to handle NVidia context loss events
...
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver
close #3759
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-22 08:56:16 +00:00
alex-z
59199fc907
General Settings window. Allow opening the update URL via mouse.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-21 16:21:38 +02:00
Camila
db447c4676
Refactor OcsShareJob creation.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65
Add option to create label for share link.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da
TextInput by default do not allow selecting text by mouse
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-21 08:07:19 +00:00
rakekniven
af49a7993a
Fixed placeholder numbering
...
Fix for #3812
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-20 11:39:51 +02:00
Felix Weilbach
0074d6c40a
Disable Qt deprecation warnings
...
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1
Fix warnings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f
Display share note when there is one associated with a share link.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Camila
4581279d23
Fix indentation sharelinkwidget.h.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca
Accept nc scheme in provider page
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 09:01:18 +00:00
Felix Weilbach
86da74908a
Emit user status changed after clear user status
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 07:26:46 +00:00
Felix Weilbach
9aee46b3a4
Remove unnecessary logging statements
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 07:26:46 +00:00
Dmytro Korchynskyi
cffceaae1f
Fixed warning: extra ';' in Q_ENUM_NS(PinState);
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
5f232c30be
Fixed warnings from ntstatus.h on Windows
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
608fc5fb3a
Fixed warnings by using static_cast
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Valdnet
a441d733dc
l10n: Correct two typo
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454
Add dialog to set user status
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-09 11:18:22 +02:00
alex-z
4018f8d554
Prompt reboot when runing the auto update.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40
Fix various deprecated warnings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
93f590c6de
Replace deprecated use of QProcess::execute()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
c9863dc225
Use QRecursiveMutex
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
b6e3c6d718
Replace deprecated use of QProcess::start()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
0af83dd1b6
Use QRandomGenerator instead of qrand
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
2fe3a7947e
endl has been deprecated
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Matthieu Gallien
95e3ecfd3c
prevent infinte recursion when closing a websocket in case of SSL errors
...
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-07 07:09:43 +00:00
Felix Weilbach
6fd0adda52
Close wizard if done
...
This is needed because of the changes in 02bb5db544
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-07 06:43:27 +00:00
Felix Weilbach
031b2e0683
Remove assert that caues crashes
...
This assert does not add value. Utility::concatUrlPath() takes care of
appending paths correctly.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-06 15:54:44 +00:00
allexzander
a3fc812539
Enable share to Talk and Email. Display correct icon. Added unit tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-09-06 13:27:39 +00:00
Hannah von Reth
02bb5db544
Remove wizard page that has been dead for 4 years
2021-09-03 16:08:37 +02:00
Felix Weilbach
fa37f5c2bc
Don't create binding loop
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
8a2097e7b9
Implicitly defined onFoo properties in Connections are deprecated
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
ba2d8e8201
Only set dav user after login.
...
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.
It should be enough to set the dav user only after login because the
dav user will never change.
See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839
Fixes #3677
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 08:32:15 +00:00
Nicolas Fella
bc3eb7845d
Remove unneeded target_link_libraries
...
OS_SPECIFIC_LINK_LIBRARIES is always empty here
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
72277726a3
Remove unneeded include_directories
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
18ddb9df4a
Use CMAKE_INSTALL_DATADIR instead of custom DATADIR
...
CMake provides what we wan out of the box
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Heinz Wiesinger
727de34879
Allow using rsvg-convert to generate pngs instead of inkscape
...
Signed-off-by: Heinz Wiesinger <pprkut@liwjatan.org>
2021-08-31 14:52:46 +02:00
Matthieu Gallien
d17d831205
switch from Q_DECL_OVERRIDE to plain override
...
our requirements guarantee availability of override keyword so we just
use it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:57 +00:00
Matthieu Gallien
25669938fd
let clang-tidy add missing override after enabling again the check
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Felix Weilbach
44df9283fe
Handle every enum value in switch statement
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
23fca8019b
Add parens around && in || statement
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
4d72d375f2
Fix warnings related to wrong ordering of ctor init
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Matthieu Gallien
601c4fb3c0
remove a tr call where translator cannot do anything meaningful
...
close #3708
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-26 15:26:54 +00:00
allexzander
4927e48bf3
Update nextcloudcmd documentation.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-26 10:38:06 +03:00
Matthieu Gallien
23bd4675fd
fix build socket api Mac specific file is now in a subdirectory
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-25 14:02:05 +00:00
Valdnet
86cb56757e
l10n: Remove line break
...
A line break is unnecessary in this message.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-25 09:11:06 +00:00
Matthieu Gallien
22a5fadc13
remove broken assert that is not needed and break account setup
...
it has been also removed from the original branch so no problem removing
it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-23 14:13:58 +02:00
Matthieu Gallien
0456cacd79
fix clang-tidy check for usage of =default
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-23 09:44:34 +02:00
Hannah von Reth
c273c8f71b
Ensure the socket listener still exists
2021-08-23 09:44:34 +02:00
Hannah von Reth
4b0122093a
Add socket command to upload a selection of files based on a regex
...
(cherry picked from commit 0ded3a56a9f3470a951b18eaa9d3c1b5e8db1135)
2021-08-23 09:44:34 +02:00
Hannah von Reth
010fccb4fa
Remove dead code
2021-08-23 09:44:34 +02:00
Christian Kamm
ebaa98fa7a
owncloudcmd: Use env vars for chunk sizes #7078
...
Moves a bunch of env var reading from Folder into SyncOptions.
2021-08-23 09:44:34 +02:00
Hannah von Reth
10e02b0031
Don't create QStringList copy first
2021-08-23 09:44:34 +02:00
Hannah von Reth
44fa4aad88
Always call doLog to ensure we get a crash log
2021-08-23 09:44:34 +02:00
Hannah von Reth
d16b2bd369
Send crash log as comment
2021-08-23 09:44:34 +02:00
Hannah von Reth
1ff3a0f8b6
Remove anchient debug msg that mutated to a warning over the year
2021-08-23 09:44:34 +02:00
Hannah von Reth
6324ac9cac
Cleanup members
2021-08-23 09:44:34 +02:00
Hannah von Reth
df567efd37
Remove dead code
2021-08-23 09:44:34 +02:00
Hannah von Reth
990ce6ed05
Dump the last 20 lines of logs to a file when we crash
...
Fixes : #8467
2021-08-23 09:44:34 +02:00
Hannah von Reth
48f4c1e9e1
Log fallback result
2021-08-23 09:44:34 +02:00
Hannah von Reth
acd83a2998
Ensure unit test are using absolute paths
2021-08-23 09:44:34 +02:00
Hannah von Reth
1eee5c849e
Add assert to ensure we used _remotePath as base
2021-08-23 09:44:34 +02:00
Hannah von Reth
6c1073db92
Fix another url for etag request
...
Fixes : #7838
2021-08-23 09:44:34 +02:00
Hannah von Reth
5b457a1663
Use byte array for etag
2021-08-23 09:44:33 +02:00
Hannah von Reth
d16befd1fd
Align MkColJob finish signal with the other jobs
2021-08-23 09:40:27 +02:00
Hannah von Reth
c4f4fb48a4
Minor cleanup of socket api
2021-08-23 09:40:27 +02:00
Hannah von Reth
cb57d8e54c
Add missing Q_EMIT
2021-08-23 09:40:27 +02:00
Hannah von Reth
baa571018e
Log invocation, useful for debugging startup issues
2021-08-23 09:40:27 +02:00
Hannah von Reth
789e0e45d5
Fix Windows long path issue introduced in dd641fae997d71c8396b77def2fa25ad96fdf47f
2021-08-23 09:40:27 +02:00
Hannah von Reth
a72ff9ea7f
Set permissions for new folder
2021-08-23 09:40:26 +02:00
Hannah von Reth
90b733801e
Simplify uuid handling
2021-08-23 09:40:26 +02:00
Klaas Freitag
73549a0529
Ignore the desktop.ini file in every directory, not only in top dir. ( #8299 )
...
* Ignore the desktop.ini file in every directory, not only in top dir.
See https://github.com/owncloud/client/issues/8298 for reasons.
* Fix test for ignoring desktop.ini everywhere.
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>
2021-08-23 09:40:26 +02:00
Hannah von Reth
7715583b14
Correctly use indexOf
2021-08-23 09:40:26 +02:00
Hannah von Reth
557b11aca7
Include os version 'windows-10.0.19042' in about dialog
2021-08-23 09:40:26 +02:00
Hannah von Reth
324d5a04c6
Align type used for getPHash
2021-08-23 09:40:26 +02:00
Hannah von Reth
de2d11125b
Move Prepared sql queries to seperate class to manage access
2021-08-23 09:40:26 +02:00
allexzander
ba73b6d914
VFS + E2EE. Improved data alignment and unit tests for StreamingDecryptor. Refactoring and renaming for readability.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
289df252b5
VFS + E2EE. Handle scenario of sync journal deleted.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
c28cac8479
VFS + E2EE placeholder size migration from old versions.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
2c78925acb
VFS + E2EE VFS implicit hydration of E2EE files.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
b6d216b794
Use separate arguments for a remote root and do not use dav or webdav in the server's URL
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 13:30:35 +03:00
Felix Weilbach
332a48e6a1
Update to Qt 5.15
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-19 14:01:46 +02:00
Felix Weilbach
3d72e24bb8
Brand name of vfs plugins
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-19 10:30:24 +00:00
Nicolas Fella
43cccb0a73
Don't use variables for CMake target identifiers
...
This makes the code a bit nicer to read and maybe a bit more robust.
Set the relevant OUTPUT_NAME target properties to keep the ability to
customize the names of the installed binaries.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-08-19 10:30:23 +00:00
Felix Weilbach
d706125b15
Return the login name instead of user id
...
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-12 14:32:07 +02:00
Felix Weilbach
ccd27870a7
Don't compare integers with different signs
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
acf6cc0527
Remove unused functions and variables
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
d72f7e9109
Check result of setPinState()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Hannah von Reth
9ffa7bcd4d
Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304
2021-08-11 17:13:44 +00:00
Hannah von Reth
3b99b11849
Always reset prepared sql statements
...
This allow the creation of checkpoints and fixes the growing wal issue
Fixes : #7646
2021-08-11 17:13:44 +00:00
Hannah von Reth
6e0a43b570
Fix clash detection with virtual files
...
Fixes : #8323
2021-08-11 17:13:44 +00:00
Hannah von Reth
45f3a97997
Small cleanup
2021-08-11 17:13:44 +00:00