Hannah von Reth
a083a37126
Fix vfs experimental text
2020-12-15 10:59:26 +01:00
Hannah von Reth
b2934a68bc
Fix folder permission check on NTFS
...
Fixes : #8187
2020-12-15 10:59:26 +01:00
Hannah von Reth
8dbdaed5c3
Fix condition
2020-12-15 10:59:26 +01:00
Hannah von Reth
e4a0222954
Append .exe to crashreporter path so it is better located
2020-12-15 10:59:25 +01:00
Hannah von Reth
440b31986a
Ensure the callback is triggered
2020-12-15 10:59:25 +01:00
Hannah von Reth
f6faba48e2
Don`t block main thread when displaying all files removed dialog
...
Fixes : #8170
2020-12-15 10:59:25 +01:00
Hannah von Reth
b4cb3ecb5a
Don't use exec() on dialogs
2020-12-15 10:59:25 +01:00
Hannah von Reth
4878042e61
Update libcrashreporter-qt
2020-12-15 10:59:25 +01:00
Hannah von Reth
7c65d38ba4
Draw active progressbar
...
Pass a widget to the progressbar in the folder delegate to draw the correct active state
2020-12-15 10:59:25 +01:00
Kevin Ottens
201dbd54db
Remove the plugin loader mechanism for VFS backends
...
We will have all the code in public anyway so it can just be compiled
in. Thus no need to go through the plugin loading dance. Replaced the
loading with factory functions. Kept mostly the same structure
otherwise.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
7e5f81ea81
Allow to control availability of folders in the settings dialog
...
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders
...
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.
So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
9f0e0b0f6a
Update the FolderStatusModel when a folder encryption ends
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
596bfab6e1
Set the account state after E2EE is setup in the GUI
...
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
f45e84f2ee
Remove empty action in the settings toolbar
...
This was causing an unwanted line in the middle of the bar.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
d63097475c
Fix typo and style
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
1acb2679dd
Get rid of now unused GetFolderEncryptStatusJob
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
36b8e7c2a4
Remove the encryption flag check from encrypted propagation code
...
If we use those encrypted propagation code paths, we already know from
the discovery phase (and thus the journal db) that the folders are
encrypted so no need to check again.
This will remove another expensive round trip with the server.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
b2533e6451
Remove encrypt status job fetching from ClientSideEncryption
...
This is now unused.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
d22046d679
No need to fetch encryption data separately before discovery
...
This step isn't necessary anymore, no one looks at ClientSideEncryption
for that information anyway.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
580b36fe20
Remove unused methods on ClientSideEncryption
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard
...
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
7a4a359704
Stop using e2e()->isFolderEncrypted() in the jobs
...
Thanks to the new discovery algorithm, we got all the freshest E2EE
information straight from the database so reuse it instead of going
through an in memory copy.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
37a51872e1
Set the encrypted flag in the database when EncryptFolderJob succeeds
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
b667bdda14
Change EncryptFolderJob path convention
...
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
ee8e0fa332
Have the folder token inside the EncryptFolderJob
...
No need to look for a token on the outside we can just work properly by
keeping all the state encapsulated in the job.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
af00ef1cca
Don't use getFileRecordByE2eMangledName in jobs anymore
...
Thanks to the new discovery algorithm we got both mangled and original
file names in the item so no need to go through the database for
nothing.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Kevin Ottens
66f24241d8
Repair E2EE deletions
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Kevin Ottens
567f678fd5
Make sure the encrypted flag gets all the way to the journal db
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Kevin Ottens
961794669e
Repair E2EE uploads
...
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Kevin Ottens
1d07af07a5
Start hooking up E2EE to the new discovery algorithm
...
Now we pull the encrypted metadata during the discovery which is a
better approach than before. This shall remove the need for some of the
deep propfinds we have been using so far. It already simplifies the code
a bit for the download scenario.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Kevin Ottens
2cf76bbcbf
Repair the Windows Build
...
We now enforce the use of QStringLiteral and friends in some places,
but that feel through the cracks for some of the Windows specific code.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:21 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs
...
Fixes : #8131
2020-12-15 10:59:20 +01:00
Hannah von Reth
8796f25994
Log error code as hex
2020-12-15 10:59:20 +01:00
Hannah von Reth
44175aca94
Fix: Log chunked messages
2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead
...
Fixes : #8139
2020-12-15 10:59:20 +01:00
Hannah von Reth
93152761a1
Use verbose function names instead of direct member access
2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair.
...
Fixes : #7724
2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection
...
Fixes : #8083
2020-12-15 10:59:19 +01:00
Hannah von Reth
8460526df9
Clear cookies on logout
2020-12-15 10:59:19 +01:00
Hannah von Reth
f220151527
Remove the use of goto from src/csync/csync_exclude.cpp
2020-12-15 10:59:19 +01:00
Hannah von Reth
4f596dae8c
Log http status
...
Fixes : #8073
2020-12-15 10:59:19 +01:00
Hannah von Reth
020c6d6424
Fix placeholders are reverted to OnlineOnly
...
Fixes : #7779
2020-12-15 10:59:19 +01:00
Hannah von Reth
d58cdaeb2a
Crashreporter: Apply the same hdpi settings as to the main gui
...
Fixes : #8042
2020-12-15 10:59:18 +01:00
Hannah von Reth
0eabc75039
Improve log message
2020-12-15 10:59:18 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default
2020-12-15 10:59:18 +01:00
Hannah von Reth
1aa1ea7bea
Return empty string instead of 1 as adler32 checksum for empty files
2020-12-15 10:59:18 +01:00
Hannah von Reth
23f7c51f70
Print checksum on mismatch
2020-12-15 10:59:18 +01:00
Hannah von Reth
fd6146d09e
Clazy: Fix some warnings
2020-12-15 10:59:18 +01:00
Hannah von Reth
3caf8276a2
Remove pointless warning
...
We also don't have a version entry in the db if thne db is new.
As I don't expect regular updates from 1.5 this message can just be removed.
Fixes : #8004
2020-12-15 10:59:17 +01:00
Hannah von Reth
2d66025d72
csync: apply strict QString handling
2020-12-15 10:59:17 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns
2020-12-15 10:59:17 +01:00
Hannah von Reth
d109d49b49
Ui: Hide selective sync settings if vfs is active
...
Fixes : #7976
2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad
...
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787
e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible
2020-12-15 10:59:17 +01:00
Hannah von Reth
563b347567
csync: apply strict QString handling
2020-12-15 10:59:16 +01:00
Hannah von Reth
82dbf8b5e1
VFS: remove now unused parameter
2020-12-15 10:59:16 +01:00
Hannah von Reth
c1a91e91e7
Use the servers checksum type by default
2020-12-15 10:59:16 +01:00
Hannah von Reth
8c3749cbe2
Log state before specific assertion
2020-12-15 10:59:16 +01:00
Hannah von Reth
2887a93c40
Win: Use full Windows paths in file watcher and improve logging
2020-12-15 10:59:16 +01:00
Hannah von Reth
7fa7bc54c4
Win: Move hresultToQString from vfs plugin to Utility::formatWinError
2020-12-15 10:59:16 +01:00
Hannah von Reth
4589772393
Remove more legacy C code
2020-12-15 10:59:15 +01:00
Hannah von Reth
3dcbc9fa66
Tests: Port check_vio_ext to Windows
2020-12-15 10:59:15 +01:00
Hannah von Reth
47dc7e6c49
Remove custome string functions
2020-12-15 10:59:15 +01:00
Hannah von Reth
29c6f44124
Logging: Print enum before cast in SqlQuer::bindValue
2020-12-15 10:59:15 +01:00
Hannah von Reth
b9638bc778
Fix warning
...
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
2020-12-15 10:59:15 +01:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode
...
Don't log that there was no error...
2020-12-15 10:59:15 +01:00
Hannah von Reth
c9ee0a0343
Log: Improve log message [ info gui.folder ]: Folder sync result: 4...
...
by including the name of the folder and print the name of the result
2020-12-15 10:59:15 +01:00
Hannah von Reth
fb34f8ea85
Gui: Don't try to display the wizard during shutdown
...
Fixes : #7936
2020-12-15 10:59:14 +01:00
Hannah von Reth
4f8928d35e
Remove dead code
2020-12-15 10:59:14 +01:00
Hannah von Reth
c5b59bf3b1
Make ownCloud accassible on the Application object
2020-12-15 10:59:14 +01:00
Hannah von Reth
4645e69147
Remove ifdef(Q_OS_X11) code, there never was such a define.
...
As noone complained since I don't think anyone will miss the code
2020-12-15 10:59:14 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts
...
This allows us to decide on the presentation of the account
2020-12-15 10:59:14 +01:00
Hannah von Reth
7e91166d7a
CMake: Remove krazy2 support, we now use clazy
2020-12-15 10:59:13 +01:00
Hannah von Reth
7fdb842ed2
VFS: Prevent duplicated navigation panel icon
...
Issue: #7748
2020-12-15 10:59:13 +01:00
Hannah von Reth
6c2c544713
Log HTTP requests and responses
...
Issue: #7873
2020-12-15 10:59:13 +01:00
Hannah von Reth
c92f70d4ff
Beautify flags
2020-12-15 10:59:13 +01:00
Hannah von Reth
2b95f919ad
Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a
2020-12-15 10:59:13 +01:00
Hannah von Reth
6d2526a67d
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value
2020-12-15 10:59:12 +01:00
Hannah von Reth
b492b69dfd
Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941
2020-12-15 10:59:12 +01:00
Hannah von Reth
6fde08d9f7
Fix crash on settings migration
...
Fixes : #7878
2020-12-15 10:59:12 +01:00
Hannah von Reth
fa87b899fb
Fix usage of QMessageBox
...
Fixes : #7874
2020-12-15 10:59:12 +01:00
Hannah von Reth
11b9e3fa61
Fix order of pluginkit commands and modernise
2020-12-15 10:59:12 +01:00
Hannah von Reth
aaca3e7ce5
Use separate loggin category for upload v1 and ng
2020-12-15 10:59:12 +01:00
Hannah von Reth
eed4ffb823
Wizard: Raise own window
...
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
2020-12-15 10:59:11 +01:00
Hannah von Reth
baff0a6986
VFS Dialog: Don't enable on close button clicked
...
Issue: #7710
2020-12-15 10:59:11 +01:00
Hannah von Reth
1a1035d516
Remove unused struct
2020-12-15 10:59:11 +01:00
Hannah von Reth
b15c308170
Remvoe now unneeded SyncRunFileLog::directionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
4681421b62
Remvoe now unneeded SyncRunFileLog::instructionToStr
2020-12-15 10:59:11 +01:00
Hannah von Reth
a1d8010eae
Cleanup moc_csync.cpp include
2020-12-15 10:59:11 +01:00
Hannah von Reth
4d615c31da
Rename csync_instructions_e -> SyncInsturctions
2020-12-15 10:59:10 +01:00
Hannah von Reth
8cbdb4451b
Remove now unneede csync_instruction_str
2020-12-15 10:59:10 +01:00
Hannah von Reth
caa04f6adb
Make bit flags better readable
2020-12-15 10:59:10 +01:00
Hannah von Reth
c803292829
Use Q_ENUM_NS for PinState
2020-12-15 10:59:10 +01:00
Hannah von Reth
38c4d5a406
Cookies: Do set cookies in DetermineAuthTypeJob too
...
As we don't support cookie based authentication anymore we can provide cookies here.
This fixes issues with loadbalancers access policy managers.
2020-12-15 10:59:10 +01:00
Hannah von Reth
f073997aee
Cookies: Don't override cookies with outdated values
...
This code was actually not breaking most cookie handling by accident.
As the raw cookies where not split properly we added cookies with values like
"key: val; key2 = val2; key3 = val3"
When the code was corrected we overwrote the newer values in the jar with
the old ones from a request.
2020-12-15 10:59:09 +01:00
Olivier Goffart
317d3735d7
SocketAPI: fix status after a failure to move
...
Issue #7759
2020-12-15 10:59:09 +01:00
Hannah von Reth
85aefa4232
Sync: Fix handling of virtual files in error state
...
Issue: #7799
2020-12-15 10:59:09 +01:00
Hannah von Reth
bcceb5c33d
[Gui] Implement raiseDialog on Windows
...
Issue: #7774
2020-12-15 10:59:09 +01:00
Hannah von Reth
12ae1e97c6
[SocketApi] Ensure listener still exists
2020-12-15 10:59:08 +01:00
Hannah von Reth
868b05f25b
Improve logging of issues during plugin loading
...
If the plugin could not be loaded the client calls qFatal
Make the loading warnings critical so they get printed before we crash
2020-12-15 10:59:08 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported
...
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
2020-12-15 10:59:08 +01:00
Hannah von Reth
9176afe263
Make sure all cases are handled
2020-12-15 10:59:08 +01:00
Hannah von Reth
9b0788bdf8
[Gui] Fix vfs dialog not showing on Windows
2020-12-15 10:59:08 +01:00
Hannah von Reth
a9728b527a
Remove unused defines
2020-12-15 10:59:08 +01:00
Hannah von Reth
1dd01477c5
Use Q_ENUM_NS to pretty print csync enums
2020-12-15 10:59:07 +01:00
Hannah von Reth
5927beb08d
Fix potential null pointer access
...
https://sentry.io/organizations/owncloud/issues/1529161263/events/02509984b5ca42ffb3960d9c9e161414/?project=79001&statsPeriod=14d
2020-12-15 10:59:07 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder
...
issue #7741
2020-12-15 10:59:07 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts
...
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a
I removed a few lines of code there which are already part of fetchMore()
Fixes : #7336
2020-12-15 10:59:07 +01:00
Hannah von Reth
fdc3b7c8da
[Wizard] Make vfs dialog blocking
...
Calling the callback after the receiver was deleted caused a crash
Fixes : #7709
Fixes : #7711
2020-12-15 10:59:07 +01:00
Olivier Goffart
a6a0e361c1
fixup test
2020-12-15 10:59:07 +01:00
Hannah von Reth
106a35d242
[SSL] Print warning only if something changed
2020-12-15 10:59:06 +01:00
Hannah von Reth
ba87fc9e78
[SSL] Properly restore user accepted certificats
2020-12-15 10:59:06 +01:00
Hannah von Reth
c8dd333e31
[Sanity] Remove old ifdef
2020-12-15 10:59:06 +01:00
Hannah von Reth
9564e5e92e
Fix saving of cookies
...
Fixes : #7700
2020-12-15 10:59:06 +01:00
Hannah von Reth
3a3ccb0834
Don't hardcode PLUGINDIR
2020-12-15 10:59:06 +01:00
Olivier Goffart
7fd4a280f0
Make PluginFactory virtual to silent -Wnon-virtual-dtor warning
...
This is not necessary, but it also shouldn't hurt.
2020-12-15 10:59:06 +01:00
Olivier Goffart
1c10fceacc
SyncEngine: no need to use QAtomicInt
...
This was done because the propagator jobs where running in a thread a long
time ago, but this is no longer the case.
(Also QAtomicInt::load is marked as deprecated now)
2020-12-15 10:59:05 +01:00
Olivier Goffart
f81f96915f
ProxyAuthHandler Use QPointer instead of QWeakPointer
...
QWeakPointer::data is deprecated.
In this case we should use QPointer
2020-12-15 10:59:05 +01:00
Hannah von Reth
466e8abc91
[Core] Include more information about the OS in the user agent
2020-12-15 10:59:05 +01:00
Hannah von Reth
edb51abdfd
Don't ignore file sync notification after an unlock
...
For a usual file sync event we check for actual changes in the local file,
after an unlock the local file might be unchanged so we need to sync it anyhow.
Fixes : owncloud/enterprise#3609
2020-12-15 10:59:05 +01:00
Hannah von Reth
3317e354f2
Prepend PLUGINDIR else its pointless
2020-12-15 10:59:05 +01:00
Hannah von Reth
b6e8d47644
Use Q_ENUM on AuthType to get the name printed in the log
2020-12-15 10:59:04 +01:00
Hannah von Reth
dabf7aaebc
Application: Allow to quit running instances by commandline
2020-12-15 10:59:04 +01:00
Hannah von Reth
fa82a4aff3
Cleanup
2020-12-15 10:59:04 +01:00
Hannah von Reth
6c19b02888
Disable http2 support for now
...
Issue: #7610
2020-12-15 10:59:04 +01:00
Olivier Goffart
0e7c56e81c
Don't show the "All files deleted" popup when unselecting everything with selective sync
...
Issue #7337
2020-12-15 10:59:04 +01:00
Olivier Goffart
4424eb7f07
AccountSettings: limit the clickable region of the 'add folder' button
...
Issue #7326
2020-12-15 10:59:03 +01:00
Olivier Goffart
b97c0ed8a2
Network Settings: Show a warning that proxy settings do not apply to localhost
...
Only show this if at least one account is detected to have an url that looks
like localhost, because this could otherwise be confusing
Issue #7169
2020-12-15 10:59:03 +01:00
Olivier Goffart
392d3c257c
Discovery: Allow more HTTP error code to be treated as ignored dir
...
The original code from csync was stopping at any error.
But we have been whitelisting soeme http error code one by one
to ignore the directory instead of aborting the sync.
However, as there are more requests to continue the sync in case
of error, just ignore most HTTP errors
Issue #7586
2020-12-15 10:59:03 +01:00
Hannah von Reth
43c7e32ee1
[libsync] Export verifyFileUnchanged
...
This fixes Windows builds that are broken since #7562 was merged
2020-12-15 10:59:03 +01:00
Olivier Goffart
66f7b27121
VFS: Do not overwrite existing files by placeholder
...
For issue #7557 and #7556
Note: this change the API of the VFS plugin, so the VFS plugin needs small
adaptations
2020-12-15 10:59:03 +01:00
Hannah von Reth
9807285abd
[Gui] Set proper hdpi attributes
2020-12-15 10:59:03 +01:00
Olivier Goffart
fc0aeb53b1
Discovery: fix TestSyncVirtualFiles::testExtraFilesLocalDehydrated on windows
...
On windows we do a test to know if we should change the case of the files,
but that conflict with the test that checks if the file was still there
when the filename is actually the same. Which can happen with virtual files
as they have two representation (the one with and without suffix).
2020-12-15 10:59:02 +01:00
Christian Kamm
4c4cbf0d97
Vfs: Lots of tests and corrections for suffix edge cases
...
Avoid or deal with problems that happen when suffixed files exist on the
server or suffix and non-suffixed files exist locally.
See #7350 , #7261 .
2020-12-15 10:59:02 +01:00
Olivier Goffart
88f86a56b1
Discovery: Attempt to fix issue with windows VFS and new files
...
(or moved files)
As seen in the log of #7558 , a conflict may be issued by mistake.
See investigation in https://github.com/owncloud/client/issues/7558#issuecomment-547385362
This hopefully fix #7558
2020-12-15 10:59:02 +01:00
Olivier Goffart
513b0c723c
Account Settings: change the color of info message from green to blue
...
To avoid confusion with the color of "success"
Issue #7403
2020-12-15 10:59:02 +01:00
Olivier Goffart
4d7ed8f62c
Wizard: fix compilation warnings about unused variables
2020-12-15 10:59:01 +01:00
Olivier Goffart
115a53134c
SyncEngine: Save a bit of memory by not keeping a set of all filename
...
This is only used for conflict files, so only save conflict files.
(The _seenFile was used for other things in 2.5, but not anymore)
2020-12-15 10:59:01 +01:00
Olivier Goffart
83d743b66b
When moving is allowed but deleting is not, do not restore moved items
...
Issue #7293
2020-12-15 10:59:01 +01:00
Olivier Goffart
ee611e6004
Restoration items should appear in the sync protocol
...
When an item is downloaded because it is restored, it shall be shown in the
sync protocol.
(It is also going to be shown in the not synchronized for a short while, but
that's fine)
2020-12-15 10:59:01 +01:00
Christian Kamm
9d422284af
Discovery: Distinguish readdir and closedir errors
2020-12-15 10:59:01 +01:00
Olivier Goffart
adbd3d869b
Fix warning about serverJob not being used
...
And fix a FIXME in the same time
2020-12-15 10:59:00 +01:00
Christian Kamm
89216daee6
Propagate dir: Never write the etag on remote mkdir #7481
...
It must always only be written once all children are successfully
propagated.
2020-12-15 10:59:00 +01:00
Hannah von Reth
dc55617144
Ensure the url is complete before we validate it
...
Fixes : #6722
2020-12-15 10:59:00 +01:00
Christian Kamm
c9476a11f4
Checksums: Explicitly close file before reporting result
...
To ensure it's no longer open when the finished signal fires.
2020-12-15 10:59:00 +01:00
Christian Kamm
e91e1ca78f
Test: Disable local discovery parallelism in permission test
...
Adding parallelism broke the test because it depended on the order of
discovery.
2020-12-15 10:59:00 +01:00
Christian Kamm
e596b55977
Discovery: Change local job signal signatures
...
To make it more explicit that data a copy of the data is transfered
between threads. (though Qt will make a copy of the arguments anyway)
2020-12-15 10:58:59 +01:00