mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 04:11:50 +03:00
Code Issues Projects Releases Packages Wiki Activity
21506 commits 487 branches 258 tags 462 MiB
Commit graph

4635 commits

Author SHA1 Message Date
Camila Ayres
b3ff87b73e Make warning text before deleting all files more clear and concise. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-06-28 18:18:08 +02:00
Camila Ayres
1f88052a8e Fix #3144: check for promptDeleteAllFiles config setting before emitting signal to display warning. 
The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.

Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-06-28 18:18:08 +02:00
Matthieu Gallien
a270dca344
do not allow to select e2ee folders if the server support is missing 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-06-26 14:47:17 +02:00
Matthieu Gallien
284823d147
maintain e2ee state even if the server does not support e2ee 
might be that the server previously supported e2ee and e2ee folders
exist

so we have to fetch the info to properly handle it on client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-06-26 14:47:17 +02:00
Claudio Cambra
73fc23f002 Remove no longer existing account id from configured vfs accounts list 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-25 23:01:13 +08:00
Claudio Cambra
fc2e687c3d Prevent crash when updating file provider domains if the account for which a file provider domain was configured no longer exists 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-25 23:01:13 +08:00
Claudio Cambra
1689f7b613 Assert validity of accountstate and its accountptr when adding it 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-25 23:01:13 +08:00
Claudio Cambra
74a78242e2 Remove overwrought loadFromSettings method from AccountState 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-25 23:01:13 +08:00
Claudio Cambra
fd4ddfdd4c Take AccountPtr by reference in accountstate constructor 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-25 23:01:13 +08:00
Camila Ayres
fcf07b60c4
Move the logic for handling the featured app qml to cpp. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-06-25 15:34:50 +02:00
Camila Ayres
b7bf6083d9
Display the Nextcloud assistant icon in the main window. 
- If NC assistant is enabled in the server, display the icon
to open it instead of Talk. Talk is then displayed in the
list with the other apps.
- The direct link is only available in the assistant app >= 1.0.9.

Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-06-25 15:34:49 +02:00
Claudio Cambra
fa1f8b3efe Fix text colour for NCInputTextEdit 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-13 19:15:11 +08:00
Claudio Cambra
d61a209e53 Prevent crash when originalSize is null 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
4db90b052e Remove broken and unneeded scroll view in tray user menu 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
4ff0cce787 Fix displaying of more button in UserLine 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
78ae106ea0 Fix displaying of header buttons in tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
04e1736616 Ensure svg icons generated by svgimageprovider have a reasonable default size 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
8d025a0d9d Fix use of sourceSize in TrayFoldersMenuButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
3da63f9979 Fix vertical center anchor in trayfoldersmenubutton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
99cf137b2e Remove unneeded qt5compat import in headerbutton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
82e2ec0f67 Fix breakages in autosizing menu when item does not have expected internal properties 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Claudio Cambra
c7cc40c464 Correctly fall back to originalSize if requestedSize not valid in svg image provider 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-06-07 00:17:40 +08:00
Jérôme Herbinet
dd1f32df65 Replace "Edit" with "Open in browser" 
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
 2024-06-03 08:55:34 +02:00
Claudio Cambra
57ced98f98 Censor account details string in file provider logging 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-05-15 21:47:05 +02:00
Claudio Cambra
4bd0974696 Remove use of setMargin on QVBoxLayout, not present in Qt6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-05-13 11:07:33 +02:00
Claudio Cambra
afbd2ebc02 Remove all use of MacExtras 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-05-13 11:07:33 +02:00
Matthieu Gallien
d0b4af6ccc improve logs when build with NEXTCLOUD_DEV enabled 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-05-02 16:34:51 +02:00
Matthieu Gallien
3770eec050 windows needs an explicit QML import path to be set 
on windows qml modules are not default loaded from the install folder of the app

set it such that qml modules are imported from teh installed qml folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
347285b5b3 fix build issue after rebase 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
bebb8e1954 fix compilation issues on windows 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
a05ac621bf do some header includes clean-up as recommended by compiler 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
060181f83d fix some of the qml issues 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
aae9e84438 fix compilation issues after rebase 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
4f178fa9be fix order of init in a constructor to avoid warnings 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
3ad7ac922a avoid warning by ignoring the return value of QtConcurrent::run 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
910d7f03e8 when loading translation catalog, do not ignore the return value 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
e3456847d8 last step 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
70931fb0af Remove commented out broken quick compiler check in Qt6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
5d765dd017 Fix user status selector 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
3597766fb0 Add separators to SyncStatus and UnifiedSearchInputContainer to stop the scrollviews looking broken 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
5087d5142a Fix all broken QML imports 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
c31e65c111 Remove crashing QRandomGenerator seed call 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
a0e90cf56b Remove use of QCoreApplication AA attributes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
a8e7e340aa Replace use of staticQtMetaObject with staticMetaObject 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
aaea45110f Replace removed progress bar option orientation with state flag 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
7a17a51a25 Use QEnterEvent for new enterEvent parameters 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
7e1448bcf2 Remove use of qRegisterMetatypeStreamOperators 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
84414ce5dc Replace deleted '+' operator for flags with '|' operator 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
6210490109 Replace now invalid '+' operator with '|' operator for QKeySequence 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
1a2db488ab Add missing QActionGroup include 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
7954695783 Add missing QStandardPaths include 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
ac1206a0c1 Remove conflicting alias to QStringList 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
29b0d2b8ad Remove use of QNetworkConfiguration in Qt6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Claudio Cambra
79a150baf4 Fix qtkeychain imports with Qt6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
4566400ee6 streamline find_package calls to really find Qt6 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
aa76de9b68 allow detection of qt5 or qt6 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
d3442d137a disable qt apis deprecated before qt 5.12, enable warnings 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
1f0279e1c1 remove usage of QStringRef due to it being missing in Qt6 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
b63c88e492 add missing QStringLiteral 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
ee245f26c8 replace deprecated QWebEngineProfile::setRequestInterceptor 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
249e0eb87d port away from QWidget related margines APIs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
20ee506b71 port away from deprecated API from QFontMetricsF 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
d035c26be5 replace qrand/qsrand 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
b712108229 add missing Qt:: namespace when using Qt::endl 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
80b25d36fa port away from QStringList::toSet 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
Matthieu Gallien
21464063b6 port away from QDesktopServices::storageLocation 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-26 09:05:12 +02:00
allexzander
7e801d6c9a
Merge pull request #6691 from nextcloud/bugfix/slow-sync-with-tray-open 
Bugfix/slow sync with tray open
 2024-04-25 10:18:13 +02:00
alex-z
2ea6d3fd38 Bugfix. Conflict dialog for multiple files. Fix checkbox border colors for dark mode on Windows. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-25 10:14:11 +02:00
alex-z
9fac497e6e Hotfix. Slow download speed while tray is open. Do not run rotation animation in syncstatus in tray. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-24 20:28:24 +02:00
alex-z
fc31ac4a1f Just for test. Disable status update to avoid havin a sync status animation in tray. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-24 20:28:24 +02:00
Claudio Cambra
ef08c5eb4e Only show successful debug archive creation dialog if it has indeed been successful 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:16:53 +02:00
Claudio Cambra
ef2423da53 Prevent crash on creating debug archive in non-writeable location 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:16:53 +02:00
Claudio Cambra
2323b843f0 Give debug archive save location dialog a default location 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:16:53 +02:00
Claudio Cambra
64b7282bd4 Re-run update sync paused state slot when folder list has changed 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:15:13 +02:00
Claudio Cambra
d3aa7f8f51 Make sure to emit syncIsPausedChanged in syncIsPaused setter 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:15:13 +02:00
Claudio Cambra
ccf6b5abe1 Make sure to emit relevant signals and set sync is paused to true if relevant 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:15:13 +02:00
Claudio Cambra
d497e265df Extract syncIsPaused initialisation into new updater slot 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:15:13 +02:00
Claudio Cambra
1c84b832fe Fetch macOS VFS package in autoupdater if the client is using the file provider module 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:11:41 +02:00
Claudio Cambra
591d5eebd2 Prevent use of invalid characters for file provider domain names 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:11:11 +02:00
Claudio Cambra
8f6c19e029 Fix "false" error about bad applying of nodiscard to value type 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 19:10:40 +02:00
Matthieu Gallien
1522d01d5b if a virtual file change but bothing changed: set it as in sync 
some software (at least outlook native software) may fiddle with CfApi
placeholder metadta and set a .msg file to be out of sync state when
opening it

in that case, we will let the sync engine go over it and decide what to
do

it is then possible in that case that we would just put it back in "in
sync" state

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-04-23 18:04:35 +02:00
Claudio Cambra
80afd8e737
Use davUser instead of direct credentials user in file provider 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-23 22:24:20 +08:00
Claudio Cambra
5977a7c92d
Remove client-side push notification handling for file provider extension in favour of simply using NCFPK remote change observer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-17 16:15:05 +08:00
Claudio Cambra
3dcef75c57
Fix crash when in debug mode when toggling enabled status of an account's virtual files (macOS) 
Caused by comparing to the wrong thing in the Q_ASSERT *facepalm*

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-04-17 03:05:46 +08:00
alex-z
dbde9e3a2b Detect office files for locking on new upload. Notify FolderWatcher. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-13 15:46:37 +02:00
alex-z
1145d0613b Bugfix. Remove seen call notifications from the list. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-04-02 13:19:34 +02:00
Matthieu Gallien
55034f7e43
properly compute if a folder is top level or child extern mounted 
asks new permission to server to be able to know if a folder is a top
level mounted folder

should allow detecting the top level folders from external storages or
group folders

should also make the client reliably detect that it is handling a child
folder inside a group folder and be allowed to rename such folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-27 14:29:01 +01:00
Matthieu Gallien
608a435d38
context menu: do not recursively check pin and availability states 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-27 11:59:30 +01:00
Matthieu Gallien
d81c20b116 partial fix for compilation with QT_NO_KEYWORDS 
need to replace signals by Q_SIGNALS and so on

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-27 10:34:22 +01:00
Camila Ayres
84c08419ff User 'Connection issue' instead of 'Network error' in systray notification. 
Signed-off-by: Camila Ayres <hello@camilasan.com>
 2024-03-20 09:51:11 +01:00
Matthieu Gallien
4bf1b8604c
if desktop client sent a first reply: wait for the menu data 
may need the user to wait a bit longer but should prevent missing the
context menu

should still be robust since we only wait indefinitely if desktop client
sent a first reply

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-20 09:44:33 +01:00
alex-z
c5dd2e89a1 E2EE. Fix root metadata fetching path for non-root remote sync folder. Refactoring. Stabilizing paths. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2024-03-20 00:54:27 +01:00
Matthieu Gallien
2c95775edf allow wipe feature to delete data of a wiped user account 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-19 15:58:00 +01:00
Matthieu Gallien
6d1f028ed8 only display changed network errors during validation of connection 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2024-03-18 09:21:30 +01:00
Claudio Cambra
f805596418 Remove unneeded fallback for undefined cmake_osx_deployment_target 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-11 15:20:51 +01:00
Claudio Cambra
bbf280e12e Do not try to link UserNotifications framework when building below 10.14 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-11 15:20:51 +01:00
Claudio Cambra
8e39d8ef97 macosx: Selectively compile UserNotifications component of systray depending on deployment version 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-11 15:20:51 +01:00
Claudio Cambra
2f6ae0c4dd Create systray_mac_common file for common systray functions 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2024-03-11 15:20:51 +01:00
Kevin Ottens
526ab056d6 [socketapi] Replace QClipboard with KSystemClipboard when available 
This is necessary in Wayland sessions for the clipboard related actions
of the socketapi to work. Indeed, QClipboard does its job only if we got
a window with the focus in such session.

In the case of the socketapi, it is generally the file manager asking
the desktop client to put something in the clipboard. At this point in
time no window of the client have the focus, so nothing gets added to
the clipboard.

KSystemClipboard on the other hand, uses the wlr data control protocol
under wayland sessions ensuring something ends up in the clipboard as
expected. When not in a wayland session it falls back to QClipboard so
no behavior is lost.

Signed-off-by: Kevin Ottens <ervin@kde.org>
 2024-03-07 08:18:52 +01:00
Kevin Ottens
312da848bc [gui] Add KGuiAddons as an optional dependency 
This will be needed to replace QClipboard in some places.

Signed-off-by: Kevin Ottens <ervin@kde.org>
 2024-03-07 08:18:52 +01:00