Commit graph

10377 commits

Author SHA1 Message Date
Matthieu Gallien
48932ba57b enable dev logs only when NEXTCLOUD_DEV is defined to value 1
will switch back production logs to the intended behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-04 12:02:39 +02:00
Matthieu Gallien
bf2fc44cfc
message should say many not all: would be triggered by 200 files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-01 16:41:56 +02:00
Matthieu Gallien
ab2bf984e7
remove not so usefull log line for new files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-01 15:43:43 +02:00
Matthieu Gallien
e2f94d86ef
create a permanent log of delete actions
will log all deletions with the result of the discovery by the sync
enginre

should enable analyze even long time after such a delete occured

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-01 15:43:42 +02:00
Matthieu Gallien
d31b3b068f count the files deletion and warn if threshold is exceeded
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-30 14:33:49 +02:00
Matthieu Gallien
e6f62930e9 use constexpr function for platform detection
should decrease the cost of their usage when compared to preprocessor
conditional directives

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-27 09:26:36 +02:00
Camila Ayres
b8ca1584e3 Only check leading/trailing spaces for files on Windows.
Fix for #6807.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-27 09:06:11 +02:00
Matthieu Gallien
b27eb06386 disable our code for network timeout
seems we have an issue with Windows and QTimer instances used to detect
network timeout

workaround, find cause of https://github.com/nextcloud/desktop/issues/7184

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 16:11:37 +02:00
Camila Ayres
ee351aa132 Validate input of APPLICATION_SERVER_URL.
Tries to clean double quotes and output JSON parse error.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-26 14:55:29 +02:00
Camila Ayres
aec2eaf73f Fix alignment and size of buttons.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-26 12:02:21 +02:00
Matthieu Gallien
570749c89e changing default chunk size to 100MB
goal is to have better performance and uniform behavior between all files clients

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 10:56:53 +02:00
Matthieu Gallien
c77562022d
lock token should be sent via webdav only for token lock type
to be able to modify a locked file using token lock, we must sent it
with webdav requests

this must not be sent if the file is locked but the lock type is not a
token lock

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 09:25:34 +02:00
Matthieu Gallien
202be8a081
clarify when desktop client should offer to unlock a file
a file can be unlocked when:

 * the lock is an user lock from the current user
 * the lock is a token lock from the current desktop files client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 09:25:32 +02:00
Matthieu Gallien
92f7247bc6 add seemingly needed qml import path
will hopefuly make the qml engine search inside install dir within qml
sub folder

Close #7156

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 16:43:04 +02:00
Matthieu Gallien
97d1cfb1d1 rename our Window component to MainWindow to not use an existing name
we import QtQuick module that also define Window component name

to avoid any ambiguity, just use a different name on our side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 16:43:04 +02:00
Matthieu Gallien
c67456b5b7 change the order of imports in Window.qml
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 16:43:04 +02:00
Matthieu Gallien
b1352ecd98 provide LOCK token when uploading a single file via PUT
for simple webDAV upload via PUT verb, provide the needed lock token

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 15:06:29 +02:00
Matthieu Gallien
afaaf308aa if a file is locked/ provide token during upload
will add needed lock token in final move headers for chunk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 15:06:29 +02:00
Matthieu Gallien
451faaf0e1 receive and decode tokens for locks
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 15:06:29 +02:00
Matthieu Gallien
948a3716c6 store lock tokens in database
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-25 15:06:29 +02:00
Claudio Cambra
c16b6205f1 Ensure we hide the combo box for multiple override servers by default
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
72fe0d8818 Display server URL in multi-server enforced combo box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
d84ede3ef2 Do not automatically validate server URL when enforced servers is active but have multiple servers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
0663120f4f Use url method instead of text field contents as url when deciding on error string in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
5c08e45019 If using multi-server override url and forcing it then provide combo box selection url as url in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
6358f00263 Accept combo box selection as completed state in setup page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
1decedd56f Show or hide multi-server overrides or text field depending on type of override url
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
e3979ea52f Do not apply override server url as account url if this is a multi-server JSON string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
a2c818e157 Add property for detecting of application override server url is in fact a JSON array string describing multiple servers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
c65b544757 Add combo box to setup page UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-24 10:39:45 +02:00
Claudio Cambra
389d6536e5 Revert "Merge pull request #6986 from nextcloud/feature/alwaysEnableHttp2"
This reverts commit 5baec6f128, reversing
changes made to ab06ecbc4d.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 13:19:22 +02:00
Claudio Cambra
9455dcfd8a Remove now unneeded deployment target checks in CMake
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-23 10:32:34 +02:00
Matthieu Gallien
7a6691f6e0
as a last resort, try to update VFS metadata of folders when discovered
when doing local discovery, it is possible that files or folders may be
discovered with VFS metadata not up to date (i.e. placeholder file not
set in sync)

in such case, generate a propagation instruction to set them in sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-16 12:10:42 +02:00
Matthieu Gallien
da920f6d4e
ensure proper VFS metadata when restoring folders
when remote move is forbidden, desktop client will move back the folder
to its original name

in such cases, we were forgetting to set VFS metadata in their proper
state (i.e. placeholder in sync)

so ensure that when a remote move fails, we still touch VFS metadata
when appropriate and handle errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-16 12:10:42 +02:00
Camila Ayres
6cde9c8cc8
Remove extra ';'
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:35:33 +02:00
Camila Ayres
72e5ff4f4d
Fix wrong Style property.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:11 +02:00
Camila Ayres
bf50e2d167
Fix error: Audio is not a type.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:11 +02:00
Camila Ayres
939eb00f2c
Remove user status hover effect and background color.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:11 +02:00
Camila Ayres
9e5192ead3
Add todo: check if we should keep bottomUnifiedSearchInputSeparator.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:11 +02:00
Camila Ayres
5c79e02baa
Add todo: fix predefined status list.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:11 +02:00
Camila Ayres
0087245d46
Fix emoji selector page: transparency made it unusable. Use windows background color.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
4c659fa519
Adjust radius values: main window and text input uses bigger value, dropdown menus uses half.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
0cc60163fe
Add the same round background rectangle for the talk reply text field.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
912cf693e7
Remove extra ';'
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
1354b63153
Fix height of text input fields and radius.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
228e561d66
Fix unified search input placeholder text alignment and radius.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:10 +02:00
Camila Ayres
da12402206
Fix warning: TypeError: Cannot read property 'height'/'width' of null.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
9d3312a896
Fix the color of the tab icons in the files details page.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
d3ca7a02eb
Add margin space to the right of the 3 dots user menu.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
c5546c1232
Add radius value, border and hover colors in the folder's menus.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
2d91aa9000
Use the same radius value, border colors and hover colors in all header menus.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
eab2088a5d
Match the apps menu list look with the user's list look.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
9a134d9f54
Use Style.trayFolderStatusIndicatorRadiusFactor in the UserLine.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:09 +02:00
Camila Ayres
9e8fa84787
Use palette.window as header background color.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
16986c2233
Add colored to base colors.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
fa8048c70c
Fix display of icons in dark/light theme.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
589bff16df
Fix dark/light mode for account menu.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
bbf4f3125a
Fix caret-down icon theme, size and alignment.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
f8a0551dba
Fix tray header light/dark theme.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:03 +02:00
Jyrki Gadinger
34785c2fd2 gui: add some context for translators
Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2024-09-13 11:41:07 +02:00
Claudio Cambra
6b0e485ab9 Notify even if pre-fetch etag header is empty
This prevents situations where the server does not provide an etag header. This would make the empty pre-fetch and empty post-fetch etag headers match, meaning notifications would never be notified

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:52:54 +02:00
Claudio Cambra
291f0c8c85 Make sure we do not renotify notifications when we have received the same etag as during the last check
Do this regardless of what the server's response is

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:52:54 +02:00
Matthieu Gallien
7a3ed38040 improve some log that are produced during discovery
would be usefull to track bugs during rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
092175e23a avoid wrong tracking of renamed folders during discovery
ensure server rename operations are tracked as server rename operations

ensure local rename are tracked as local rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
8faefc6fa2 delete invalid folders and restart sync automatically
users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
34c25ecb43 let FileSystem::removeRecursively be able to delete read-only folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
a118c0ad1e detect remnants read-only folders to delete: try to delete them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
155c61acbb let cancel sync and finish sync lambda be reusable methods
will enable implementation of other ways to interrupt sync after
discovery to get user feedback

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
b7b72bf9f2 collect remnant read-only folders during discovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Claudio Cambra
72ff92468b
Wrap use of folder permissions restore in mac ifdefs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 14:21:25 +08:00
Claudio Cambra
6f393f1c63
Wrap all uses of FileSystem::setFolderPermissions in ifdefs for macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 14:18:15 +08:00
Matthieu Gallien
9fc15d4401
Merge pull request #6949 from suiso67/fix/excessive-folder-permission
Narrow down ReadWrite folder permission to owner
2024-09-09 16:03:49 +02:00
Matthieu Gallien
f33674e679 do not ignore paths containing 2 "#" characters
those path may be in use on Windows and are legitimate

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-09 11:03:57 +02:00
Jyrki Gadinger
8f705e50e6 gui: remove Systray::setToolTip
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2024-09-09 09:57:33 +02:00
Jyrki Gadinger
45fa561e64 gui: add some extra syncing details to the tray tooltips
There was some unused code that updated some status bar text -- this is
now part of the tooltip during syncing.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2024-09-09 09:57:33 +02:00
Matthieu Gallien
0b3a019d19
add missing exception handling
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 16:02:38 +02:00
Camila Ayres
20ef57c682 Fix talk app icon.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
6f13fa6269 qrc:/// => image://
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d05ebc33c9 Remove more color customizations from Window and TrayFoldersMenuButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
6b5041a55e Remove background hover customization from UserLine.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
e55dae140f Remove customization for font color from EnforcedPlainTextLabel.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
5073be1c0e Remove customizations for hover background from the user menu options.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
1b117d7b2d Fix font color light/dark of time in ActivityItemContent.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
3201e8b939 Remove backround rectangle from NCInputTextEdit.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
a91cd69159 Remove customization for text color and hover from TextButtonContents.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
3ad7964a51 Remove customizaton for placeholder text color from UnifiedSearchInputContainer.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
4f92ef391a Remove cutomizations for text color and hover from ActivityActionButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d0e0843b10 Remove image hover from NCButtonContents and CustomButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
a3ca3bc3ec Remove duplicated header image.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
0e1d3da79d Remove the component version from import.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
73bc834933 Remove backround customization from ShareeSearchField.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
a4aedd77df NCRadioButton => RadioButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d8acedb960 Remove customizations from CustomButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
b90d7c0623 Remove setting contentsFont, not used anymore in CustomButton.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
653ecbfdb3 Clean HeaderButton component from customizations.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
4f7b73cb70 Fix warning: The current style does not support customization of this control (property: "background").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
24e1606d6a Fix warning: The current style does not support customization of this control (property: "indicator").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
f612e59880 Fix warning: The current style does not support customization of this control (property: "contextItem").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d8883d05c4 Fix warning: The current style does not support customization of this control (property: "background").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
599bbbed2a Fix warning: The current style does not support customization of this control (property: "contentItem").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
38f81c0b57 Fix warning: The current style does not support customization of this control (property: "background").
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
66e2882236 Remove custom properties for text color/hover from CustomButton and NCButtonContents components.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
3c5066fede Remove custom properties for background and opacity from CustomButton component.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
0236e883a8 Fix repeaded call to QQuickStyle::setStyle.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
fb17a4bf9e Replace NCToolTip for ToolTip.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
279c3c3981 Change default Qt quick control style depending on the platform.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
2d08cdb503 remove broken system paellete detection within our custom style
remove custom binding between c++ native Qt API for system palette and
our QML styling code for colors detection

fixes many issues with dark mode using Windows native style

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
9cecd59c6e use new QStyleHints::colorScheme feature to use light or dark mode
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
4a8d0cf6d7 add a QQuickStyle fallback: Fusion is fallback style
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
f4c5151084 let main dialog have a transparent background again
will fix white corners appearing below the main dialog content

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d68fa5fce6 Remove qml component version from import.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
10d6224235 Remove component versions under src/gui/tray.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
a1a832efd8 remove any use of custom palette: use the style palette
should get us native colors as much as possible

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
a81c60c238 let's not make the background color of main dialog be transparent
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Matthieu Gallien
690ebccbe3 set the windows native qml style on windows systems
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-06 10:42:08 +02:00
Camila Ayres
d8185e69c8 Change default Qt quick control style depending on the platform.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 10:42:08 +02:00
alex-z
de18970443 Revert "Fix incorrect date parsing."
This reverts commit 04c0125bd1.

Signed-off-by: alex-z <blackslayer4@gmail.com>
2024-09-05 19:01:37 +02:00
Matthieu Gallien
fcc325ffbb ensure detection of entry type on windows is reliable
it seems that there is a possibility for the type detection to report a
folder as being a file

with this change, I am pretty sure that cannot happen any longer

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-05 10:49:30 +02:00
Matthieu Gallien
2c30093680 only add Encrypt context menu entry for top folder in settings dialog
will omit Encrypt menu item for child fodlers as displayed in selective
sync folders tree in settings dialog

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-03 08:46:14 +02:00
Matthieu Gallien
883cdcc0ba remove the frame around the sync folders settings area
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:41:32 +02:00
Matthieu Gallien
8171f9575f also include temporary files from WAL SQLite mode into debug archive
should make sure that the debug archive has a correct up to date view of
the sync client database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:36:33 +02:00
Matthieu Gallien
0ac6c27a2f add missing logs and checks for database errors
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:36:33 +02:00
Matthieu Gallien
7a979c732a properly detect and enable Qt6 WebEngine integration
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:35:04 +02:00
Matthieu Gallien
4d114a4f89 on windows use QWidget native platform style
will make all QWidget based user interface look more native

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-28 11:06:35 +02:00
Matthieu Gallien
3e397e664d enable users to delete unexpected new folders inside a read-only folder
let unexpected new folders in read-only folders be read-write

would be done for folders that are inside a read-only folder and cannot
be uploaded because the parent folder is realy read-only

most probably those folders should never have been there

in case they would be read-only, users cannot delete them, in such
situation, letting them be read-write again should really help

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-23 09:56:44 +02:00
Matthieu Gallien
96d4062425 when deciding to create a new folder on server: check permissions
sometime we need to create a folder on server because some local files
or folders modifications would be lost without that

in that case instead of locally deleting teh folder, we create it back
on server

when doing that, it is important to check the remote permissions such
that we do not try to create a folder in a read-only folder on server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-23 09:56:44 +02:00
Matthieu Gallien
316af5c13f avoid wrong usage of QStringBuilder via auto type deduction
detected via https://github.com/KDE/clazy/blob/master/docs/checks/README-auto-unexpected-qstringbuilder.md#auto-unexpected-qstringbuilder

also reported by g++ via compile time warnings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 14:53:46 +02:00
Matthieu Gallien
539be0a16a only empty top folders offer the menu entry to encrypt
in the contextual menu shown in files explorer will show encrypt menu
entry only for top folders that are non-encrypted and empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
Matthieu Gallien
1c3743d670 only add encrypt menu entry for top folders
with current end-to-end encryption only top folders can be encrypted

limit the availability of the menu entry to top folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
Matthieu Gallien
5bb90c783e ensure the arguments of socket API commands are valid
fix string data being invalid when using QStringView

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
suiso67
a270756402 Narrow down ReadWrite folder permission to owner
Signed-off-by: suiso67 <suiso67@macadamia.rocks>
2024-08-21 22:12:42 +09:00
Matthieu Gallien
8dcbdebd02 make folders read-write when needed when deleting local items
if a folder is read-only, when deleting content inside this folder, it
may be needed to make it temporary read-write

do this as required by the automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-21 14:38:21 +02:00
Claudio Cambra
abb1f89119 When forbidden filename sync warning is encountered, add reason why the filename is forbidden to the item's error string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
788067598d Store forbidden filename match bools outside of if statement
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
598f2c95f5 Set invalid filename dialog mode in activity list model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
aaf06535d2 Provide different message and explanation strings in invalid filename dialog depending on invalid mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
f07b49288b Add invalid mode enum to invalid filename dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
94d62e0203 Handle invalid filename activities button verb in activity list model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
a9dfc6ebfc Add rename file link/button to invalid filename activities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
eb189f8fb4 Also provide notification for items that have file name invalid on server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
1578cb1938 Assign invalid filename on server syncfileitem status to items with forbidden filenames
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
29ab9ec95d Check for new forbidden filename-related capabilities during exclusion handling in discovery
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
8f7ad48e96 Parse forbidden filename related capability features
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
raldone01
e75d77c27c Fixes cropped thumbnails #6154
Signed-off-by: raldone01 <raldone01@gmail.com>
2024-08-20 15:15:41 +02:00
Josh
83d1ed4869 fix(settings): Use broken lock icon when not using https
Fixes #6723 

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-20 10:04:52 +02:00
Camila Ayres
5207937f33 Remove systray call to display network errors.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-08-12 17:51:19 +02:00
Matthieu Gallien
c39e94ef6f fix header buttons background color to match existing colors
the bckground of buttons on teh top bar of main dialog had a wrong color
not matching the top bar background color

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-12 16:53:33 +02:00
Matthieu Gallien
4cbaa1b4a5 avoid transparent background in user menu from main dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-12 16:53:33 +02:00
Matthieu Gallien
16c1cd1b19 remove most usages of transparent background: fix visual regressions
with transparent backgrounds, most of teh time the result is hard to
read

that is mostly unintended and unless there is some blur added, the UI
becomes unusable

Close https://github.com/nextcloud/desktop/issues/6992

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-12 16:53:33 +02:00
Claudio Cambra
b4d719e914 Make multiple notifications text translatable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-12 16:52:41 +02:00