From f39542688a2536a8f4645c84909c2bdee002d7a9 Mon Sep 17 00:00:00 2001 From: Kevin Ottens Date: Mon, 5 Oct 2020 15:48:39 +0200 Subject: [PATCH] Handle redirects when downloading updates This is necessary for downloads coming from Github for instance. They are systematically redirected and we'd just fail the download. Signed-off-by: Kevin Ottens --- src/gui/updater/ocupdater.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gui/updater/ocupdater.cpp b/src/gui/updater/ocupdater.cpp index 66528f8dc..3f772ef01 100644 --- a/src/gui/updater/ocupdater.cpp +++ b/src/gui/updater/ocupdater.cpp @@ -304,7 +304,9 @@ void NSISUpdater::versionInfoArrived(const UpdateInfo &info) if (QFile(_targetFile).exists()) { setDownloadState(DownloadComplete); } else { - QNetworkReply *reply = qnam()->get(QNetworkRequest(QUrl(url))); + auto request = QNetworkRequest(QUrl(url)); + request.setAttribute(QNetworkRequest::RedirectPolicyAttribute, QNetworkRequest::NoLessSafeRedirectPolicy); + QNetworkReply *reply = qnam()->get(request); connect(reply, &QIODevice::readyRead, this, &NSISUpdater::slotWriteFile); connect(reply, &QNetworkReply::finished, this, &NSISUpdater::slotDownloadFinished); setDownloadState(Downloading);