mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-28 19:58:56 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add more raw string literals missed previously

Browse source 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
This commit is contained in:
Kevin Ottens 2020-06-04 14:09:06 +02:00
parent ed1c2eaab4
commit c50a968a1e
No known key found for this signature in database
GPG key ID: 074BBBCB8DECC9E2
9 changed files with 26 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.clang-tidy
View file

@ -1,6 +1,7 @@
Checks: '-*, Checks: '-*,
cppcoreguidelines-init-variables, cppcoreguidelines-init-variables,
modernize-make-*, modernize-make-*,
modernize-raw-string-literal,
modernize-redundant-void-arg, modernize-redundant-void-arg,
modernize-replace-*, modernize-replace-*,
modernize-return-braced-init-list, modernize-return-braced-init-list,

10
shell_integration/windows/OCContextMenu/OCContextMenuRegHandler.cpp
View file

@ -85,7 +85,7 @@ HRESULT OCContextMenuRegHandler::RegisterInprocServer(PCWSTR pszModule, const CL
wchar_t szSubkey[MAX_PATH]; wchar_t szSubkey[MAX_PATH];
// Create the HKCR\CLSID\{<CLSID>} key. // Create the HKCR\CLSID\{<CLSID>} key.
hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), L"CLSID\\%s", szCLSID); hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), LR"(CLSID\%s)", szCLSID);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
hr = SetHKCRRegistryKeyAndValue(szSubkey, nullptr, pszFriendlyName); hr = SetHKCRRegistryKeyAndValue(szSubkey, nullptr, pszFriendlyName);
@ -94,7 +94,7 @@ HRESULT OCContextMenuRegHandler::RegisterInprocServer(PCWSTR pszModule, const CL
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey),
L"CLSID\\%s\\InprocServer32", szCLSID); LR"(CLSID\%s\InprocServer32)", szCLSID);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
// Set the default value of the InprocServer32 key to the // Set the default value of the InprocServer32 key to the
@ -123,7 +123,7 @@ HRESULT OCContextMenuRegHandler::UnregisterInprocServer(const CLSID& clsid)
wchar_t szSubkey[MAX_PATH]; wchar_t szSubkey[MAX_PATH];
// Delete the HKCR\CLSID\{<CLSID>} key. // Delete the HKCR\CLSID\{<CLSID>} key.
hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), L"CLSID\\%s", szCLSID); hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), LR"(CLSID\%s)", szCLSID);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
hr = HRESULT_FROM_WIN32(RegDelnode(HKEY_CLASSES_ROOT, szSubkey)); hr = HRESULT_FROM_WIN32(RegDelnode(HKEY_CLASSES_ROOT, szSubkey));
@ -167,7 +167,7 @@ HRESULT OCContextMenuRegHandler::RegisterShellExtContextMenuHandler(
// Create the key HKCR\<File Type>\shellex\ContextMenuHandlers\{friendlyName>} // Create the key HKCR\<File Type>\shellex\ContextMenuHandlers\{friendlyName>}
hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey),
L"%s\\shellex\\ContextMenuHandlers\\%s", pszFileType, pszFriendlyName); LR"(%s\shellex\ContextMenuHandlers\%s)", pszFileType, pszFriendlyName);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
// Set the default value of the key. // Set the default value of the key.
@ -208,7 +208,7 @@ HRESULT OCContextMenuRegHandler::UnregisterShellExtContextMenuHandler(
// Remove the HKCR\<File Type>\shellex\ContextMenuHandlers\{friendlyName} key. // Remove the HKCR\<File Type>\shellex\ContextMenuHandlers\{friendlyName} key.
hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey), hr = StringCchPrintf(szSubkey, ARRAYSIZE(szSubkey),
L"%s\\shellex\\ContextMenuHandlers\\%s", pszFileType, pszFriendlyName); LR"(%s\shellex\ContextMenuHandlers\%s)", pszFileType, pszFriendlyName);
if (SUCCEEDED(hr)) if (SUCCEEDED(hr))
{ {
hr = HRESULT_FROM_WIN32(RegDelnode(HKEY_CLASSES_ROOT, szSubkey)); hr = HRESULT_FROM_WIN32(RegDelnode(HKEY_CLASSES_ROOT, szSubkey));

2
shell_integration/windows/OCUtil/CommunicationSocket.cpp
View file

@ -44,7 +44,7 @@ std::wstring getUserName() {
std::wstring CommunicationSocket::DefaultPipePath() std::wstring CommunicationSocket::DefaultPipePath()
{ {
auto pipename = std::wstring(L"\\\\.\\pipe\\"); auto pipename = std::wstring(LR"(\\.\pipe\)");
pipename += L"ownCloud-"; pipename += L"ownCloud-";
pipename += getUserName(); pipename += getUserName();
return pipename; return pipename;

4
src/common/filesystembase.h
View file

@ -175,10 +175,10 @@ namespace FileSystem {
if( str[0] == '/' || str[0] == '\\' ) { if( str[0] == '/' || str[0] == '\\' ) {
// Don't prepend if already UNC // Don't prepend if already UNC
if( !(len > 1 && (str[1] == '/' || str[1] == '\\')) ) { if( !(len > 1 && (str[1] == '/' || str[1] == '\\')) ) {
longStr.append("\\\\?"); longStr.append(R"(\\?)");
} }
} else { } else {
longStr.append("\\\\?\\"); // prepend string by this four magic chars. longStr.append(R"(\\?\)"); // prepend string by this four magic chars.
} }
longStr += str; longStr += str;

2
src/common/utility.cpp
View file

@ -666,7 +666,7 @@ QByteArray Utility::conflictFileBaseName(const QByteArray &conflictName)
QString Utility::sanitizeForFileName(const QString &name) QString Utility::sanitizeForFileName(const QString &name)
{ {
const auto invalid = QStringLiteral("/?<>\\:*|\""); const auto invalid = QStringLiteral(R"(/?<>\:*|")");
QString result; QString result;
result.reserve(name.size()); result.reserve(name.size());
for (const auto c : name) { for (const auto c : name) {

4
src/common/utility_win.cpp
View file

@ -25,7 +25,7 @@
#include <string> #include <string>
#include <QLibrary> #include <QLibrary>
static const char runPathC[] = "HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Run"; static const char runPathC[] = R"(HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run)";
namespace OCC { namespace OCC {
@ -91,7 +91,7 @@ void setLaunchOnStartup_private(const QString &appName, const QString &guiName,
static inline bool hasDarkSystray_private() static inline bool hasDarkSystray_private()
{ {
if(Utility::registryGetKeyValue( HKEY_CURRENT_USER, if(Utility::registryGetKeyValue( HKEY_CURRENT_USER,
"Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize", R"(Software\Microsoft\Windows\CurrentVersion\Themes\Personalize)",
"SystemUsesLightTheme" ) == 1) { "SystemUsesLightTheme" ) == 1) {
return false; return false;
} }

4
src/gui/navigationpanehelper.cpp
View file

@ -68,7 +68,7 @@ void NavigationPaneHelper::updateCloudStorageRegistry()
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
Utility::registryWalkSubKeys( Utility::registryWalkSubKeys(
HKEY_CURRENT_USER, HKEY_CURRENT_USER,
QStringLiteral("Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Desktop\\NameSpace"), QStringLiteral(R"(Software\Microsoft\Windows\CurrentVersion\Explorer\Desktop\NameSpace)"),
[&entriesToRemove](HKEY key, const QString &subKey) { [&entriesToRemove](HKEY key, const QString &subKey) {
QVariant appName = Utility::registryGetKeyValue(key, subKey, QStringLiteral("ApplicationName")); QVariant appName = Utility::registryGetKeyValue(key, subKey, QStringLiteral("ApplicationName"));
if (appName.toString() == QLatin1String(APPLICATION_NAME)) { if (appName.toString() == QLatin1String(APPLICATION_NAME)) {
@ -138,7 +138,7 @@ void NavigationPaneHelper::updateCloudStorageRegistry()
// Step 11: Register your extension in the namespace root // Step 11: Register your extension in the namespace root
Utility::registrySetKeyValue(HKEY_CURRENT_USER, namespacePath, QString(), REG_SZ, title); Utility::registrySetKeyValue(HKEY_CURRENT_USER, namespacePath, QString(), REG_SZ, title);
// Step 12: Hide your extension from the Desktop // Step 12: Hide your extension from the Desktop
Utility::registrySetKeyValue(HKEY_CURRENT_USER, QStringLiteral("Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\HideDesktopIcons\\NewStartPanel"), clsidStr, REG_DWORD, 0x1); Utility::registrySetKeyValue(HKEY_CURRENT_USER, QStringLiteral(R"(Software\Microsoft\Windows\CurrentVersion\Explorer\HideDesktopIcons\NewStartPanel)"), clsidStr, REG_DWORD, 0x1);
// For us, to later be able to iterate and find our own namespace entries and associated CLSID. // For us, to later be able to iterate and find our own namespace entries and associated CLSID.
// Use the macro instead of the theme to make sure it matches with the uninstaller. // Use the macro instead of the theme to make sure it matches with the uninstaller.

2
test/csync/csync_tests/check_csync_exclude.cpp
View file

@ -681,7 +681,7 @@ static void check_csync_exclude_expand_escapes(void **state)
{ {
(void)state; (void)state;
QByteArray line = "keep \\' \\\" \\? \\\\ \\a \\b \\f \\n \\r \\t \\v \\z \\#"; QByteArray line = R"(keep \' \" \? \\ \a \b \f \n \r \t \v \z \#)";
csync_exclude_expand_escapes(line); csync_exclude_expand_escapes(line);
assert_true(0 == strcmp(line.constData(), "keep ' \" ? \\\\ \a \b \f \n \r \t \v \\z #")); assert_true(0 == strcmp(line.constData(), "keep ' \" ? \\\\ \a \b \f \n \r \t \v \\z #"));

22
test/csync/encoding_tests/check_encoding.cpp
View file

@ -116,35 +116,35 @@ static void check_long_win_path(void **state)
{ {
const char *path = "C://DATA/FILES/MUSIC/MY_MUSIC.mp3"; // check a short path const char *path = "C://DATA/FILES/MUSIC/MY_MUSIC.mp3"; // check a short path
const char *exp_path = "\\\\?\\C:\\\\DATA\\FILES\\MUSIC\\MY_MUSIC.mp3"; const char *exp_path = R"(\\?\C:\\DATA\FILES\MUSIC\MY_MUSIC.mp3)";
QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path))); QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path)));
assert_string_equal(new_short, exp_path); assert_string_equal(new_short, exp_path);
} }
{ {
const char *path = "\\\\foo\\bar/MY_MUSIC.mp3"; const char *path = R"(\\foo\bar/MY_MUSIC.mp3)";
const char *exp_path = "\\\\foo\\bar\\MY_MUSIC.mp3"; const char *exp_path = R"(\\foo\bar\MY_MUSIC.mp3)";
QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path))); QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path)));
assert_string_equal(new_short, exp_path); assert_string_equal(new_short, exp_path);
} }
{ {
const char *path = "//foo\\bar/MY_MUSIC.mp3"; const char *path = R"(//foo\bar/MY_MUSIC.mp3)";
const char *exp_path = "\\\\foo\\bar\\MY_MUSIC.mp3"; const char *exp_path = R"(\\foo\bar\MY_MUSIC.mp3)";
QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path))); QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path)));
assert_string_equal(new_short, exp_path); assert_string_equal(new_short, exp_path);
} }
{ {
const char *path = "\\foo\\bar"; const char *path = "\\foo\\bar";
const char *exp_path = "\\\\?\\foo\\bar"; const char *exp_path = R"(\\?\foo\bar)";
QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path))); QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path)));
assert_string_equal(new_short, exp_path); assert_string_equal(new_short, exp_path);
} }
{ {
const char *path = "/foo/bar"; const char *path = "/foo/bar";
const char *exp_path = "\\\\?\\foo\\bar"; const char *exp_path = R"(\\?\foo\bar)";
QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path))); QByteArray new_short = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(path, strlen(path)));
assert_string_equal(new_short, exp_path); assert_string_equal(new_short, exp_path);
} }
@ -153,10 +153,10 @@ static void check_long_win_path(void **state)
"elonglonglonglong/flonglonglonglong/glonglonglonglong/hlonglonglonglong/ilonglonglonglong/" "elonglonglonglong/flonglonglonglong/glonglonglonglong/hlonglonglonglong/ilonglonglonglong/"
"jlonglonglonglong/klonglonglonglong/llonglonglonglong/mlonglonglonglong/nlonglonglonglong/" "jlonglonglonglong/klonglonglonglong/llonglonglonglong/mlonglonglonglong/nlonglonglonglong/"
"olonglonglonglong/file.txt"; "olonglonglonglong/file.txt";
const char *longPathConv = "\\\\?\\D:\\\\alonglonglonglong\\blonglonglonglong\\clonglonglonglong\\dlonglonglonglong\\" const char *longPathConv = R"(\\?\D:\\alonglonglonglong\blonglonglonglong\clonglonglonglong\dlonglonglonglong\)"
"elonglonglonglong\\flonglonglonglong\\glonglonglonglong\\hlonglonglonglong\\ilonglonglonglong\\" R"(elonglonglonglong\flonglonglonglong\glonglonglonglong\hlonglonglonglong\ilonglonglonglong\)"
"jlonglonglonglong\\klonglonglonglong\\llonglonglonglong\\mlonglonglonglong\\nlonglonglonglong\\" R"(jlonglonglonglong\klonglonglonglong\llonglonglonglong\mlonglonglonglong\nlonglonglonglong\)"
"olonglonglonglong\\file.txt"; R"(olonglonglonglong\file.txt)";
QByteArray new_long = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(longPath, strlen(longPath))); QByteArray new_long = OCC::FileSystem::pathtoUNC(QByteArray::fromRawData(longPath, strlen(longPath)));
// printf("XXXXXXXXXXXX %s %d\n", new_long, mem_reserved); // printf("XXXXXXXXXXXX %s %d\n", new_long, mem_reserved);