mirror of
https://github.com/nextcloud/desktop.git
synced 2024-11-27 09:12:01 +03:00
Always follow redirects in network jobs (#4905)
This is a move away from the original policy where jobs would only follow redirects in special cases. Two restrictions are in place: 1. We do not allow protocol downgrades (https -> http) 2. We stop redirects after we find them looping (e.g. old = new url, or indirectly when looping 10 times). This is closer to RFC conforming behavior, although currently we will treat 301 replies like they were 302. This is for a separate commit. Error handling (and display) also needs improvement. Addresses #2791
This commit is contained in:
parent
60904496d2
commit
bb5c2cbfa5
3 changed files with 1 additions and 3 deletions
|
@ -43,7 +43,7 @@ namespace OCC {
|
|||
AbstractNetworkJob::AbstractNetworkJob(AccountPtr account, const QString &path, QObject *parent)
|
||||
: QObject(parent)
|
||||
, _timedout(false)
|
||||
, _followRedirects(false)
|
||||
, _followRedirects(true)
|
||||
, _account(account)
|
||||
, _ignoreCredentialFailure(false)
|
||||
, _reply(0)
|
||||
|
|
|
@ -359,7 +359,6 @@ CheckServerJob::CheckServerJob(AccountPtr account, QObject *parent)
|
|||
: AbstractNetworkJob(account, QLatin1String(statusphpC) , parent)
|
||||
, _subdirFallback(false)
|
||||
{
|
||||
_followRedirects = true;
|
||||
setIgnoreCredentialFailure(true);
|
||||
}
|
||||
|
||||
|
|
|
@ -99,7 +99,6 @@ void GETFileJob::start() {
|
|||
} else {
|
||||
// Use direct URL
|
||||
setReply(davRequest("GET", _directDownloadUrl, req));
|
||||
_followRedirects = true; // (follow redirections for the direct download)
|
||||
}
|
||||
setupConnections(reply());
|
||||
|
||||
|
|
Loading…
Reference in a new issue