mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-26 06:55:59 +03:00
Code Issues Projects Releases Packages Wiki Activity

no oneliner if: a bug waiting to happen

Browse source 
it is much too easy to get a bug because one could miss the lask of {
and }

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
This commit is contained in:
Matthieu Gallien 2021-09-08 12:11:03 +02:00
parent 51a77bac28
commit b0ef5e0635
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/libsync/owncloudpropagator.cpp
View file

@ -1106,15 +1106,18 @@ qint64 PropagateRootDirectory::committedDiskSpace() const
bool PropagateRootDirectory::scheduleSelfOrChild()
{
if (_state == Finished)
if (_state == Finished) {
return false;
}
if (PropagateDirectory::scheduleSelfOrChild())
if (PropagateDirectory::scheduleSelfOrChild()) {
return true;
}
// Important: Finish _subJobs before scheduling any deletes.
if (_subJobs._state != Finished)
if (_subJobs._state != Finished) {
return false;
}
return _dirDeletionJobs.scheduleSelfOrChild();
}