mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-27 06:45:49 +03:00
Code Issues Projects Releases Packages Wiki Activity

OwncloudWizard: Mark vfs as tech preview instead of experimental

Browse source
This commit is contained in:
Hannah von Reth 2019-08-15 13:58:25 +02:00 committed by Kevin Ottens
parent e5a36c3bc6
commit afc9cd2f46
No known key found for this signature in database
GPG key ID: 074BBBCB8DECC9E2
2 changed files with 12 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gui/folderwizard.cpp
View file

@ -492,7 +492,8 @@ FolderWizardSelectiveSync::FolderWizardSelectiveSync(const AccountPtr &account)
layout->addWidget(_selectiveSync);
if (Theme::instance()->showVirtualFilesOption() && bestAvailableVfsMode() != Vfs::Off) {
_virtualFilesCheckBox = new QCheckBox(tr("Use virtual files instead of downloading content immediately (experimental)"));
_virtualFilesCheckBox = new QCheckBox(tr("Use virtual files instead of downloading content immediately %1").arg(
bestAvailableVfsMode() == Vfs::WindowsCfApi ? tr("(tech preview)") : tr("(experimental)")));
connect(_virtualFilesCheckBox, &QCheckBox::clicked, this, &FolderWizardSelectiveSync::virtualFilesCheckboxClicked);
connect(_virtualFilesCheckBox, &QCheckBox::stateChanged, this, [this](int state) {
_selectiveSync->setEnabled(state == Qt::Unchecked);

23
src/gui/wizard/owncloudwizard.cpp
View file

@ -332,27 +332,24 @@ void OwncloudWizard::bringToTop()
void OwncloudWizard::askExperimentalVirtualFilesFeature(const std::function<void(bool enable)> &callback)
{
auto bestVfsMode = bestAvailableVfsMode();
const auto bestVfsMode = bestAvailableVfsMode();
QMessageBox *msgBox = nullptr;
if (bestVfsMode == Vfs::WindowsCfApi) {
msgBox = new QMessageBox(
QMessageBox::Warning,
tr("Enable experimental feature?"),
tr("Enable technical preview feature?"),
tr("When the \"virtual files\" mode is enabled no files will be downloaded initially. "
"Instead a placeholder file will be created for each file that exists on the server. "
"Instead a virtual file will be created for each file that exists on the server. "
"When a file is opened its contents will be downloaded automatically. "
"Alternatively files can be downloaded manually by using their context menu."
"Alternatively, files can be downloaded manually by using their context menu."
"\n\n"
"The virtual files mode is mutually exclusive with selective sync. "
"Currently unselected folders will be translated to online-only folders "
"and your selective sync settings will be reset."
"\n\n"
"Switching to this mode will abort any currently running synchronization."
"\n\n"
"This is a new, experimental mode. If you decide to use it, please report any "
"issues that come up."));
"and your selective sync settings will be reset."));
msgBox->addButton(tr("Enable virtual files"), QMessageBox::AcceptRole);
msgBox->addButton(tr("Continue to use selective sync"), QMessageBox::RejectRole);
} else {
ASSERT(bestVfsMode == Vfs::WithSuffix);
ASSERT(bestVfsMode == Vfs::WithSuffix)
msgBox = new QMessageBox(
QMessageBox::Warning,
tr("Enable experimental feature?"),
@ -369,9 +366,9 @@ void OwncloudWizard::askExperimentalVirtualFilesFeature(const std::function<void
"This is a new, experimental mode. If you decide to use it, please report any "
"issues that come up.")
.arg(APPLICATION_DOTVIRTUALFILE_SUFFIX));
msgBox->addButton(tr("Enable experimental placeholder mode"), QMessageBox::AcceptRole);
msgBox->addButton(tr("Stay safe"), QMessageBox::RejectRole);
}
msgBox->addButton(tr("Enable experimental mode"), QMessageBox::AcceptRole);
msgBox->addButton(tr("Stay safe"), QMessageBox::RejectRole);
connect(msgBox, &QMessageBox::finished, msgBox, [callback, msgBox](int result) {
callback(result == QMessageBox::AcceptRole);
msgBox->deleteLater();