mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-23 04:45:43 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add logging on error for proxy password saving

Browse source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2024-07-08 00:36:28 +08:00
parent 70e7bcf9a0
commit a8c5cbced4
No known key found for this signature in database
GPG key ID: C839200C384636B0
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/gui/accountmanager.cpp
View file

@ -354,14 +354,19 @@ void AccountManager::saveAccountHelper(Account *acc, QSettings &settings, bool s
settings.setValue(networkUploadLimitC, acc->uploadLimit());
settings.setValue(networkDownloadLimitC, acc->downloadLimit());
const auto proxyPassword = acc->proxyPassword();
const auto proxyPasswordKey = QString(acc->davUser() + networkProxyPasswordKeychainKeySuffixC);
if (proxyPassword.isEmpty()) {
if (const auto proxyPassword = acc->proxyPassword(); proxyPassword.isEmpty()) {
const auto job = new KeychainChunk::DeleteJob(proxyPasswordKey, this);
Q_ASSERT(job->exec());
if (job->error() != QKeychain::NoError) {
qCWarning(lcAccountManager) << "Failed to delete proxy password from keychain" << job->errorString();
}
} else {
const auto job = new KeychainChunk::WriteJob(acc, proxyPasswordKey, proxyPassword.toUtf8(), this);
Q_ASSERT(job->exec());
if (job->error() != QKeychain::NoError) {
qCWarning(lcAccountManager) << "Failed to save proxy password to keychain" << job->errorString();
}
}
if (acc->_credentials) {
@ -509,6 +514,8 @@ AccountPtr AccountManager::loadAccountHelper(QSettings &settings)
if (job->error() == QKeychain::NoError) {
const auto password = job->textData();
acc->setProxyPassword(password);
} else {
qCWarning(lcAccountManager) << "Failed to read proxy password from keychain" << job->errorString();
}
// now the server cert, it is in the general group